bug#31855: 27.0.50; Async shell command finished message not visible any more

bug#31855: 27.0.50; Async shell command finished message not visible any more

[Michael Heerdegen]

Hi,

I'm not sure if this issue has any other relation to `shell-command'
than it's where the problem occurs to me - anyway:

In emacs25 -Q, I type, for example, M-! t r u e SPC & <return>, and the
echo area displays "true: finished".

In master emacs -Q, doing the same gives you no visible feedback any
more.  A message is logged in *Messages*, but it seems to be dismissed
immediately.


TIA;

Michael.


In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.29)
 of 2018-06-16 built on drachen
Repository revision: aa0f4760996d82610ea0010919436729f08b2883
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Debian GNU/Linux buster/sid

bug#31855: 27.0.50; Async shell command finished message not visible any more

[Eli Zaretskii]

> From: Michael Heerdegen <michael_heerdegen@web.de>
> Date: Sat, 16 Jun 2018 07:12:50 +0200
> 
> In emacs25 -Q, I type, for example, M-! t r u e SPC & <return>, and the
> echo area displays "true: finished".
> 
> In master emacs -Q, doing the same gives you no visible feedback any
> more.  A message is logged in *Messages*, but it seems to be dismissed
> immediately.

Daniel, this seems to be due to your recent changes in keyboard.c.  If
I make the change below, which reverts a small part of your changes,
the problem is gone:

diff --git a/src/keyboard.c b/src/keyboard.c
index 5409918..76097e8 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -8999,7 +8999,7 @@ read_key_sequence (Lisp_Object *keybuf, Lisp_Object prompt,
   /* These are no-ops the first time through, but if we restart, they
      revert the echo area and this_command_keys to their original state.  */
   this_command_key_count = keys_start;
-  if (INTERACTIVE && is_replay)
+  if (INTERACTIVE && t < mock_input)
     echo_truncate (echo_start);
   is_replay = true;
 

bug#31855: 27.0.50; Async shell command finished message not visible any more

[Daniel Colascione]

On 06/16/2018 01:48 AM, Eli Zaretskii wrote:
>> From: Michael Heerdegen <michael_heerdegen@web.de>
>> Date: Sat, 16 Jun 2018 07:12:50 +0200
>>
>> In emacs25 -Q, I type, for example, M-! t r u e SPC & <return>, and the
>> echo area displays "true: finished".
>>
>> In master emacs -Q, doing the same gives you no visible feedback any
>> more.  A message is logged in *Messages*, but it seems to be dismissed
>> immediately.
> 
> Daniel, this seems to be due to your recent changes in keyboard.c.  If
> I make the change below, which reverts a small part of your changes,
> the problem is gone:
> 
> diff --git a/src/keyboard.c b/src/keyboard.c
> index 5409918..76097e8 100644
> --- a/src/keyboard.c
> +++ b/src/keyboard.c
> @@ -8999,7 +8999,7 @@ read_key_sequence (Lisp_Object *keybuf, Lisp_Object prompt,
>     /* These are no-ops the first time through, but if we restart, they
>        revert the echo area and this_command_keys to their original state.  */
>     this_command_key_count = keys_start;
> -  if (INTERACTIVE && is_replay)
> +  if (INTERACTIVE && t < mock_input)
>       echo_truncate (echo_start);
>     is_replay = true;

Yep. You're right. I'll bring us back to the old logic here.

I just worry that the "t < mock_input" condition is wrong in the case 
where we use a function key map to rewrite an input to nothing, but 
maybe the improved last_nonmenu_event tracking will fix that class of 
problem by itself.

bug#31855: 27.0.50; Async shell command finished message not visible any more

[Michael Heerdegen]

Daniel Colascione <dancol@dancol.org> writes:

> > Daniel, this seems to be due to your recent changes in keyboard.c.
> > If I make the change below, which reverts a small part of your
> > changes, the problem is gone: [...]

> Yep. You're right. I'll bring us back to the old logic here.

Works for me, thanks.


Michael.