From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#27397: [PATCH] New commands for bulk tracing of elisp functions Date: Sat, 17 Jun 2017 20:48:46 +1200 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1497689495 28414 195.159.176.226 (17 Jun 2017 08:51:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Jun 2017 08:51:35 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 To: Kaushal Modi , 27397@debbugs.gnu.org, Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 17 10:51:29 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dM9S4-0006zG-Fw for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 10:51:28 +0200 Original-Received: from localhost ([::1]:33851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dM9S9-00071S-RY for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 04:51:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dM9Qj-0006Mn-RL for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 04:50:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dM9Qg-0001MV-Pl for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 04:50:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dM9Qg-0001M6-LC for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 04:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dM9Qg-0002lD-Cg for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 04:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2017 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27397-submit@debbugs.gnu.org id=B27397.149768934810549 (code B ref 27397); Sat, 17 Jun 2017 08:50:02 +0000 Original-Received: (at 27397) by debbugs.gnu.org; 17 Jun 2017 08:49:08 +0000 Original-Received: from localhost ([127.0.0.1]:52079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dM9Po-0002k5-GX for submit@debbugs.gnu.org; Sat, 17 Jun 2017 04:49:08 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:48518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dM9Pm-0002jY-Hd for 27397@debbugs.gnu.org; Sat, 17 Jun 2017 04:49:07 -0400 Original-Received: from [150.107.172.84] (port=44275 helo=[192.168.20.102]) by smtp-3.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1dM9PT-00026X-CN; Sat, 17 Jun 2017 20:48:57 +1200 In-Reply-To: Content-Language: en-US X-GeoIP: NZ X-Spam_score: -1.0 X-Spam_score_int: -9 X-Spam_bar: - X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133687 Archived-At: > On 6/16/17 4:32 PM, Phil Sainty wrote: >> (I note that the `trace-is-traced' function does not follow the usual >> naming convention for predicates. Should this be renamed to >> `trace-is-traced-p' ?) On 17/06/17 02:58, Dmitry Gutov wrote: > I'm not 100% sure about the protocol here, but including both "-is-" > and "-p" in a function name seems too much. > > So maybe you should do the opposite and rename trace-is-traceable-p to > trace-is-traceable. On 17/06/17 03:43, Kaushal Modi wrote: > Based on current examples[1], it is more common to see predicate > *functions* end in "-p". So the "-is-" portion is maybe redundant. > > My suggestion would be something like "trace-traced-p" or > "trace-fn-traced-p". > > [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?att=0;bug=26564;msg=5 FWIW, after loading more or less all the lisp in trunk, apropos tells me: 2381 matches for ".*-p$" 126 matches for "-is-" 28 matches for "-is-.*-p$" The -p suffix is certainly what I'm used to seeing, but -is- is entirely readable to my mind, so I'm happy either way. Consistency is good, so some kind of change seemed sensible to me, but I don't especially mind one way or the other. If one of the maintainers wants to make a recommendation, I'll update the code (or leave it as-is) accordingly. -Phil