From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#17193: 24.4.50; `menu-bar-make-toggle': allow :keys Date: Sat, 5 Apr 2014 08:58:22 -0700 (PDT) Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1396713571 26131 80.91.229.3 (5 Apr 2014 15:59:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Apr 2014 15:59:31 +0000 (UTC) To: 17193@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 05 17:59:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WWT07-0008Ot-IX for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Apr 2014 17:59:23 +0200 Original-Received: from localhost ([::1]:55084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWT07-0003qx-3I for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Apr 2014 11:59:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWSzv-0003qs-FZ for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 11:59:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWSzm-0000fW-Oi for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 11:59:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWSzm-0000fS-La for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 11:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WWSzm-0006mm-1h for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 11:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Apr 2014 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17193 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17193-submit@debbugs.gnu.org id=B17193.139671350525974 (code B ref 17193); Sat, 05 Apr 2014 15:59:01 +0000 Original-Received: (at 17193) by debbugs.gnu.org; 5 Apr 2014 15:58:25 +0000 Original-Received: from localhost ([127.0.0.1]:36995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWSzB-0006kr-0Y for submit@debbugs.gnu.org; Sat, 05 Apr 2014 11:58:25 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:45213) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWSz9-0006kj-4b for 17193@debbugs.gnu.org; Sat, 05 Apr 2014 11:58:23 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s35FwKuR021718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <17193@debbugs.gnu.org>; Sat, 5 Apr 2014 15:58:21 GMT Original-Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s35FwK17026610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <17193@debbugs.gnu.org>; Sat, 5 Apr 2014 15:58:20 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s35FwKoi023673 for <17193@debbugs.gnu.org>; Sat, 5 Apr 2014 15:58:20 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87774 Archived-At: > I should have made clear in the Subject line, as well as in the > message body, that the request is not just about :keys but includes > support for (i.e., taking account of) :enable, :visible, and so on. >=20 > IOW, the macro should allow `menu-item' features such as these > keywords to be passed on to `menu-item', so that they take effect. This is apparently already what `menu-bar-make-mm-toggle' does, for example. [But the doc string for `menu-bar-make-mm-toggle' is not very clear about this. It simply calls this PROPS, saying "PROPS are additional properties." It really should make clear what is involved: these are things passed to `menu-item'. "Properties" by itself means nothing in the context of that doc string. Something really needs to point to `menu-item', which is fully documented.]