From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Tue, 03 Jan 2023 14:56:49 +0000 Message-ID: References: <87o7ri74qv.fsf@localhost> <9bc9c69ac20a37ded741@heytings.org> <9bc9c69ac282c0148962@heytings.org> <87h6x9mgdv.fsf@localhost> <838rij23by.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="fo8oe4g5dC" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org, yantar92@posteo.net, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 03 15:57:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCijA-0001qv-O5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Jan 2023 15:57:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCiiu-0000vV-6j; Tue, 03 Jan 2023 09:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCiis-0000vL-SU for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 09:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCiis-0004w5-Kf for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 09:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCiis-0008Eu-DJ for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 09:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Jan 2023 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.167275781431657 (code B ref 60467); Tue, 03 Jan 2023 14:57:02 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 3 Jan 2023 14:56:54 +0000 Original-Received: from localhost ([127.0.0.1]:46461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCiij-0008EX-Lw for submit@debbugs.gnu.org; Tue, 03 Jan 2023 09:56:54 -0500 Original-Received: from heytings.org ([95.142.160.155]:57224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCiih-0008ER-Vl for 60467@debbugs.gnu.org; Tue, 03 Jan 2023 09:56:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672757810; bh=cDfx0gSM/WZw/RVwPnCNCFR4s+ql2CtdGbPaEU+KdPE=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Qr9hyKhm8nLHJL/RBZ32WxNesMtZnv/PHuX64LYq9MU4HyhFVha2FzARZ1KHR0ADF P9VgKC0Ao4X1qIf3PFmyxf0K5bP6DedA12aoN2oug00ABnDB5La4T5K5teQdZr3bU3 Pigl2mGxHUXHsfar77ZY1Ca0BVUpcw3FWvHoLOOhHyrhMeNZHAPvFWUjGKmZyn8nfa 3vgbmjoGAecPNcKM3DrurOge6iBDseOrBIq0z5NKlYwUmIK+kRkwkebQxiQCaPkCN5 sNHP4DJeoRXmokH6cuxCce2fBLmT99NxvuaMNWQRxoMo01ZJK+MbELJcvlXfbmjqMs gQZLpBc/AEwGw== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252410 Archived-At: --fo8oe4g5dC Content-Type: text/plain; charset=us-ascii; format=flowed >> If so, how about adding a test for this bug? > > I'll see if I can do that, but it seems tricky. > Here you go. Without the patch tests 2 and 3 fail, with the patch all three tests pass. --fo8oe4g5dC Content-Type: text/x-diff; name=Three-new-tests-for-undo-with-combine-change-calls.patch Content-Transfer-Encoding: base64 Content-ID: Content-Disposition: attachment; filename=Three-new-tests-for-undo-with-combine-change-calls.patch RnJvbSAzMzNhMWI0NmFhMWE0MzBmYjhjYjdhODQ4OTQ2YjBhNWVhMmEwZWRl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUdWUsIDMgSmFu IDIwMjMgMTQ6NTQ6MDkgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gVGhyZWUg bmV3IHRlc3RzIGZvciAndW5kbycgd2l0aCAnY29tYmluZS1jaGFuZ2UtY2Fs bHMnDQoNCiogdGVzdC9zcmMvdW5kby10ZXN0cy5lbCAodW5kby10ZXN0LWNv bWJpbmUtY2hhbmdlLWNhbGxzLTEpDQoodW5kby10ZXN0LWNvbWJpbmUtY2hh bmdlLWNhbGxzLTIpDQoodW5kby10ZXN0LWNvbWJpbmUtY2hhbmdlLWNhbGxz LTMpOiBBZGQgdGhyZWUgdGVzdHMgZm9yICd1bmRvJw0Kd2l0aCAnY29tYmlu ZS1jaGFuZ2UtY2FsbHMnLiAgU2VlIGJ1ZyM2MDQ2Ny4NCi0tLQ0KIHRlc3Qv c3JjL3VuZG8tdGVzdHMuZWwgfCA3MiArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysNCiAxIGZpbGUgY2hhbmdlZCwgNzIgaW5z ZXJ0aW9ucygrKQ0KDQpkaWZmIC0tZ2l0IGEvdGVzdC9zcmMvdW5kby10ZXN0 cy5lbCBiL3Rlc3Qvc3JjL3VuZG8tdGVzdHMuZWwNCmluZGV4IDg0MTUxZDNi NWQuLmZkNDVhOTEwMWYgMTAwNjQ0DQotLS0gYS90ZXN0L3NyYy91bmRvLXRl c3RzLmVsDQorKysgYi90ZXN0L3NyYy91bmRvLXRlc3RzLmVsDQpAQCAtNDM5 LDYgKzQzOSw3OCBAQCB1bmRvLXRlc3QtcmVnaW9uLW1hcmstYWRqdXN0bWVu dA0KIA0KICAgICAoc2hvdWxkIChzdHJpbmc9IChidWZmZXItc3RyaW5nKSAi YWFhRmlyc3QgbGluZVxuU2Vjb25kIGxpbmVcbmJiYiIpKSkpDQogDQorKGVy dC1kZWZ0ZXN0IHVuZG8tdGVzdC1jb21iaW5lLWNoYW5nZS1jYWxscy0xICgp DQorICAiVGVzdCBob3cgYGNvbWJpbmUtY2hhbmdlLWNhbGxzJyB1cGRhdGVz IGBidWZmZXItdW5kby1saXN0Jy4NCitDYXNlIDE6IGEgZmlsZS12aXNpdGlu ZyBidWZmZXIgd2l0aCBgYnVmZmVyLXVuZG8tbGlzdCcgbm9uLW5pbA0KK2Fu ZCBgYnVmZmVyLW1vZGlmaWVkLXAnIG5vbi1uaWwgd2hlbiBgY29tYmluZS1j aGFuZ2UtY2FsbHMnIGlzDQorY2FsbGVkLiINCisgIChlcnQtd2l0aC10ZW1w LWZpbGUgdGVtcGZpbGUNCisgICAgKHdpdGgtY3VycmVudC1idWZmZXIgKGZp bmQtZmlsZSB0ZW1wZmlsZSkNCisgICAgICAoaW5zZXJ0ICJBIikNCisgICAg ICAodW5kby1ib3VuZGFyeSkNCisgICAgICAoaW5zZXJ0ICJCIikNCisgICAg ICAodW5kby1ib3VuZGFyeSkNCisgICAgICAoaW5zZXJ0ICJDIikNCisgICAg ICAodW5kby1ib3VuZGFyeSkNCisgICAgICAoaW5zZXJ0ICIgIikNCisgICAg ICAodW5kby1ib3VuZGFyeSkNCisgICAgICAoaW5zZXJ0ICJEIikNCisgICAg ICAodW5kby1ib3VuZGFyeSkNCisgICAgICAoaW5zZXJ0ICJFIikNCisgICAg ICAodW5kby1ib3VuZGFyeSkNCisgICAgICAoaW5zZXJ0ICJGIikNCisgICAg ICAoc2hvdWxkICg9IChsZW5ndGggYnVmZmVyLXVuZG8tbGlzdCkgMTQpKQ0K KyAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpDQorICAgICAgKGNvbWJp bmUtY2hhbmdlLWNhbGxzIChwb2ludC1taW4pIChwb2ludC1tYXgpDQorICAg ICAgICAocmUtc2VhcmNoLWZvcndhcmQgIkFCQyAiKQ0KKyAgICAgICAgKHJl cGxhY2UtbWF0Y2ggIlogIikpDQorICAgICAgKHNob3VsZCAoPSAobGVuZ3Ro IGJ1ZmZlci11bmRvLWxpc3QpIDE1KSkpKSkNCisNCisoZXJ0LWRlZnRlc3Qg dW5kby10ZXN0LWNvbWJpbmUtY2hhbmdlLWNhbGxzLTIgKCkNCisgICJUZXN0 IGhvdyBgY29tYmluZS1jaGFuZ2UtY2FsbHMnIHVwZGF0ZXMgYGJ1ZmZlci11 bmRvLWxpc3QnLg0KK0Nhc2UgMjogYSBmaWxlLXZpc2l0aW5nIGJ1ZmZlciB3 aXRoIGBidWZmZXItdW5kby1saXN0JyBub24tbmlsDQorYW5kIGBidWZmZXIt bW9kaWZpZWQtcCcgbmlsIHdoZW4gYGNvbWJpbmUtY2hhbmdlLWNhbGxzJyBp cw0KK2NhbGxlZC4iDQorICAoZXJ0LXdpdGgtdGVtcC1maWxlIHRlbXBmaWxl DQorICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIChmaW5kLWZpbGUgdGVtcGZp bGUpDQorICAgICAgKGluc2VydCAiQSIpDQorICAgICAgKHVuZG8tYm91bmRh cnkpDQorICAgICAgKGluc2VydCAiQiIpDQorICAgICAgKHVuZG8tYm91bmRh cnkpDQorICAgICAgKGluc2VydCAiQyIpDQorICAgICAgKHVuZG8tYm91bmRh cnkpDQorICAgICAgKGluc2VydCAiICIpDQorICAgICAgKHVuZG8tYm91bmRh cnkpDQorICAgICAgKGluc2VydCAiRCIpDQorICAgICAgKHVuZG8tYm91bmRh cnkpDQorICAgICAgKGluc2VydCAiRSIpDQorICAgICAgKHVuZG8tYm91bmRh cnkpDQorICAgICAgKGluc2VydCAiRiIpDQorICAgICAgKHNob3VsZCAoPSAo bGVuZ3RoIGJ1ZmZlci11bmRvLWxpc3QpIDE0KSkNCisgICAgICAoc2F2ZS1i dWZmZXIpDQorICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkNCisgICAg ICAoY29tYmluZS1jaGFuZ2UtY2FsbHMgKHBvaW50LW1pbikgKHBvaW50LW1h eCkNCisgICAgICAgIChyZS1zZWFyY2gtZm9yd2FyZCAiQUJDICIpDQorICAg ICAgICAocmVwbGFjZS1tYXRjaCAiWiAiKSkNCisgICAgICAoc2hvdWxkICg9 IChsZW5ndGggYnVmZmVyLXVuZG8tbGlzdCkgMTUpKSkpKQ0KKw0KKyhlcnQt ZGVmdGVzdCB1bmRvLXRlc3QtY29tYmluZS1jaGFuZ2UtY2FsbHMtMyAoKQ0K KyAgIlRlc3QgaG93IGBjb21iaW5lLWNoYW5nZS1jYWxscycgdXBkYXRlcyBg YnVmZmVyLXVuZG8tbGlzdCcuDQorQ2FzZSAzOiBhIGZpbGUtdmlzaXRpbmcg YnVmZmVyIHdpdGggYGJ1ZmZlci11bmRvLWxpc3QnIG5pbCBhbmQNCitgYnVm ZmVyLW1vZGlmaWVkLXAnIG5pbCB3aGVuIGBjb21iaW5lLWNoYW5nZS1jYWxs cycgaXMgY2FsbGVkLiINCisgIChlcnQtd2l0aC10ZW1wLWZpbGUgdGVtcGZp bGUNCisgICAgKHdpdGgtY3VycmVudC1idWZmZXIgKGZpbmQtZmlsZSB0ZW1w ZmlsZSkNCisgICAgICAoaW5zZXJ0ICJBQkMgREVGIikNCisgICAgICAoc2F2 ZS1idWZmZXIpDQorICAgICAgKGtpbGwtYnVmZmVyKSkNCisgICAgKHdpdGgt Y3VycmVudC1idWZmZXIgKGZpbmQtZmlsZSB0ZW1wZmlsZSkNCisgICAgICAo c2hvdWxkICg9IChsZW5ndGggYnVmZmVyLXVuZG8tbGlzdCkgMCkpDQorICAg ICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkNCisgICAgICAoY29tYmluZS1j aGFuZ2UtY2FsbHMgKHBvaW50LW1pbikgKHBvaW50LW1heCkNCisgICAgICAg IChyZS1zZWFyY2gtZm9yd2FyZCAiQUJDICIpDQorICAgICAgICAocmVwbGFj ZS1tYXRjaCAiWiAiKSkNCisgICAgICAoc2hvdWxkICg9IChsZW5ndGggYnVm ZmVyLXVuZG8tbGlzdCkgMSkpKSkpDQorDQogKGRlZnVuIHVuZG8tdGVzdC1h bGwgKCZvcHRpb25hbCBpbnRlcmFjdGl2ZSkNCiAgICJSdW4gYWxsIHRlc3Rz IGZvciBcXFt1bmRvXS4iDQogICAoaW50ZXJhY3RpdmUgInAiKQ0KLS0gDQoy LjM5LjANCg0K --fo8oe4g5dC--