unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: npostavs@gmail.com, 31996@debbugs.gnu.org
Subject: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree
Date: Fri, 29 Jun 2018 00:30:33 -0700	[thread overview]
Message-ID: <ecb31892-de86-8cc0-e000-fd1262b8bee4@cs.ucla.edu> (raw)
In-Reply-To: <83sh56nmqt.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

Eli Zaretskii wrote:
>   maybe a comment explaining why the order might matter in general
> could be of more value, and require less maintenance.

I gave that a shot by installing the attached.

[-- Attachment #2: 0001-src-lisp.h-Add-comment-Bug-31996-25.patch --]
[-- Type: text/x-patch, Size: 656 bytes --]

From 9ffc9ec7a70c2e971b616146cb49b084981b74a9 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 29 Jun 2018 00:29:13 -0700
Subject: [PATCH] * src/lisp.h: Add comment (Bug#31996#25).

---
 src/lisp.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lisp.h b/src/lisp.h
index cf7b8c0..6203a74 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -3050,6 +3050,8 @@ enum specbind_tag {
 
 union specbinding
   {
+    /* Aligning similar members consistently might help efficiency slightly
+       (Bug#31996#25).  */
     ENUM_BF (specbind_tag) kind : CHAR_BIT;
     struct {
       ENUM_BF (specbind_tag) kind : CHAR_BIT;
-- 
2.7.4


  reply	other threads:[~2018-06-29  7:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 19:10 bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree Noam Postavsky
2018-06-28 19:18 ` Eli Zaretskii
2018-06-28 19:20   ` Noam Postavsky
2018-06-28 20:29     ` Andy Moreton
2018-06-28 20:55 ` Paul Eggert
2018-06-28 21:05   ` Noam Postavsky
2018-06-28 22:57     ` Paul Eggert
2018-06-29  6:13       ` Eli Zaretskii
2018-06-29  7:30         ` Paul Eggert [this message]
2018-06-29  8:52           ` Eli Zaretskii
2018-06-29 12:30       ` Noam Postavsky
2018-06-29 18:18         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecb31892-de86-8cc0-e000-fd1262b8bee4@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=31996@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).