From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Date: Mon, 12 Dec 2022 22:21:03 +0000 Message-ID: References: <83iliiv0yv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="uRCW0xUpGb" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2351"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , arstoffel@gmail.com, Stefan Monnier , 59956@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 23:22:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4rBy-0000Kv-1f for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 23:22:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4rBV-00043P-Ed; Mon, 12 Dec 2022 17:22:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rBS-00042t-8z for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4rBS-0000yw-0d for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4rBR-0004wt-TK for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 22:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59956 X-GNU-PR-Package: emacs Original-Received: via spool by 59956-submit@debbugs.gnu.org id=B59956.167088366919002 (code B ref 59956); Mon, 12 Dec 2022 22:22:01 +0000 Original-Received: (at 59956) by debbugs.gnu.org; 12 Dec 2022 22:21:09 +0000 Original-Received: from localhost ([127.0.0.1]:55768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rAb-0004wP-70 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:21:09 -0500 Original-Received: from heytings.org ([95.142.160.155]:55460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rAY-0004wJ-Je for 59956@debbugs.gnu.org; Mon, 12 Dec 2022 17:21:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1670883664; bh=vYJ8BlNI4URvEB+rk4+MyLwH8A9kkXvPPNy4TuWmASM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=B70f7zaOrXJWtMXtJVI+4YDNGF/qYtrEGIS5qXgummsyQ6+ib4zEfGmyJwWT2APVu 55MB/w7Vzt1G4zKe6esh0tUtV0OEGO2x+57G5QQQvYqUp7xbIunHlpFn+iaPrI2eMP fnp/VC+abSx5JM03pmNHLPbkSpvK2SSxY7rzw+8CPs9hObCRIqMFX1sI0lgdHaeFZ4 yeqvwCTQgZZ5FuEapEspJb0P5NCY0MIJdsCB+qlYI7AuGjg2IQIl38JLg0FGXAPtBz A76AVDHVuF07q3ODUs4Czv0yepdZEDQHQxl0XuLu5xFuvUpvNRdyV7R1P4k3JGv86K MRJRP/2uU9XsQ== In-Reply-To: <83iliiv0yv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250759 Archived-At: --uRCW0xUpGb Content-Type: text/plain; format=flowed; charset=us-ascii >> Starting from "emacs -Q -f -eshell", type "echo $exec-path " (note the >> trailing space), and then hit TAB. The result is this error: >> >> pcomplete-match: Wrong type argument: stringp, ("/usr/bin" ...) >> >> This is a regression from Emacs 28, and it looks like it's due to >> 'pcomplete-here-using-help' assuming that all the pcomplete args are >> strings. However, 'exec-path' is a list (and Eshell reports it this way >> to pcomplete), so the completion fails. I think all that's necessary is >> checking that the pcomplete args are strings in >> 'pcomplete-here-using-help', but I know next to nothing about >> pcomplete... > > Adding Stefan, who should know more about pcomplete. > > Stefan, any suggestions? > I'm still not Stefan, but this bug is fixed by the attached patch. --uRCW0xUpGb Content-Type: text/x-diff; name=Check-that-arguments-are-strings-in-pcomplete-here-u.patch Content-Transfer-Encoding: base64 Content-ID: Content-Disposition: attachment; filename=Check-that-arguments-are-strings-in-pcomplete-here-u.patch RnJvbSA2MDQxNmQzOWNkYTNlYmYzMzZiZGI3NzQ4N2QzYjdkOGQ0MjlmMWI2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBNb24sIDEyIERl YyAyMDIyIDIyOjE2OjE4ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIENoZWNr IHRoYXQgYXJndW1lbnRzIGFyZSBzdHJpbmdzIGluIHBjb21wbGV0ZS1oZXJl LXVzaW5nLWhlbHANCg0KKiBsaXNwL3Bjb21wbGV0ZS5lbCAocGNvbXBsZXRl LWhlcmUtdXNpbmctaGVscCk6IENoZWNrIHRoYXQNCnBjb21wbGV0ZS1hcmdz IGFyZSBzdHJpbmdzIGJlZm9yZSBhcHBseWluZyBzdHJpbmcgb3BlcmF0aW9u cyBvbg0KdGhlbS4gIEZpeGVzIGJ1ZyM1OTk1NiBhbmQgYnVnIzYwMDIxLg0K LS0tDQogbGlzcC9wY29tcGxldGUuZWwgfCAxMiArKysrKysrKystLS0NCiAx IGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQ0KDQpkaWZmIC0tZ2l0IGEvbGlzcC9wY29tcGxldGUuZWwgYi9saXNwL3Bj b21wbGV0ZS5lbA0KaW5kZXggNGUzYTg4YmJkYTguLmM2M2M0OTBiY2FhIDEw MDY0NA0KLS0tIGEvbGlzcC9wY29tcGxldGUuZWwNCisrKyBiL2xpc3AvcGNv bXBsZXRlLmVsDQpAQCAtMTQ0OSwxMiArMTQ0OSwxOCBAQCBwY29tcGxldGUt aGVyZS11c2luZy1oZWxwDQogVGhlIHN3aXRjaGVzIGFyZSBvYnRhaW5lZCBi eSBjYWxsaW5nIGBwY29tcGxldGUtZnJvbS1oZWxwJyB3aXRoDQogQ09NTUFO RCBhbmQgQVJHUyBhcyBhcmd1bWVudHMuIg0KICAgKHdoaWxlIChjb25kDQot ICAgICAgICAgICgoc3RyaW5nPSAiLS0iIChwY29tcGxldGUtYXJnIDEpKQ0K KyAgICAgICAgICAoKGxldCAoKGFyZyAocGNvbXBsZXRlLWFyZyAxKSkpDQor ICAgICAgICAgICAgIChpZiAoc3RyaW5ncCBhcmcpDQorICAgICAgICAgICAg ICAgICAoc3RyaW5nPSAiLS0iIGFyZykpKQ0KICAgICAgICAgICAgKHdoaWxl IChwY29tcGxldGUtaGVyZSAocGNvbXBsZXRlLWVudHJpZXMpKSkpDQotICAg ICAgICAgICgocGNvbXBsZXRlLW1hdGNoICJcXGAtLVtePV0rPVxcKC4qXFwp IiAwKQ0KKyAgICAgICAgICAoKGxldCAoKGFyZyAocGNvbXBsZXRlLWFyZyAw KSkpDQorICAgICAgICAgICAgIChpZiAoc3RyaW5ncCBhcmcpDQorICAgICAg ICAgICAgICAgICAocGNvbXBsZXRlLW1hdGNoICJcXGAtLVtePV0rPVxcKC4q XFwpIiAwKSkpDQogICAgICAgICAgICAocGNvbXBsZXRlLWhlcmUgKHBjb21w bGV0ZS1lbnRyaWVzKQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAgIChw Y29tcGxldGUtbWF0Y2gtc3RyaW5nIDEgMCkpKQ0KLSAgICAgICAgICAoKHN0 cmluZy1wcmVmaXgtcCAiLSIgKHBjb21wbGV0ZS1hcmcgMCkpDQorICAgICAg ICAgICgobGV0ICgoYXJnIChwY29tcGxldGUtYXJnIDApKSkNCisgICAgICAg ICAgICAgKGlmIChzdHJpbmdwIGFyZykNCisgICAgICAgICAgICAgICAgIChz dHJpbmctcHJlZml4LXAgIi0iIGFyZykpKQ0KICAgICAgICAgICAgKHBjb21w bGV0ZS1oZXJlIChhcHBseSAjJ3Bjb21wbGV0ZS1mcm9tLWhlbHAgY29tbWFu ZCBhcmdzKSkpDQogICAgICAgICAgICh0IChwY29tcGxldGUtaGVyZSogKHBj b21wbGV0ZS1lbnRyaWVzKSkpKSkpDQogDQotLSANCjIuMzUuMQ0KDQo= --uRCW0xUpGb--