From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#48738: [PATCH] Optimized `describe-variable' predicate Date: Mon, 31 May 2021 07:00:06 +0200 Message-ID: References: <55a7f6fc-ccad-a8e3-2f51-1cbc1555a4f8@daniel-mendler.de> <87h7ijmrie.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20269"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48738@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 31 07:01:49 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lna3g-000588-Vr for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 07:01:48 +0200 Original-Received: from localhost ([::1]:50058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lna3f-0006qY-Ky for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 01:01:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lna2w-0006pe-J8 for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lna2w-0006My-B2 for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lna2w-0003fs-9w for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 May 2021 05:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48738 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48738-submit@debbugs.gnu.org id=B48738.162243721911575 (code B ref 48738); Mon, 31 May 2021 05:01:02 +0000 Original-Received: (at 48738) by debbugs.gnu.org; 31 May 2021 05:00:19 +0000 Original-Received: from localhost ([127.0.0.1]:60723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lna2E-00030K-Ki for submit@debbugs.gnu.org; Mon, 31 May 2021 01:00:18 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:60543 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lna2A-0002oq-Mm for 48738@debbugs.gnu.org; Mon, 31 May 2021 01:00:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=54Zu+QoVFFMGUXxUyn1WpwXIrtdjoZFq5Kq3r01zF+U=; b=gj0BLglJK8SRBblrnXDo3VVMuN J7eCu6mxta1KekZtR0VAyXzs4RejShpTgArls2sUVd/ZwqAnaiENIz3zDnzmi18et1bwXR4c5se50 meJAxo+cnt+qlOsm7/0VJCEhgZybl/Cobj/vKpEZBKjYKH6uU+YEGNr+tZYUxE+3yGWk=; In-Reply-To: <87h7ijmrie.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207654 Archived-At: On 5/31/21 6:55 AM, Lars Ingebrigtsen wrote: > Thanks; applied to Emacs 28 with some changes -- I thought the > `ignore-errors' logic was kinda unclear, so I rewrote that bit using an > explicit `condition-case' checking for the error thrown in this case. Makes sense. Thanks for applying the patch. > Adjusted patch included below; hopefully I didn't introduce any errors > here... > >> Ideally there would be a `buffer-local-boundp` predicate we could use >> here. > > Yes, that would be nice, I think. > > And we probably have a lot of code in Emacs that uses > `with-current-buffer' instead of `buffer-local-value' that could be > similarly optimised (but I guess it mostly only makes sense to do so > when it's called in an intensive loop like here). Yes, when I find such case I will report them or provide a patch. However it really matters in very few cases. Here the predicate is called 10k+ times when generating all completions.