unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 15292@debbugs.gnu.org
Subject: bug#15292: 24.3.50; Isearch: handle commands properly when called at top level
Date: Fri, 6 Sep 2013 11:56:45 -0700 (PDT)	[thread overview]
Message-ID: <ebe0fe71-f6fb-4cac-9dd4-2b649848281e@default> (raw)

Isearch now has quite a few commands that can be invoked during Isearch,
using keys.  None of these commands currently take care of the fact that
they might get called at top level, e.g., with `isearch-mode' = nil.

Some such commands, such as `isearch-help-for-help' should be callable
outside of Isearch.  Others, such as `isearch-repeat-forward', should
not.  For those that should not, an error should be raised, saying that
the command is for use only in Isearch.

For those that should be allowable outside of Isearch, the code should
take care to DTRT when not in `isearch-mode':

* wrt messages (mostly inhibit messages, esp. if they use
  `isearch-message-prefix' etc.)

* wrt Isearch highlighting (they should not do any highlighting)

* wrt calling `isearch-update' etc. (they should not do it)

* wrt calling `exit-minibuffer' (they should not do it: no catch for
  throw)

Some commands, such as `isearch-describe-bindings' and
`isearch-highlight-regexp' can be used outside of Isearch with no change
- they work well already.  This includes even `isearch-edit-string',
which can be called outside Isearch but which then continues in Isearch
with no problem.

Among the comands that might be useful, or at least allowable, outside
of Isearch (dunno), but that might need some minor fixup are the
following.  They should not call `isearch-update' etc.

* isearch-help-for-help

* isearch-describe-key (should explicitly use `isearch-mode-map')

* isearch-describe-mode

* isearch-toggle-*

Dunno whether there is any use for these commands outside Isearch:

* isearch-cancel (moves point to last Isearch start)

* isearch-abort


In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-08-23 on ODIEONE
Bzr revision: 113986 rgm@gnu.org-20130823185841-zoy6h1qk433ibrlf
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3' LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'





             reply	other threads:[~2013-09-06 18:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 18:56 Drew Adams [this message]
2013-09-06 20:49 ` bug#15292: 24.3.50; Isearch: handle commands properly when called at top level Juri Linkov
2013-09-06 21:04   ` Drew Adams
2013-09-06 22:55 ` Stefan Monnier
2013-09-06 23:19   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebe0fe71-f6fb-4cac-9dd4-2b649848281e@default \
    --to=drew.adams@oracle.com \
    --cc=15292@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).