From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#49518: 28.0.50; electric-pair-mode skip-self fails for single-quotes in python-mode Date: Sat, 18 Sep 2021 18:55:06 -0700 Message-ID: References: <877dhxp8wn.fsf@gmx.net> <58515d93-dbca-4cd1-e820-ad9d5bb6d462@gmail.com> <87zgs9bgaz.fsf@gmail.com> <87v92xbelt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1867"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49518@debbugs.gnu.org, Stephen Berman , Daniel Fleischer To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 19 03:56:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRm4D-0000Jt-QN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 03:56:29 +0200 Original-Received: from localhost ([::1]:59028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRm4B-0002TT-OP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 21:56:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRm3m-0002TJ-I6 for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 21:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRm3m-000404-B0 for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 21:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRm3m-0004AL-6K for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 21:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 01:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49518 X-GNU-PR-Package: emacs Original-Received: via spool by 49518-submit@debbugs.gnu.org id=B49518.163201651815960 (code B ref 49518); Sun, 19 Sep 2021 01:56:02 +0000 Original-Received: (at 49518) by debbugs.gnu.org; 19 Sep 2021 01:55:18 +0000 Original-Received: from localhost ([127.0.0.1]:37224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRm34-00049L-CS for submit@debbugs.gnu.org; Sat, 18 Sep 2021 21:55:18 -0400 Original-Received: from mail-pj1-f42.google.com ([209.85.216.42]:52062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRm2z-000492-Uh for 49518@debbugs.gnu.org; Sat, 18 Sep 2021 21:55:15 -0400 Original-Received: by mail-pj1-f42.google.com with SMTP id dw14so9560447pjb.1 for <49518@debbugs.gnu.org>; Sat, 18 Sep 2021 18:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=TZ+sGS66rkwEt+RHZOg9znH02Ue5jIseCeqJjQf1h28=; b=bMHD3iTjU4oeHtreo+Uw3mpTjq1My0DQq5Qjg6J5gZGFS8eRm+ABfxGVFmlmhZpJX+ 2a7gIQnFQMoLr8x1O1Vn4Ct5oyoGXzho/GJpbYYbo9NOTHU7XE7kMR4h/SN9oioWSQ+b yCBNjJXx7flXITrkIoWf6YndwdRg6Wm99QAhKSggTfaufnbzjrbvYCZ8RkBHisRFMNrD jqgrIkGSysilMRTjSY+qnHTbJhGrKMvPeukX9VFpRV5zKcln2F59ED2olDXMzqkHmg80 4Cn+NW6yZwEvQmd/g8lKskA1z9huf9mxvHp/13fZ3J1ktat+UCss/K5paWE3LU7RtJHn nq8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TZ+sGS66rkwEt+RHZOg9znH02Ue5jIseCeqJjQf1h28=; b=EH0OZWAUEE2z2JvWZx1C6ebEyEzgM9H79b/WBCf2gLp6qTMYd8uQ/167cMjykk4kaZ MA0QAgSPhx2g7ROmGtIhMNztLqm9ceS03+UgZtP/EtvylLjvXIKcj/rm8C2fl63EX0rN RQzU03aS1bw0HXP4ER3f30DaZnnEdVUy9K5qmxXVI1QjJQCbT75WcLcbbfZ7PkbDoBoZ 21ywHgtybXRoYG9KZdSxnDMZy2RNehuj/7m525hKQ9J4EOi1oJkepP1NxXMKkVRurGYg J+mCYWT5X+hOtk/UIikbwqYwDj8xlr1SR/E/FPW1clpgJXFyZd1GAvVnHnFpFX2wYegO viWA== X-Gm-Message-State: AOAM531sDxsWKCIQFKsj4YLPvmRJJV4z8Hq39AaJVtaQwtXFh4Xx8yr6 e1vnc0kEpiTpn0o38bk8yw8= X-Google-Smtp-Source: ABdhPJwyyjDZZOwo52OWIlcGZ2hHhpJ5FWnapREUhdS+qotmCnKvVUUA9aQ078ciev4exgQM/mySxw== X-Received: by 2002:a17:90b:4f8a:: with SMTP id qe10mr19543556pjb.5.1632016508144; Sat, 18 Sep 2021 18:55:08 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d18sm11207678pgk.24.2021.09.18.18.55.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Sep 2021 18:55:07 -0700 (PDT) In-Reply-To: <87v92xbelt.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214674 Archived-At: On 9/18/2021 5:20 PM, João Távora wrote: > So after having a look at this, I came up with a patch. All tests > pass, and your original request is granted. Unfortunately, Stephen's > desired triple-pair behaviour is also lost. However, I think that > behaviour can be recovered via other more elegant, less accidental ways. > python.el has 'python-electric-pair-string-delimiter' for triple-pairing > that doesn't seem to be doing its thing. > > Here is the patch. Give it a shot. > > diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el > index d8c377a2ef..b8b8a97651 100644 > --- a/lisp/elec-pair.el > +++ b/lisp/elec-pair.el > @@ -198,7 +198,9 @@ electric-pair-syntax-info > inside a comment or string." > (let* ((pre-string-or-comment (or (bobp) > (nth 8 (save-excursion > - (syntax-ppss (1- (point))))))) > + (skip-chars-backward > + (make-string 1 command-event)) > + (syntax-ppss (point)))))) > (post-string-or-comment (nth 8 (syntax-ppss (point)))) > (string-or-comment (and post-string-or-comment > pre-string-or-comment)) > Thanks, this patch works for me. It also works fine with my patch in bug#50538, so there's no conflict there. > Maybe better less brittle solutions can probably be found within the > syntax tables framework. I agree that something less brittle would be nice, but that might be tricky. I had tried a few options when I filed this bug, but nothing worked quite right. As for Stephen's desired behavior, the code snippet I posted above[1] mostly fixes it (just the `python-electric-pair-string-delimiter' part is necessary after your patch). However, that code doesn't work right if `electric-pair-skip-self' is set to nil, so I'd need to be a bit smarter with the implementation if I wanted to merge it into Emacs. Perhaps there's an even cleaner solution though. [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-09/msg01509.html