From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Date: Sat, 21 Oct 2023 07:18:31 -0300 Message-ID: References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3409"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: stefankangas@gmail.com, 66635@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 21 12:20:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qu95S-0000hL-4c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Oct 2023 12:20:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qu94y-0000ce-Ao; Sat, 21 Oct 2023 06:19:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu94x-0000cK-3c for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 06:19:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qu94w-0000yF-R3 for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 06:19:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qu95O-0000MQ-Go for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 06:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.16978835511286 (code B ref 66635); Sat, 21 Oct 2023 10:20:02 +0000 Original-Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 10:19:11 +0000 Original-Received: from localhost ([127.0.0.1]:42273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu94Z-0000Kg-Cj for submit@debbugs.gnu.org; Sat, 21 Oct 2023 06:19:11 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:49536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu94W-0000KP-UP for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 06:19:10 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1ca3a54d2c4so13653205ad.3 for <66635@debbugs.gnu.org>; Sat, 21 Oct 2023 03:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697883515; x=1698488315; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rGuloe/xFgi4JXSyicqNl22+ISzy36roXfMaHGb/Nvs=; b=Uo9TSyhb3iLgD2sYj12lnC29b8M7n5jNwL8iMf/GvUnCCzciy+QnSoN1N6DPiwPOSf baCPN2NK5rBR50w1pWnPcE9WV1i3f4vCsnTLV7Szj/kcXDUt+u2EgtRdVd0ZyceSlslN XeOb9tbeg5kikfJmybxc0TSZsLucfoY2IfJte0GC3J55B0lrzl5ELXtgFByMVjLXQUpG 1Vt35s5AGfLGuk7NDxrr4fNnieJTKMRQD9mXflUPAXeFQyW3xEqY22VyfHlxHcIguUCJ UoAm2/GEmeG78V5j+TSOfA0+OjcceccPv4cqmWpIyYi93Sw3OSvJ0d5gsegFd7Isje36 /Gsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697883515; x=1698488315; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rGuloe/xFgi4JXSyicqNl22+ISzy36roXfMaHGb/Nvs=; b=RpXGrmQbe4QxbxkvkiSstG2kqmGfR1VdztVB7hnHtVQaiNjKYMaDIt0D4YXOHO1Inu KZozqREuadqTBn67lWMa6Vq6jKNT5iPnSUtv7wyVWmGTpLYyrCQA8Uohvt3e0D2uI8a0 OudgCJeA1DHYnDlYwwcVTsBOcWku9bnVq2m5SD/A3tbxFsyLBL553PkVp4tBBCHYNT3O IPfHC4XHAuqOYnRl+t7dnj3kXzAXQlb76fwQfVv85E8ynLxSlr7ZQssX2iJkyn+pyTB2 UxNPpiC8VQ2MKWl8QHK3B2cYsXc/0pKNauIYybiTh4UJU4fX8W/QkTZlsZ9DbJwvrItJ o7OA== X-Gm-Message-State: AOJu0Yw/un6gEtVBCwDITi79JSB97G7H2crKXhcS9iNqVSB5yeTkIn+N hyvvwU41S/s6zBoppnNNId8= X-Google-Smtp-Source: AGHT+IEJfHmeGcndv9jOts35iTJTaHlcGN2Hiaq6/PzZITeNk7pL/uDR4U/atFvGgJFH2xVPz4Na+A== X-Received: by 2002:a17:903:18d:b0:1ca:87ea:2fcf with SMTP id z13-20020a170903018d00b001ca87ea2fcfmr5088080plg.25.1697883515081; Sat, 21 Oct 2023 03:18:35 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id h13-20020a170902680d00b001c0de73564dsm2951758plk.205.2023.10.21.03.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Oct 2023 03:18:34 -0700 (PDT) Content-Language: en-US In-Reply-To: <83cyx8sa1e.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272849 Archived-At: On 21/10/23 04:35, Eli Zaretskii wrote: >> Date: Fri, 20 Oct 2023 21:21:34 -0300 >> From: Mauro Aranda >> >> On 20/10/23 18:08, Stefan Kangas wrote: >>  > Mauro Aranda writes: >>  > >>  >> I attach a patch to address the more important issues for now.  That is, >>  >> at least have a working State button and rudimentary state checking. >>  >> >>  >> Setting and Saving icon specifications through the State button should >>  >> work now, by adding the custom-icon-action function. >>  > >>  > >>  > Thanks for working on this. >>  > >>  > Do you propose this patch for emacs-29?  It seems quite intrusive on the >>  > face of it, but OTOH `customize-icon' is new in Emacs 29, so there is no >>  > risk of regressions if this stuff never worked in the first place.  Or >>  > is that wrong? >> >> I'm not aware of all things you and Eli have to take into account when >> deciding whether a patch is good for emacs-29.  I know the non-intrusive >> or localized, and the safe part.  This patch is certainly neither, but >> it's the minimum (OK, maybe not the bare minimum) to make customizing >> icons work for an user.  I think that's a good reason for the patch to >> go into emacs-29, but I won't be insisting on it, specially if it is a >> burden, considering 29.1.90 pretest is out. > > icons.el is a new package in Emacs 29, so maybe such changes in it to > fix a serious problem are okay even at this stage. Great, thanks. > How well is the fix tested?  Did you test it with several icons > introduced in Emacs 29 in various modes?  If not, would you please > test those and see the changes work well enough there to be > appropriate for a bug-fix release? I just tested with the button icon, the only one suggested after running emacs -Q.  I tested making modifications in the buffer, and that the two options (three if not started with -Q) work and do what's intended.  Namely: - Undo Editions took me back to the STANDARD state. - Setting for the session modified the specs for the session and correctly displayed the SET state. - Saving the setting saved a spec that in a new session (without emacs -Q) causes: M-x describe-icon RET button to show the button customized.  The value I changed for that was from LARGE BLUE CIRCLE to LARGE RED SQUARE It's important to note that saving the setting shows the SET state (rather than the SAVED state), but that's in a FIXME right before custom-icon-state. I'll do some more testing with the icons defined in outline.el, tab-bar.el and warnings.el.  Additionally I'll try to test if Customizing an icon interacts good enough with a Theme customizations. I'll do that and report back.