From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18090: 24.4.50; `delete-selection-helper' logic changed for non-mouse region? Date: Tue, 3 Apr 2018 14:06:11 -0700 (PDT) Message-ID: References: <95e066b9-792c-4b38-8f4b-fd225578ed45@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1522789810 8470 195.159.176.226 (3 Apr 2018 21:10:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Apr 2018 21:10:10 +0000 (UTC) To: 18090@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 03 23:10:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3TBt-00024A-CT for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Apr 2018 23:10:05 +0200 Original-Received: from localhost ([::1]:36598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3TDy-0000Gv-QR for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Apr 2018 17:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3TDq-0000Fd-Db for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 17:12:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3TDm-0007pf-7E for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 17:12:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57728) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f3TDm-0007pa-2V for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 17:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f3TDl-000056-TP for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 17:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Apr 2018 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18090-submit@debbugs.gnu.org id=B18090.152278988332730 (code B ref 18090); Tue, 03 Apr 2018 21:12:01 +0000 Original-Received: (at 18090) by debbugs.gnu.org; 3 Apr 2018 21:11:23 +0000 Original-Received: from localhost ([127.0.0.1]:37391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3TD8-0008Vp-Tr for submit@debbugs.gnu.org; Tue, 03 Apr 2018 17:11:23 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:50806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3TD6-0008Vd-SY for 18090@debbugs.gnu.org; Tue, 03 Apr 2018 17:11:21 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w33L4vXG108941 for <18090@debbugs.gnu.org>; Tue, 3 Apr 2018 21:11:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=8majV3j7mQeQWBCYSRrAf1WQANSKCdo105BCv8TEGKQ=; b=Kbi+WjdWO412nfR9CCDKdKNMww+2b2U+A9+iBDwx82Lh40SRDjaX0PytoPFj+AXvb47g a/d/4kpue4pM4ZWDjk7MCFedyHAhbuMs+BJI/qdbOc1YC+ILrwq+yoITKFIUcUoXV3Rp isecwk0SceCiaHVO7aZQcwerPqwdCvT9IKC6eI8LxhzTvO7P+3CeKvJLsbV3W9gmvJzx BSiZA+xr+bqleR3IjXNSud/GzCUEYmBGnVzlbNHnpCQgJxduOojxhwkfGq1IYz2P487P YIpPjj/5OjoJOh7su7F3hv5HwJ7NMvyQXepucobXr79N21lnZfPKF7zlUPe3PTEvof9l Og== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2h4h78r0yy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <18090@debbugs.gnu.org>; Tue, 03 Apr 2018 21:11:15 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w33L6Dj6003680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <18090@debbugs.gnu.org>; Tue, 3 Apr 2018 21:06:14 GMT Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w33L6DgW008570 for <18090@debbugs.gnu.org>; Tue, 3 Apr 2018 21:06:13 GMT In-Reply-To: <95e066b9-792c-4b38-8f4b-fd225578ed45@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4666.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8852 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=13 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=992 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804030211 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144869 Archived-At: ping Could someone else please take a look at this? Thx. > Sent: Wednesday, July 23, 2014 11:03 AM > Prior to Emacs 23, the delsel.el code that handles a yank had this code: >=20 > ;; Before a yank command, make sure we don't yank the > ;; head of the kill-ring that really comes from the > ;; currently active region we are going to delete. > ;; That would make yank a no-op. > (when (and (string=3D (buffer-substring-no-properties (point) (mark)) > (car kill-ring))) > (current-kill 1)) >=20 > That code dates from the creation of delsel.el. In Emacs 23, these > two sexps were appended to the `and' conditions, which completely > changes the meaning/behavior (though the comment was not modified): >=20 > (fboundp 'mouse-region-match) > (mouse-region-match) >=20 > This changed the behavior so that the yanking point is now rotated only > when the mouse was used to set the region. This makes no sense to me, > but perhaps I am missing something. Does this make sense to you? > If it does make sense, then at least the comment should be updated to > reflect the current behavior. >=20 >=20 > --- >=20 > BTW, I also think it would be better to use `while' instead of `when' > in the code: >=20 > (let ((tail kill-ring)) > (while (and tail (string=3D (buffer-substring-no-properties (point) > (mark)) > (car tail)) > (fboundp 'mouse-region-match) ; ???? > (mouse-region-match)) ; ???? > (current-kill 1) > (setq tail (cdr tail)))) >=20 >=20 > In GNU Emacs 24.4.50.1 (i686-pc-mingw32) > of 2014-06-28 on ODIEONE > Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso > Windowing system distributor `Microsoft Corp.', version 6.1.7601 > Configured using: > `configure --prefix=3D/c/Devel/emacs/snapshot/trunk > --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' > LDFLAGS=3D-Lc:/Devel/emacs/lib 'CPPFLAGS=3D-DGC_MCHECK=3D1 > -Ic:/Devel/emacs/include'' >=20 >=20 >=20