unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jørgen Kvalsvik" <j@lambda.is>
To: Yuan Fu <casouri@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, theo@thornhill.no, 74507@debbugs.gnu.org
Subject: bug#74507: [PATCH] Indent compounds c-ts-mode when { is not BOL
Date: Sat, 30 Nov 2024 21:49:47 +0100	[thread overview]
Message-ID: <eae79a90-78c5-44ae-b218-579e33d484fc@lambda.is> (raw)
In-Reply-To: <BBA96D45-5BC9-4E3B-A892-5143C8D4DC5B@gmail.com>

On 11/30/24 01:16, Yuan Fu wrote:
> 
> 
>> On Nov 29, 2024, at 1:05 AM, Jørgen Kvalsvik <j@lambda.is> wrote:
>>
>> On 11/29/24 08:57, Eli Zaretskii wrote:
>>>> Cc: theo@thornhill.no,casouri@gmail.com
>>>> From: Jørgen Kvalsvik <j@lambda.is>
>>>> Date: Sun, 24 Nov 2024 10:15:12 +0100
>>>>
>>>> * lisp/progmodes/c-ts-mode.el (c-ts-mode--parent-is-not-top-compound):
>>>> New function.
>>>> (c-ts-mode--indent-styles): Use it.
>>>> * test/lisp/progmodes/c-ts-mode-resources/indent.erts: New compound
>>>> statement test.
>>> Please make sure the lines here are not too long (see CONTRIBUTE for
>>> details).
>>>> +(defun c-ts-mode--parent-is-not-top-compound (_n parent &rest _)
>>>> +  "Matches when PARENT is not the top level compound statement,
>>>> +the {} that immediately follows the signature."
>>> The first line of a doc string should be a single complete sentence.
>>> Thanks.
>>
>> Ok. Yuan, would you like me to submit a revision?
> 
> Since your assignment is already done, let’s just apply your patch, and I’ll rebase my changes on top of yours. So yeah, do send the revision patch, thanks!
> 
> Yuan

Certainly - I posted it on the bug tracker.

Thanks,
Jørgen





  reply	other threads:[~2024-11-30 20:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24  9:15 bug#74507: [PATCH] Indent compounds c-ts-mode when { is not BOL Jørgen Kvalsvik
2024-11-29  4:56 ` Yuan Fu
2024-11-29  7:54   ` Eli Zaretskii
2024-11-29  9:04   ` Jørgen Kvalsvik
2024-11-29  7:57 ` Eli Zaretskii
2024-11-29  9:05   ` Jørgen Kvalsvik
2024-11-30  0:16     ` Yuan Fu
2024-11-30 20:49       ` Jørgen Kvalsvik [this message]
2024-12-01  9:25         ` Yuan Fu
2024-12-01  9:51           ` Jørgen Kvalsvik
2024-12-01 21:48             ` Yuan Fu
2024-12-01 22:46               ` Jørgen Kvalsvik
2024-12-02  2:13                 ` Yuan Fu
2024-11-30 15:39 ` bug#74507: [PATCH] Indent compounds in " Jørgen Kvalsvik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eae79a90-78c5-44ae-b218-579e33d484fc@lambda.is \
    --to=j@lambda.is \
    --cc=74507@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).