unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 2291@debbugs.gnu.org
Subject: bug#2291: 23.0.90; finder-commentary
Date: Wed, 27 Apr 2016 10:53:30 -0700 (PDT)	[thread overview]
Message-ID: <ea8fee07-f5d1-44b2-bdff-31bf7e34ca40@default> (raw)
In-Reply-To: <87wpnjeyms.fsf@gnus.org>

> > 1. This sexp in finder-commentary is inappropriate:
> > (delete-other-windows).  The original buffer is current when this is
> > called, and it makes no sense to delete the other windows.  And the
> > call is immediately followed by pop-to-buffer to display and select
> > the Finder commentary buffer.
> 
> This looks like it's fixed now?

Yes, I guess so - it seems to have been removed in Emacs 23.
Dunno whether the bad effect is gone, but I'll assume so.

> > 2. The Commentary buffer name should not be "*Finder-package*".  That
> > prohibits you from having more than one such buffer. Also, the name
> > should reflect the content: this is the Commentary section of a
> > particular Lisp file.  Please use something like this:
> >
> > (pop-to-buffer
> >  (concat "*Commentary, " (file-name-sans-extension file) "*"))
> >
> > instead of this:
> > (pop-to-buffer "*Finder-package*")
> >
> > The result will then be a name like this: *Commentary, buff-menu*
> 
> Wouldn't it make more sense just to use the *Help* buffer?  It has a
> nice history and stuff...

No, certainly not.  It should be commentary-specific, and file-specific,
as described in the bug report.





  reply	other threads:[~2016-04-27 17:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87iqmjokga.fsf@cyd.mit.edu>
2009-02-11 18:36 ` bug#2291: 23.0.90; finder-commentary Drew Adams
2009-02-11 23:35   ` Drew Adams
2009-02-13 15:19     ` Eli Zaretskii
2009-03-08 20:05   ` bug#2291: marked as done (23.0.90; finder-commentary) Emacs bug Tracking System
2016-04-27 17:43   ` bug#2291: 23.0.90; finder-commentary Lars Ingebrigtsen
2016-04-27 17:53     ` Drew Adams [this message]
2016-04-27 17:58       ` Lars Ingebrigtsen
2016-04-27 18:05         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea8fee07-f5d1-44b2-bdff-31bf7e34ca40@default \
    --to=drew.adams@oracle.com \
    --cc=2291@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).