From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52237: 29.0.50; [PATCH 2] Doubled separators in context-menu-mode Date: Thu, 2 Dec 2021 20:46:28 -0800 Message-ID: References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <87wnknmn2a.fsf@gnus.org> <861r2u3num.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7F44DCF009BB7DEB9D8FEF31" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52237@debbugs.gnu.org To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 03 05:47:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mt0Tp-00093y-Hi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Dec 2021 05:47:29 +0100 Original-Received: from localhost ([::1]:48596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mt0Tn-0002gE-O5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Dec 2021 23:47:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt0TO-0002ES-FT for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 23:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38313) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mt0TO-0007m3-7p for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 23:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mt0TN-0007Gx-UF for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 23:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 04:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163850679927927 (code B ref 52237); Fri, 03 Dec 2021 04:47:01 +0000 Original-Received: (at 52237) by debbugs.gnu.org; 3 Dec 2021 04:46:39 +0000 Original-Received: from localhost ([127.0.0.1]:49859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt0T1-0007GM-ET for submit@debbugs.gnu.org; Thu, 02 Dec 2021 23:46:39 -0500 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:38479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mt0Sx-0007G7-1o for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 23:46:37 -0500 Original-Received: by mail-pg1-f179.google.com with SMTP id s137so1883445pgs.5 for <52237@debbugs.gnu.org>; Thu, 02 Dec 2021 20:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=lNXC8293sW2j1lgLGhJ1QxatVI8LxO88HzvAF2fdW0Q=; b=Qmz7BCpMZv1PhgVjS5kk4VLTEKsuABLoe42UHx7uIX41sC8G89V5Lsog4hCeWO7Yuv cSRxvLx+AQrHCz18DqSPT9Ea2S2oPELjkc0aULheN4Uvu7D/jAhr/BaSrLgfxYWWw3br zo96zvfNbBlzwAYe/6ROrr2mhCV0bs6Hw6k1HPJtXGxq9trQH26I0EoyyzjUF3dQ+YwC r0UIo7jFrj2+D6VZIvFHcwDlQER8rv0EWmaZca4un00Gk28vH1UbHbDUWghXm7aeN9f/ Zvov4uF2U+BNe5lhuClgMdnS372Vo4sTQl4GokqdfGeb9lZdF64vNo2NQgNsKfDjQ1sb iM4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=lNXC8293sW2j1lgLGhJ1QxatVI8LxO88HzvAF2fdW0Q=; b=dHCys9rYrPh4oZYJ9/05pFdxgU38cxff0anQQfiKeU98sIdWQ/Stor9p4tBSeRGJTN 44cF8v7WuRCDeC6D1bIuA2jKA5PIb6QOcHmuxwxN1YRCTN0UsVSUTRoo66h/onDoLG/m hT5JOJSmp9xUBrK1nPhCXk6qOX32UAzC6MkvCTLJsoG/oxcL3T45PWuiXBZ9OlscAWgt QYKCHtjSUO76CI9V8XbUo3DbkfIrz3ipQbhkuUDqJLEU70XnghavJ4dzJVIqExzqIMiN pKOzhFml07VNrpMGT3e2opGsdXZH9cjCEZhmA1W6KpXWOGCGIP/1/l/Bu9mA9fEYwIap jaqg== X-Gm-Message-State: AOAM532hOcT009oaae4a+Mz75rTei9+niDQW31FhPxAVseYCMGX8RZIG eLp4HOBD43tYote3yr/P/ScttWuoS+g= X-Google-Smtp-Source: ABdhPJwozdt9FgbOrzdtex057f8TEroNYp0eiMrCov5ZE/rs6tk76jXBu+aeIGIjOhUuHlAf7L4Orw== X-Received: by 2002:a62:1c58:0:b0:49f:d674:e506 with SMTP id c85-20020a621c58000000b0049fd674e506mr16638992pfc.66.1638506788988; Thu, 02 Dec 2021 20:46:28 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id ne7sm3857202pjb.36.2021.12.02.20.46.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 20:46:28 -0800 (PST) In-Reply-To: <861r2u3num.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221371 Archived-At: This is a multi-part message in MIME format. --------------7F44DCF009BB7DEB9D8FEF31 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/2/2021 9:44 AM, Juri Linkov wrote: >>> I've only tested this on Emacs 29 so far, but it may occur on Emacs 28 >>> as well. >> >> Thanks; applied to Emacs 29. > > Why not to Emacs 28? I got a chance to check this under Emacs 28, and the bug exists there too, so it'd be nice to backport. >>> Also, I noticed that separators can appear at the beginning >>> and/or end of the context menu. Should they be removed too? >> >> Hm... I think that might make sense, but I'm not sure. Anybody got an >> opinion? > > Removing leading/trailing separators would be nice too. Ok, here's a patch to do it. There might be a better way to do this, but it should work reliably. Note: this patch doesn't fix the duplicated separators in the help-mode context menu. I haven't had time to look into the right way to fix that yet (there may be other mode-specific context menu functions that have this bug too). --------------7F44DCF009BB7DEB9D8FEF31 Content-Type: text/plain; charset=UTF-8; name="0001-Remove-separators-at-the-beginning-and-end-of-the-co.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Remove-separators-at-the-beginning-and-end-of-the-co.pa"; filename*1="tch" RnJvbSBjNzZkNzUzYjQ2MTk5ZGEwNDg2M2YxOWY3NWZhZjEwMGQ4ZTllNzczIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMiBEZWMgMjAyMSAyMDozOTozMyAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIFJlbW92ZSBzZXBhcmF0b3JzIGF0IHRoZSBiZWdpbm5pbmcgYW5kIGVuZCBvZiB0aGUg Y29udGV4dAogbWVudQoKKiBsaXNwL21vdXNlLmVsIChjb250ZXh0LW1lbnUtbWFwKTogUmVt b3ZlIGJlZ2lubmluZy9lbmQgc2VwZXJhdG9ycy4KLS0tCiBsaXNwL21vdXNlLmVsIHwgMTkg KysrKysrKysrKysrKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9tb3VzZS5lbCBiL2xpc3AvbW91 c2UuZWwKaW5kZXggZWM0M2FlY2RkMC4uYjVjYTgwYTQ0NiAxMDA2NDQKLS0tIGEvbGlzcC9t b3VzZS5lbAorKysgYi9saXNwL21vdXNlLmVsCkBAIC0zMjcsMTIgKzMyNywyMSBAQCBjb250 ZXh0LW1lbnUtbWFwCiAgICAgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIG1lbnUgKGZ1 bmNhbGwgZnVuIG1lbnUgY2xpY2spKQogICAgICAgICAgICAgICAgICAgICAgICAgICBuaWwp KSkKIAotICAgIDs7IFJlbW92ZSBkdXBsaWNhdGUgc2VwYXJhdG9ycwotICAgIChsZXQgKChs IG1lbnUpKQotICAgICAgKHdoaWxlIChjb25zcCBsKQotICAgICAgICAoaWYgKGFuZCAoZXF1 YWwgKGNkci1zYWZlIChjYXIgbCkpIG1lbnUtYmFyLXNlcGFyYXRvcikKLSAgICAgICAgICAg ICAgICAgKGVxdWFsIChjZHItc2FmZSAoY2FkciBsKSkgbWVudS1iYXItc2VwYXJhdG9yKSkK KyAgICA7OyBSZW1vdmUgZHVwbGljYXRlIHNlcGFyYXRvcnMgYXMgd2VsbCBhcyBvbmVzIGF0 IHRoZSBiZWdpbm5pbmcgb3IKKyAgICA7OyBlbmQgb2YgdGhlIG1lbnUuCisgICAgKGxldCAo KGwgbWVudSkgc2F3LWZpcnN0LWl0ZW0pCisgICAgICAod2hpbGUgKGNvbnNwIChjZHIgbCkp CisgICAgICAgIDs7IElmIHRoZSBuZXh0IGl0ZW0gaXMgYSBzZXBhcmF0b3IsIHJlbW92ZSBp dCBpZiAxKSB3ZSBoYXZlbid0CisgICAgICAgIDs7IHNlZW4gYW55IG90aGVyIGl0ZW1zIHll dCwgb3IgMikgaXQncyBmb2xsb3dlZCBieSBlaXRoZXIKKyAgICAgICAgOzsgYW5vdGhlciBz ZXBhcmF0b3Igb3IgdGhlIGVuZCBvZiB0aGUgbGlzdC4KKyAgICAgICAgKGlmIChhbmQgKGVx dWFsIChjZHItc2FmZSAoY2FkciBsKSkgbWVudS1iYXItc2VwYXJhdG9yKQorICAgICAgICAg ICAgICAgICAob3IgKG5vdCBzYXctZmlyc3QtaXRlbSkKKyAgICAgICAgICAgICAgICAgICAg IChudWxsIChjYWRkciBsKSkKKyAgICAgICAgICAgICAgICAgICAgIChlcXVhbCAoY2RyLXNh ZmUgKGNhZGRyIGwpKSBtZW51LWJhci1zZXBhcmF0b3IpKSkKICAgICAgICAgICAgIChzZXRj ZHIgbCAoY2RkciBsKSkKKyAgICAgICAgICA7OyBUaGUgImZpcnN0IGl0ZW0iIGlzIGFueSBj b25zIGNlbGw7IHRoaXMgZXhjbHVkZXMgdGhlCisgICAgICAgICAgOzsgYGtleW1hcCcgc3lt Ym9sIGFuZCB0aGUgbWVudSBuYW1lLgorICAgICAgICAgICh3aGVuIChjb25zcCAoY2FkciBs KSkgKHNldHEgc2F3LWZpcnN0LWl0ZW0gdCkpCiAgICAgICAgICAgKHNldHEgbCAoY2RyIGwp KSkpKQogCiAgICAgKHdoZW4gKGZ1bmN0aW9ucCBjb250ZXh0LW1lbnUtZmlsdGVyLWZ1bmN0 aW9uKQotLSAKMi4yNS4xCgo= --------------7F44DCF009BB7DEB9D8FEF31--