From: Dmitry Gutov <dgutov@yandex.ru>
To: Paul Eggert <eggert@cs.ucla.edu>, Eli Zaretskii <eliz@gnu.org>
Cc: oub@mat.ucm.es, 23595@debbugs.gnu.org
Subject: bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS)
Date: Tue, 24 May 2016 12:47:18 +0300 [thread overview]
Message-ID: <ea7c15a3-18eb-881d-821c-c350a64f9848@yandex.ru> (raw)
In-Reply-To: <be0c3f50-de71-e99d-08b0-7ecf17842b74@cs.ucla.edu>
On 05/24/2016 03:07 AM, Paul Eggert wrote:
> Not as far as I know. I was hoping we wouldn't have to write a bug
> report now, as emacs-25 does not have that bug now. I suppose someone
> with more free time could write a test case....
OK, maybe it's not too important.
> Emacs can decide the coding system before git diff generates any output,
> by applying decode-coding-string to a canary string sample. The attached
> patch should work; please give it a try.
It works at least as well as my patch, or that's what I could test.
But:
- Shouldn't that change be in vc-coding-system-for-diff?
- It seems to try to fix a separate issue (whether all files use the
same coding system).
- Like Eli pointed out, (coding-system-get coding-system-for-read
:ascii-compatible-p) should work about as well. Why doesn't it?
As an aside, how did you manage to create a patch that's using tabs for
indentation, with indent-tabs-mode bound to nil in .dir-locals.el?
That's troubling.
next prev parent reply other threads:[~2016-05-24 9:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 13:02 bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS) Uwe Brauer
2016-05-23 11:52 ` Dmitry Gutov
2016-05-23 12:41 ` Uwe Brauer
2016-05-23 13:17 ` Dmitry Gutov
2016-05-23 16:52 ` Eli Zaretskii
2016-05-23 16:51 ` Eli Zaretskii
2016-05-23 16:48 ` Eli Zaretskii
2016-05-23 17:00 ` Uwe Brauer
2016-05-23 17:31 ` Eli Zaretskii
2016-05-23 20:37 ` Uwe Brauer
2016-05-23 21:01 ` Lars Ingebrigtsen
2016-05-24 2:33 ` Eli Zaretskii
2016-05-23 21:02 ` Dmitry Gutov
2016-05-23 22:16 ` Paul Eggert
2016-05-23 22:28 ` Dmitry Gutov
2016-05-24 0:07 ` Paul Eggert
2016-05-24 9:47 ` Dmitry Gutov [this message]
2016-05-25 6:51 ` Paul Eggert
2016-05-25 12:44 ` Dmitry Gutov
2016-05-24 2:40 ` Eli Zaretskii
2016-05-24 15:36 ` Eli Zaretskii
2016-05-24 2:36 ` Eli Zaretskii
2016-05-24 9:35 ` Dmitry Gutov
2016-05-24 15:40 ` Eli Zaretskii
2016-05-25 0:09 ` Dmitry Gutov
2016-05-25 16:22 ` Eli Zaretskii
2016-05-25 23:21 ` Dmitry Gutov
2016-05-26 10:44 ` Uwe Brauer
2016-05-26 15:35 ` Eli Zaretskii
2016-06-19 19:09 ` Dmitry Gutov
2016-05-25 6:19 ` Paul Eggert
2016-05-25 16:27 ` Eli Zaretskii
2016-05-25 6:19 ` Paul Eggert
2016-05-25 16:26 ` Eli Zaretskii
2016-05-23 17:40 ` Paul Eggert
2016-05-23 18:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea7c15a3-18eb-881d-821c-c350a64f9848@yandex.ru \
--to=dgutov@yandex.ru \
--cc=23595@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=oub@mat.ucm.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).