From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#48841: fido-mode is slower than ido-mode with similar settings Date: Sun, 6 Jun 2021 02:42:37 +0300 Message-ID: References: <87eedgy7pt.fsf@gmail.com> <1f659c88-4d9d-8fc9-733a-5e6068f9ed4a@yandex.ru> <87a6o3x5j7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12551"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: 48841@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , monnier@iro.umontreal.ca Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 06 01:43:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpfwc-00037M-Ur for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 01:43:10 +0200 Original-Received: from localhost ([::1]:58958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpfwb-00063l-47 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Jun 2021 19:43:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpfwU-00062v-JH for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 19:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpfwU-0004nw-9W for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 19:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpfwT-0004Dx-SR for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 19:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jun 2021 23:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48841 X-GNU-PR-Package: emacs Original-Received: via spool by 48841-submit@debbugs.gnu.org id=B48841.162293656916218 (code B ref 48841); Sat, 05 Jun 2021 23:43:01 +0000 Original-Received: (at 48841) by debbugs.gnu.org; 5 Jun 2021 23:42:49 +0000 Original-Received: from localhost ([127.0.0.1]:50290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpfwG-0004DW-WE for submit@debbugs.gnu.org; Sat, 05 Jun 2021 19:42:49 -0400 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:51945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpfwD-0004DH-KL for 48841@debbugs.gnu.org; Sat, 05 Jun 2021 19:42:47 -0400 Original-Received: by mail-wm1-f41.google.com with SMTP id r13so7571945wmq.1 for <48841@debbugs.gnu.org>; Sat, 05 Jun 2021 16:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8Kmm/Fi9lwNonVukfgTpH5+OH6gFamvQ2hASIsfyGvg=; b=MaUDTnbX3uHZN8pF72nDshfjh7vpHGzGN7szT/7nGZgr6lHaFcceiEr3TcqTDApnSt EKbwGHjmqNnfiQwMb8z2jproLl9XQhxfhoNSMAechTsyeI4ER/b9a2idvt0FCMMs+1Ap 08iHGlBfebQiXelG3JhfMRWGWYKvOXQwNLHNoiBPZiSzF4MzPB+XRr7C6suh3nJo3Vsh hsnvB34igg3K6Bg/Jg7LR5B+B6SLsFr3cSwu4XXOMwTkBKjnwi/nlfkzg7MqebgKhyT2 GagS0kY8+LCZebKvDM6Jj+zcRIFm3fgUz52RRQ0tk+LVZYToLROWceSmuh7wJtlaPbjx apGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8Kmm/Fi9lwNonVukfgTpH5+OH6gFamvQ2hASIsfyGvg=; b=UZVwJnt4HT/CWkllxQqJAyQKbUEUkTUGdzj4V2kRC6wbDfQYaF9XyAQU7E47RRjnVg u/4oFlAYK2F9hUIA2Jgn4u/DeyN1dg1Y7bQrrrkxPg5/ivc5K/PSdRcX2UcvxWyXD8ub sU1Daa+GYCk9mMFG6bjVV5AFPPX+pylruHe6vW8X7geY97dzaMfe6x7ZnMlUsVZhFI2Y xl/Gq9+w2mOKWa88zH/CrowcGuPuBSu6nwQXi1Kvr+MEDv73Uy5UrljIiSe+nnB+AYKA GAH2v2x4X27yFTxmYffFxwhrGfj/mgyjTB+uFPc2e+AGXBkOU0c3eQONWbCipjmmgr0y YGow== X-Gm-Message-State: AOAM530udsgGCmL1L/CMLNCs/Og8qIVdngJHbWZes/NqlzTVnK1fbvdR kMFgCtE6t0Bg3jzWcTzmTj2V+l1w5BM= X-Google-Smtp-Source: ABdhPJxaG910IBcNYCXj4vn+umJ6mzFV+ziyapiARXTU3ST0S2hQIrqFpJtrttF9x4aojZ1fyCNYbg== X-Received: by 2002:a1c:bd41:: with SMTP id n62mr9712529wmf.83.1622936559604; Sat, 05 Jun 2021 16:42:39 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id i9sm4563019wrn.54.2021.06.05.16.42.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Jun 2021 16:42:39 -0700 (PDT) In-Reply-To: <87a6o3x5j7.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208079 Archived-At: On 06.06.2021 02:20, João Távora wrote: > Now, what I called here the "suffix-calculation logic" is what I also > called the "[mplete] dance" back in the emacs-devel thread. Truth is, > it's always annoyed me in icomplete partially because I don't understand > what it does exactly and how it is supposed to help me. I suppose > Stefan knows best here. Regardless of its use, it seems to require > another try-completion call in all the filtered candidates (which might > be very big) so that's probably where the extra lag comes from. Shouldn't this logic (whether it's used) be governed by the variable icomplete-hide-common-prefix? Which icomplete--fido-mode-setup sets to nil (appropriately, given than ido-mode does not have this behavior). And looking at its behavior, it only does the "[mplete] dance" when there is only one match remaining. Whether to make icomplete-hide-common-prefix affect even the "only one match" case is a matter of taste: I could personally find an argument for either choice. But we're seeing performance degradation when there are many matches, not one.