From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#36974: 26.2.90; [PATCH] Add imenu support to xref Date: Tue, 24 Dec 2019 22:41:17 +0200 Message-ID: References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="262496"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 36974@debbugs.gnu.org To: Lars Ingebrigtsen , Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 24 21:42:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ijr0N-0016BQ-HP for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2019 21:42:11 +0100 Original-Received: from localhost ([::1]:41848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijr0M-0001YE-DV for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2019 15:42:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42460) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijr0G-0001Y8-KF for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2019 15:42:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijr0E-0005SJ-PS for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2019 15:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47137) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ijr0E-0005S2-Ar for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2019 15:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ijr0E-0002AL-77 for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2019 15:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2019 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36974 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 36974-submit@debbugs.gnu.org id=B36974.15772200888284 (code B ref 36974); Tue, 24 Dec 2019 20:42:02 +0000 Original-Received: (at 36974) by debbugs.gnu.org; 24 Dec 2019 20:41:28 +0000 Original-Received: from localhost ([127.0.0.1]:53110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijqzg-00029Y-4J for submit@debbugs.gnu.org; Tue, 24 Dec 2019 15:41:28 -0500 Original-Received: from mail-wr1-f66.google.com ([209.85.221.66]:47011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijqze-00029K-3i for 36974@debbugs.gnu.org; Tue, 24 Dec 2019 15:41:26 -0500 Original-Received: by mail-wr1-f66.google.com with SMTP id z7so20552997wrl.13 for <36974@debbugs.gnu.org>; Tue, 24 Dec 2019 12:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=S+eVvK+5UOEcIS12TeU87DMIs3QfH45VzkLJ7nco6+M=; b=fCC1e6wSRXPhOlrmeyd5yW5x/vRueoulLaC9EPyb5CR5jpXRvoCyhXSXXOUKZ23aWO 6W0NDDgO0SX6PdqgjtL56QzHlpcfZyL02R72C80UhR5veiQSqFQOkLTlC8PWn3LzcKVZ TwO/wX65ipDDtuKxsfyIsFcg1NzuE5zR/irmpVyoZPznXhAg3SwcaGkvmuj1DzeXnTsY LLFkCbokVNWHmOq2xsPUA1p6IXASAQILm/2V1maZ2uTQkukGGeKvTgRwzkfM+mGO0O/Z vfrob4A5i3SGenAiO6cHXJV4sFMW8TSfq0NxWTxqD4wHtTr/cHjPEiTC4ejbHscJe4RN RMFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S+eVvK+5UOEcIS12TeU87DMIs3QfH45VzkLJ7nco6+M=; b=TAwhCNC+FI1B2BFKfxMWWJt6AyFW0RPJgPTBmBxWub+u/BDuQ8e+sVYIzwfYLTbMuV aw8Gl2VubRhBE+HJaZg1j5EZ44PghN0rC+49hS+vqo1WMSYo4+laUcvFMYQGZTuyByRh oG3gx9IIzXprBfSwPFnbi4p1oAoRhNknyvxSbdsOGfJ6nIFrWc174Zi8yOmZKXvjJXiC tpst+Vw8I1sKoGOIrJ4XckDAT/8plgcNRFJ9DNMxJlcOBpAvpUBAqnbRzi4mpFeyCEEr wyZF/CdVdssjiYomBa9WQdVDa5uIiCby0lnTFD+DB7Kf3SrudnoDKtX66V5HzWvQ7ZV6 Ld/A== X-Gm-Message-State: APjAAAWtYbH6r1YX9/Brb8v3CvRxXZ3nAV0UrN8+Y20G+5P8Oiia3DUP s/uYARSGN/RQoZlZXU8Yhp39uGkfaGA= X-Google-Smtp-Source: APXvYqw+Y/8rZJaTB0j7uOlN1JRf4eLeDRUPSd9kPwhzJbXBuvLYMvqiYQmYNwqXL8GhOGnWMw0G/A== X-Received: by 2002:adf:dcc2:: with SMTP id x2mr16750642wrm.24.1577220079957; Tue, 24 Dec 2019 12:41:19 -0800 (PST) Original-Received: from [192.168.0.2] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id w13sm25666166wru.38.2019.12.24.12.41.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Dec 2019 12:41:19 -0800 (PST) In-Reply-To: <87imqoh57t.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173725 Archived-At: On 23.08.2019 7:32, Lars Ingebrigtsen wrote: > Damien Cassou writes: > >> * lisp/progmodes/xref.el (xref--imenu-prev-index-position) >> (xref--imenu-extract-index-name): Add functions to get imenu support. >> (xref--xref-buffer-mode): Set imenu variables to the new functions. >> * etc/NEWS: Add corresponding entry. > I'm not a big imenu user, so I'm probably not the best to judge the > applicability of this patch, but it looked logical to me, and I've > applied the patch (after folding a couple of too-long lines). This patch had a typo which made it not work at all (which is easy to see by calling 'M-x imenu' in any of the Xref buffers). Considering it's been applied 4 months ago and nobody noticed the problem, maybe it's not that useful after all?