From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73022: 31.0.50; Crash in build_frame_matrix_from_leaf_window after C-x 2 and reducing terminal size Date: Thu, 5 Sep 2024 16:45:52 +0200 Message-ID: References: <86le07624j.fsf@gnu.org> <60579ab6-db81-4f6e-b281-0cee03dc3b82@gmx.at> <86cyli4fxj.fsf@gnu.org> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9659"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: n142857@gmail.com, 73022@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 05 16:47:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smDlQ-0002JP-Q7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Sep 2024 16:47:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smDlD-0003LC-BU; Thu, 05 Sep 2024 10:46:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smDlC-0003F5-8v for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:46:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smDlB-0005oh-VI for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:46:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=GabLMqOA+45m88Xa4yH4PnwSTcqg7HgukKsmuYX905o=; b=e2G+46vfjiBfSB9YPUfQjj6eyc/Op1fnf/Yj014uPITJP7jvjxU66eAUqGNd+8mZYAoGqpspH5X4t25sDa4uEEzNyfTEyuedKYSpAQV6d3qwpOMYQ3XO9EgvcMmc1CEMRBMwFNjZY6kulTmT4uTT5A8L7Uw019+6dwY8VdYo1RpXFgR8KnULSpriU66WyRejpstrcK8/MLpuhUaCDZUwuorBvDchProhWBXAXWfdwy41+IxLJUixED36//ztrqCt/76lQiXcyvVEkef4z9p6AH7lLRdm3Zl7ongdrMNzraVHv00ZLrdyiZuGoakarbe+pqIBZcqoZ4qbLMsauq3rsA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smDmE-0007PQ-37 for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2024 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73022 X-GNU-PR-Package: emacs Original-Received: via spool by 73022-submit@debbugs.gnu.org id=B73022.172554762828283 (code B ref 73022); Thu, 05 Sep 2024 14:48:02 +0000 Original-Received: (at 73022) by debbugs.gnu.org; 5 Sep 2024 14:47:08 +0000 Original-Received: from localhost ([127.0.0.1]:37811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smDlL-0007M7-R3 for submit@debbugs.gnu.org; Thu, 05 Sep 2024 10:47:08 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:50713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smDlI-0007LW-Ri for 73022@debbugs.gnu.org; Thu, 05 Sep 2024 10:47:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1725547553; x=1726152353; i=rudalics@gmx.at; bh=GabLMqOA+45m88Xa4yH4PnwSTcqg7HgukKsmuYX905o=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=dMAr7tHs9VSV0pTNysq9WtTb8P0VZbU9QDWuL/uCOHcCqTPP5hwUO8hhTgJAAHi7 nXkO8MD5wu0nGImbO1i/lsJiJEOPFWxoG9wrJ9dKP9HgQjCGRQtu+lYOeKPXa6PkW 1ViEFxi0oP0Ld7chkqKFjWcCA8lQucVvE622LHm2d45cNlv/2eZzCxNeK115PByyY DIYcmv5Nkb0KdE6tqLVtmoVv6zR8mMglqcWCRbsK3R3BmHrncv4ZUceYMzWHq5SM+ fyhyKmVTLYHTU/lzIpwWOyjxp8sSzWde1Qd1mLjwc892jaChlUEBfQjmRGrfwPO4r grMf4DIUImBVsQm61g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([212.95.5.159]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Md6Qr-1sDAF01PD1-00qjCR; Thu, 05 Sep 2024 16:45:53 +0200 Content-Language: en-US In-Reply-To: <86cyli4fxj.fsf@gnu.org> X-Provags-ID: V03:K1:XeLC3cNRMda3sZQFuLtO//bABoCChuYC7imZtqkfcQPdEOzvJ10 7cz50nW9yO03SC2s13GwC8ex32RwFQc29r/TFOG4dAjRTGrdiTlytLKFJo8L9hIcBbqf2mz lUEd6CuHiCqwC7+0gVqdt2l9beZ/1m0Jcz1KvnD8h+sIK3XGMm8kfBJNxZ0AQQVjUsmWUoM oLGyV7V1yss9SIfkUERMw== UI-OutboundReport: notjunk:1;M01:P0:AxfJiG7RWmQ=;2hQCGbH9dp/Jx+WOFlOf1lWSVQd bcvurSBtOOSg9IcA39md6zk+b8EImJ0IwMaYgvBtcsIfjmu9KI5bgmJVlOGzu7taOQvOb7bus w+ykVpjmOBgjdpN4niHLqpzjeSr2Mm/9art+fNCX7Fw4qgu7JHoa7tjeFznXQZvXj3eoXJJwe YlPd2wzIzrS2ZAxwTmhG+CwBfnjKO1ptF0v01DoRDh4xtjgr4pV/K79A56slsHKMNJE82q6TH XfNHbWKgNA2+IUY+xlGHobM2Pi9E7vesJLQZdWZO+zxupjiWUIbWem5OjQ1DZzHE+Dm/EoA9a 6tetgMxiKsnC7nhnRPOPRUQXzQ+3vfygdYJbE7R4tdeYQIppx4L0H8hNf7rPGESN907DCjf6U ik7sPjPHBtT36dzKOzj6ehQ8aXL/3aEgkmZFs8bAMwgQTeY+3htdifW8TLwsjOuasGswtVsbP l5gi9LIr4wjPDw6e8XpmlC6O91r3/qmUtk+U8IOxqWV5hG6XHH4pFSeheqvRZHB7XHOXDQ39O iHlf6bVZZm/uosb3oZo58fkBDgYwjpboCYZAJ9WrPJvM0WfkihBZiaJZKEn3lHTswybpsV/xz rKMkgPiiRIo5oyesXUq7VgQwbGmR2qPsx82iLcuRenvB32L3CNUyKn044cgR8SKTPU0LbymOf lRvC9BGIxNPk3QDtzKPbam4hh8F7YMoJVGAAb9oVEZV0cjoopPmiG1kQoY6QffOJbH4OV2r93 XfvvJ1/FbHJp9OE8gD5hKh8wrv8/lDc7A5cpvjWHrwWeotXSnBxXYw/W/tpx959DV+Xl/OYi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291261 Archived-At: >> If so, then this violation might be caused by the fact that we >> (1) did resize windows according to the new sizes but (2) did not update >> the frame sizes accordingly. > > Can you elaborate on how this could be possible? I always thought we > first allocate the frame matrices, and then the window matrices (by > suballocating them from the frame matrices). Am I mistaken? But if glyph_row_slice_p (window_row, frame_row) fails, something else must have invalidated that. I made that change here more than three years ago and I can neither remember whether an assertion violation made me do it or a crash nor why I did chose a term like "congruent" in the comment. One possibility I cannot exclude is that adjust_frame_size tries to resize windows, that step (silently) fails in window_resize_check, the old values stay in place but the new frame sizes are applied by adjust_frame_size. But precisely this scenario cannot be healed by my patch so it's unlikely that it was the cause for the problem I experienced back then. > Moving code in adjust_frame_glyphs could affect the assertion if the > assertion was being hit while adjust_frame_glyphs is still being > executed. But that is not the case, so I don't understand how moving > some code in adjust_frame_glyphs without changing it could affect the > assertion violation. I'm probably missing something. I'm still too dense to understand what "Moving code" and "moving some code" could mean in this context. If you have enough patience left, please elaborate. Thanks, martin