* bug#16807: 24.3.50; changes in advice.el break multi-term.el
@ 2014-02-19 5:55 henry atting
2014-02-28 2:30 ` Glenn Morris
2014-02-28 13:56 ` Stefan Monnier
0 siblings, 2 replies; 3+ messages in thread
From: henry atting @ 2014-02-19 5:55 UTC (permalink / raw)
To: 16807
In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.8.6)
of 2014-02-08 on bye
I know multi-term.el is not part of emacs and, what is more, isn't
developed anymore as far as I can see. So take it much more as a brief
remark than as a bug report.
Following function and macro where removed from advice.el:
(defmacro ad-macro-p (definition)
;;"non-nil if DEFINITION is a macro."
(` (eq (car-safe (, definition)) 'macro)))
(defun ad-advised-definition-p (definition)
;;"non-nil if DEFINITION was generated from advice information."
(if (or (ad-lambda-p definition)
(ad-macro-p definition)
(ad-compiled-p definition))
(let ((docstring (ad-docstring definition)))
(and (stringp docstring)
(string-match
ad-advised-definition-docstring-regexp docstring)))))
But multi-term depends on it.
Putting these lines somewhere at the beginning of ~/.emacs works for me
as a workaround.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#16807: 24.3.50; changes in advice.el break multi-term.el
2014-02-19 5:55 bug#16807: 24.3.50; changes in advice.el break multi-term.el henry atting
@ 2014-02-28 2:30 ` Glenn Morris
2014-02-28 13:56 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2014-02-28 2:30 UTC (permalink / raw)
To: henry atting; +Cc: 16807
OK, thanks for the info.
I don't think those definitions are coming back, so from the Emacs side
there isn't really anything to do here. It seems pretty odd that
multi-term would be using those, I doubt if it really needed to do so
(but I've never looked at it).
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#16807: 24.3.50; changes in advice.el break multi-term.el
2014-02-19 5:55 bug#16807: 24.3.50; changes in advice.el break multi-term.el henry atting
2014-02-28 2:30 ` Glenn Morris
@ 2014-02-28 13:56 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2014-02-28 13:56 UTC (permalink / raw)
To: henry atting; +Cc: 16807
> (defmacro ad-macro-p (definition)
multi-term.el can use the new `macrop' instead. But I don't see any use
of ad-macro-p in
https://github.com/milkypostman/multi-term/blob/master/multi-term.el
> (defun ad-advised-definition-p (definition)
multi-term.el doesn't really need this anyway, it seems. I.e. you can
just replace it with (defun ad-advised-definition-p (def) t))
Both of these were too internal to be worth providing (even as obsolete
definitions).
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-28 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-19 5:55 bug#16807: 24.3.50; changes in advice.el break multi-term.el henry atting
2014-02-28 2:30 ` Glenn Morris
2014-02-28 13:56 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).