From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#74287: [PATCH] Rework history Isearch for Eshell Date: Sun, 8 Dec 2024 20:34:57 -0800 Message-ID: References: <871pzjkhmm.fsf@pengjiz.com> <8c80ae91-476e-e665-43be-86d72fb57ed1@gmail.com> <86v7waz603.fsf@gmx.net> <6fdd8386-8915-e3a8-046a-b18750a7057d@gmail.com> <87v7vzgtuq.fsf@mail.linkov.net> <87jzcecnc9.fsf@pengjiz.com> <87h67icmu1.fsf@pengjiz.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11232"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74287@debbugs.gnu.org To: Pengji Zhang , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 09 05:36:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tKVVO-0002kZ-Na for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Dec 2024 05:36:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKVV5-0008Vv-Ki; Sun, 08 Dec 2024 23:36:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKVV4-0008Vl-Iy for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 23:36:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKVV4-0001N9-Ay for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 23:36:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=zAsQGmYVFaugMVzbP8M65yU4Gcx9Jmta2cO/Nj7vBEQ=; b=eja5gVI1eNHqK2q1jnRcOQcwzduTMBGlR/gWPEGbbi+Npx8Pk7vFdPSDSCmkeNvb71EJ2OgvQ0Tq3d7LY0OFFFsH/bp6avrCScdCaBmeZD/qdkl9r++1JWv4lptBuSFgzOLktq5IK+jJiQHLGXHe7GHKvf6AjUZDoGJ/JQG/sooNoPoYGxPvrw5pZJbSFLWrGVe0hpkObPVE9898IzjGfe7G07kPMHoGhir5RJISFvOs5D2qX3haaJJzN7SFphogaAzf8tVGNjSMGCkTKS3RP5zpv+egJSCfwLuJinFB9jP9CQOVEAT0r8f4mq1OBOxZSLYJ5SzR/bYomEygGtwQyw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKVV4-0004bC-5R for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 23:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Dec 2024 04:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74287 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74287-submit@debbugs.gnu.org id=B74287.173371896017662 (code B ref 74287); Mon, 09 Dec 2024 04:36:02 +0000 Original-Received: (at 74287) by debbugs.gnu.org; 9 Dec 2024 04:36:00 +0000 Original-Received: from localhost ([127.0.0.1]:52527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKVV2-0004ao-8J for submit@debbugs.gnu.org; Sun, 08 Dec 2024 23:36:00 -0500 Original-Received: from mail-pf1-f177.google.com ([209.85.210.177]:45551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKVV0-0004ag-MM for 74287@debbugs.gnu.org; Sun, 08 Dec 2024 23:35:59 -0500 Original-Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-725f3594965so135416b3a.3 for <74287@debbugs.gnu.org>; Sun, 08 Dec 2024 20:35:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733718898; x=1734323698; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=zAsQGmYVFaugMVzbP8M65yU4Gcx9Jmta2cO/Nj7vBEQ=; b=I9fHn3hE8LSlewYxO1+ZiLDvcEuD4ZEwY7FzlyQ1L926Fh1Mi56afW+BhSapIPhwVe u30NSTU/JIDnIkIWvY5Pb+gKAfk6NeIZ8RY2HmeHm/Rv1l22u+k96l4wJqngulc5e6D5 jznxyvStkcXA+r6a5reRPKZXgn+Yj/pwSSTP1UfXft9dneadIiNRu/wUZY0NPm4dC6eC mE8+VTbkY8q9BBZ+JeRO5dzakUE7F+WZKDEOEzy9V2zHpRP+4PuyQeV1t0GrMe4qs4Cu KpwOvQV+vNlB7Jd9M+RbKYeI+1bImGJyO3ggCaw8B1rsXOPZ1NWZq187PtwezDo/Oy1W 7bIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733718898; x=1734323698; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zAsQGmYVFaugMVzbP8M65yU4Gcx9Jmta2cO/Nj7vBEQ=; b=voMi7dwdJlN/X6rvjEGCi0io+XLt8wPlk7HUPV9Yhn1tAuacZE8EZGOHjrRCY9+Ee9 dF2aBZzyQ+68whwgmPJT9WdVhyTq4pfV/FpArcy4707a7a6eYPfXRDiBSuhmE2/FR/Ef xLV+HhyWmPfxsUauoWxbTmWWxleDepua4VRsmsOEFgFyw4sZyenrlvNyMfWhoo2tTIKd 1GtKndy6kHAZAYp4Lvk4vI25nQJHCDx4kZnJ1l7PMGHVU+hkhDJfprtw9NXFOtm1f4K3 PngcsGHfkGInYXKu7dORjee9tLNzZT7ExDuaIqOQr5EQUkoghkw3z5izEO81hNNqv62k ImVg== X-Gm-Message-State: AOJu0YxTYLiljBWC33CdX/Y/8TgK2B5hNkyXSm832oQRBHanRWa86Vrl LP4xZoZ89cmpI4O7XjbtqxanjyUJOufSZDdXKWT6JHO22fE12F/i X-Gm-Gg: ASbGncuUsL6OoDEUvsryBcoec61zM3E+R6pgfbXVgJp/qX9/DHY6VtMpzhHsCFr0a7y r0MnvoNeq3t343dd3dG/raGRB75de1UeRb3jsKJSma1eKJmvaUUQaktjwbDH++if10TxE/WY4h8 RIDinzAIv+Gjnt4gIF7tmiajkov/t9av/e5Dlb425PXwCHzje2qVm2CoVKMNcCOYO8CdtQv/Wpm wrAEign6qu5syTtjJhIFyo/90LDXPkrw9BjxeVnIPx1f0bq6g8bPFU75DQ88a5fY3Tqbv0qBDPz h+RrS+Ezor9HPs1uEQC0e/ihZeA= X-Google-Smtp-Source: AGHT+IEEOziomjF+ASdHOJJK7kdOeGlG76zSteFyac9xcg5pIcpdSa5eW+j2lvtsLiKqDN/wcHdb/g== X-Received: by 2002:a05:6a00:b87:b0:725:937a:b124 with SMTP id d2e1a72fcca58-725b81d84b5mr18644839b3a.26.1733718898063; Sun, 08 Dec 2024 20:34:58 -0800 (PST) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-725ee10f928sm922392b3a.32.2024.12.08.20.34.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Dec 2024 20:34:57 -0800 (PST) Content-Language: en-US In-Reply-To: <87h67icmu1.fsf@pengjiz.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296678 Archived-At: On 12/5/2024 4:53 AM, Pengji Zhang wrote: > Forgot to update the commit message. Please disregard the previous patch > and check the one attached to this email instead. Sorry for the noise! I finally had time to test this out. This seems to work well, except for one issue. In 'eshell-history-isearch-end' you have this bit: > + (unless isearch-suspended > + (custom-reevaluate-setting 'eshell-history-isearch))) Unfortunately, this doesn't work well when using "(setopt eshell-history-isearch t)". The value gets reset to nil when exiting history Isearch, so the next time a user Isearches, they'll just get "regular" Isearch. Is there a way we could change this so that users who use 'setopt' (or even 'setq'?) instead of the Customize package can enable this feature?