From: Jim Porter <jporterbugs@gmail.com>
To: Pengji Zhang <me@pengjiz.com>, Juri Linkov <juri@linkov.net>
Cc: 74287@debbugs.gnu.org
Subject: bug#74287: [PATCH] Rework history Isearch for Eshell
Date: Sun, 8 Dec 2024 20:34:57 -0800 [thread overview]
Message-ID: <e7e93e2e-4817-e5cc-f8ad-c911f8901be2@gmail.com> (raw)
In-Reply-To: <87h67icmu1.fsf@pengjiz.com>
On 12/5/2024 4:53 AM, Pengji Zhang wrote:
> Forgot to update the commit message. Please disregard the previous patch
> and check the one attached to this email instead. Sorry for the noise!
I finally had time to test this out. This seems to work well, except for
one issue. In 'eshell-history-isearch-end' you have this bit:
> + (unless isearch-suspended
> + (custom-reevaluate-setting 'eshell-history-isearch)))
Unfortunately, this doesn't work well when using "(setopt
eshell-history-isearch t)". The value gets reset to nil when exiting
history Isearch, so the next time a user Isearches, they'll just get
"regular" Isearch.
Is there a way we could change this so that users who use 'setopt' (or
even 'setq'?) instead of the Customize package can enable this feature?
next prev parent reply other threads:[~2024-12-09 4:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-10 1:22 bug#74287: [PATCH] Rework history Isearch for Eshell Pengji Zhang
2024-11-10 23:40 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-12 8:54 ` Pengji Zhang
2024-11-26 6:53 ` Jim Porter
2024-11-26 9:41 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-26 17:00 ` Jim Porter
2024-11-27 5:37 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-04 18:56 ` Juri Linkov
2024-12-05 12:43 ` Pengji Zhang
2024-12-05 12:53 ` Pengji Zhang
2024-12-09 4:34 ` Jim Porter [this message]
2024-12-09 12:16 ` Pengji Zhang
2024-12-09 13:35 ` Pengji Zhang
2024-12-09 19:06 ` Jim Porter
2024-12-09 18:23 ` Juri Linkov
2024-12-10 0:55 ` Pengji Zhang
2024-12-10 7:46 ` Juri Linkov
2024-12-10 11:01 ` Pengji Zhang
2024-12-10 17:41 ` Juri Linkov
2024-12-11 0:45 ` Pengji Zhang
2024-12-11 7:06 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7e93e2e-4817-e5cc-f8ad-c911f8901be2@gmail.com \
--to=jporterbugs@gmail.com \
--cc=74287@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=me@pengjiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).