From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el Date: Sun, 23 May 2021 21:58:35 +0200 Message-ID: References: <2ebf9ed0-bd5d-8107-9d22-61e56f29c02a@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3120"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48572@debbugs.gnu.org, joaotavora@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 23 21:59:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkuFi-0000dM-6S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 May 2021 21:59:10 +0200 Original-Received: from localhost ([::1]:38064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkuFh-0005bQ-7U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 May 2021 15:59:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkuFa-0005b9-Hc for bug-gnu-emacs@gnu.org; Sun, 23 May 2021 15:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkuFa-00049s-CJ for bug-gnu-emacs@gnu.org; Sun, 23 May 2021 15:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lkuFa-0003qE-BF for bug-gnu-emacs@gnu.org; Sun, 23 May 2021 15:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 May 2021 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48572 X-GNU-PR-Package: emacs Original-Received: via spool by 48572-submit@debbugs.gnu.org id=B48572.162179992914735 (code B ref 48572); Sun, 23 May 2021 19:59:02 +0000 Original-Received: (at 48572) by debbugs.gnu.org; 23 May 2021 19:58:49 +0000 Original-Received: from localhost ([127.0.0.1]:41790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkuFN-0003pb-Jf for submit@debbugs.gnu.org; Sun, 23 May 2021 15:58:49 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:52551 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkuFJ-0003pL-Jr for 48572@debbugs.gnu.org; Sun, 23 May 2021 15:58:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j1Aj1BkGG4wizLtKFQY3GxSDy+Sft1J1D+RYFleES9c=; b=J9ZIzNdgPInXMATeF9uGngOci5 YQnicamqoOKfb+QJEnsYn9lnFcwLSMm0cMxqrM4L8vevzk0x3rCjrOrCFj2ezJB/VQ/8zF7TupHET 9h/YfFqL/+M5MCk2BQPl6IwiejLfToys49xUZDMK83nzNMVt2iILQE3DNMaDxySaAo9w=; In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207100 Archived-At: On 5/23/21 5:50 PM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >>> Clearly, this is not right: passthrough completion should pass the `str` >>> and `point` info to the completion table. The completion table may opt >>> to ignore that information, but we shouldn't prevent them from using it. >>> I expect most passthrough uses will want to use `str`. >> >> I see what you mean. In my use case I didn't use an improperly >> implemented completion table which does not ignore . However the >> question is then if this "passthrough" style is really needed since if >> you don't ignore the input, it is mostly equivalent to the emacs21 style. > > The "passthrough" (elsewhere called "backend") completion-style is > definitely something we need to add, yes. But what it should do is pass > all the args from `completion-all/try-completions` to the table and let > the table do *all* the work, i.e. let the completion table implement the > completion-style methods. But we shouldn't call `all-completions` or > `try-completions` for that. Instead we should call the completion-table > directly, as is done for the `completion-boundaries` method. But `all-completions` and `try-completion` already calls the table directly if the table is indeed a table. Basically `all-completions/try-completion` themselves are already "passthrough" modulo some calling convention. Am I missing something?