From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Sun, 12 Dec 2021 13:59:16 -0800 Message-ID: References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <83tufdmu4d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14804"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52293@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 23:00:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwWtU-0003f4-Vi for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 23:00:32 +0100 Original-Received: from localhost ([::1]:38958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwWtT-0006lc-5M for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 17:00:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwWt0-0006hn-CR for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 17:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwWt0-0007kW-2B for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 17:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwWt0-0004qo-1i for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 17:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 22:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163934636518576 (code B ref 52293); Sun, 12 Dec 2021 22:00:01 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 21:59:25 +0000 Original-Received: from localhost ([127.0.0.1]:53379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwWsP-0004pX-EC for submit@debbugs.gnu.org; Sun, 12 Dec 2021 16:59:25 -0500 Original-Received: from mail-pj1-f50.google.com ([209.85.216.50]:51927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwWsN-0004pK-7I for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 16:59:23 -0500 Original-Received: by mail-pj1-f50.google.com with SMTP id gt5so10576397pjb.1 for <52293@debbugs.gnu.org>; Sun, 12 Dec 2021 13:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=lBsylRfhvu8e6ZBbCOV7J6OQ/qz/9/Qe8BAGqQt5wgw=; b=EFhkBjk1wNYh2B6WYD66GV4swcLygUiXT5HZmTPD/i1IsbSoj6mKbeVnLR0Qr5+0XW pRNINLTfIyJyYOCpCbWOPWuEnoDMcNVf2rjZAfzHpDO4Gu+XGSLrYcSAUNOV8RzL39Ci Fbry+rqJ2nHUA7CSDUoi8GLKxdi8v+84jcVh0tdqyJkKZnviasPONrhNck0ABQmZMF+e kY957f18orTbduwnwcnPLs14RX/Pn2ntmZOiFodcuBwvTqvuJEXMtuQ68fG6cPLuIf2F 8pN0KxQOZgwyN/s0/8l6o1h3DkBjQXSryT5voL4qk7YERLVXo0sDdyF1poMpzYExJV2m mtMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lBsylRfhvu8e6ZBbCOV7J6OQ/qz/9/Qe8BAGqQt5wgw=; b=yMW2vgA7iB5UL15eLI8EHKRscPMhZ9qC+C6fD0wuRr/wEV/i11/kC701JnDUXZUzhe OAwfozP98pLGlFJKpdlqhSBR5Ici0jlrZ+dlIX3Yq+aAKC8Ps3+2Ko68qbsE+wxnS/aW 2QSPpc6i4SfzEPFgs0gVrgE/d20wYomfmO7H5dVNHsnflfGm+/9JZlreYqP9RbM6wvPS 3lui7at3pSUBDEpgvOLSyBcD3jclcOh4g4OufvlWH7wj++rLiHWzPKypnFOxaANZ1CYY vE56J0KcIhJh2o/L2azNgDjeRlribB+sOcKYDpOgSYrlMI+Kq/R6P0YGvI3fqQ7g4zy3 BZnw== X-Gm-Message-State: AOAM530SgH96HVbpb84M1Pd5xo+eZjEKknCoaftG1JLW6c6hIgHlJG3b C+EJy59DyyAv27eiBJNxv84= X-Google-Smtp-Source: ABdhPJyet9sCF3Vi6NTQyJAepJ8JO7kELNvYm1aQvjaC2BUsbTxs0kcKSVDBeBY91w1nxsLfdncydg== X-Received: by 2002:a17:90b:2245:: with SMTP id hk5mr10047155pjb.41.1639346357357; Sun, 12 Dec 2021 13:59:17 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m6sm7973115pgs.18.2021.12.12.13.59.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 13:59:16 -0800 (PST) In-Reply-To: <83tufdmu4d.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222274 Archived-At: On 12/12/2021 12:43 PM, Eli Zaretskii wrote: >> Cc: 52293@debbugs.gnu.org, juri@linkov.net >> From: Jim Porter >> Date: Sun, 12 Dec 2021 12:27:34 -0800 >> >> On 12/11/2021 11:02 PM, Eli Zaretskii wrote: >>> Are you saying that we will be recommending a convention for separator >>> names only for menus popped up in context-menu-mode? Does it make >>> sense to have such a specialized convention? Isn't it possible to >>> show context menus outside of the context-menu-mode? >> >> No, I think this convention should be recommended for separators used >> anywhere in Emacs going forward. > > Ok, so then the effect of this change is wide, as I envisioned, and > compatibility considerations still apply. I'm also ok with applying this naming convention *only* to context menus and not treating this as a general guideline; that would still make it easier to remember the names of each context menu separator without having to double-check the source code. I don't even have a problem with closing that bug (bug#52286) as wontfix, since it's just a minor issue anyway. It's really not a big deal if the naming is inconsistent, so long as the names are still unique. I think this patch, which adds `top-separator' to help the de-duplication logic work better, would be useful to apply regardless of the decision on how the separators should be named.