From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wilhelm Kirschbaum Newsgroups: gmane.emacs.bugs Subject: bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently Date: Mon, 5 Feb 2024 19:47:02 +0200 Message-ID: References: <87y1ewgnn7.fsf@gmail.com> <9ae8eb33-fd8b-f8d6-dd7f-79f8d4464a51@gutov.dev> <87a5r2p4pq.fsf@gmail.com> <87bkbfkr1h.fsf@gmail.com> <22ea1559-f44e-933d-e60a-9caa62b376a8@gutov.dev> <878r69vow6.fsf@gmail.com> <95509dbc-7c71-4996-84f5-d37976e2661f@gutov.dev> <0d483c86-7e70-433c-8cea-15ac9238983c@gutov.dev> <627331b9-5759-43b1-a319-712c11ead2f6@gmail.com> <557bf51e-be4c-46c5-b2c5-8d06d28b7943@gmail.com> <2af6bb1e-8b14-4023-85a6-45dfba8be724@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13743"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Andrey Listopadov , 67246@debbugs.gnu.org To: Dmitry Gutov , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 05 18:48:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rX34d-0003Ja-GX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Feb 2024 18:48:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rX34V-0008FT-Kh; Mon, 05 Feb 2024 12:47:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rX34P-0008F6-CN for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2024 12:47:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rX34P-0001gj-4B for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2024 12:47:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rX34b-0000js-Of for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2024 12:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Wilhelm Kirschbaum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Feb 2024 17:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67246 X-GNU-PR-Package: emacs Original-Received: via spool by 67246-submit@debbugs.gnu.org id=B67246.17071552492801 (code B ref 67246); Mon, 05 Feb 2024 17:48:01 +0000 Original-Received: (at 67246) by debbugs.gnu.org; 5 Feb 2024 17:47:29 +0000 Original-Received: from localhost ([127.0.0.1]:52252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX345-0000j7-Gs for submit@debbugs.gnu.org; Mon, 05 Feb 2024 12:47:29 -0500 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:59455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX340-0000in-Jr for 67246@debbugs.gnu.org; Mon, 05 Feb 2024 12:47:28 -0500 Original-Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40fb63c40c0so41918115e9.2 for <67246@debbugs.gnu.org>; Mon, 05 Feb 2024 09:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707155226; x=1707760026; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HNMH762UymM9pkvQkENDC7aT8uUhgiINcn3wTLqrD4o=; b=XAGm8y6a1NXuUjIrhvUjxzSyAdhh2ZHUgwjAqOy21szmK23u7cu6Aldxwc00Zpgciv IG/1Du8OJ0f4//aUvPoZolcbfeItlDI0s5VoYNDShx6BWYMQ2a2KHrV1jctR1oNkolYl eTcKu9wkNyE0otAWRMFau8d+ua0tBF19hzSWEaUuE9t2OW9DTCZEhJrbN6fzQ7CMXBRH TFese7yjVWLPJcGCd+6xE7r1BkFtOEBF+S5vZFAqOdS1YNRgw2T1eeDuOnKxWTi3pOog 3B0DZq4S+rSKdlNxodQA1Ie75YeYbNHIMvG8ClQPK+9WoLOZ32bDxn6BcXTER81QKwQI UaYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707155226; x=1707760026; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HNMH762UymM9pkvQkENDC7aT8uUhgiINcn3wTLqrD4o=; b=E2pRRchU4FIR3qxHPZCJOK/CwTx7jNaPKRABPJ74j2DLXLJNYAXvMuYntWRs1hV0Au kYifErFzo5FN4Yf1jUTDsW9Lbv1drz7MdulxgRCNi4LHImMeximXQxE98q/4aQ6lsB5K ruSGf62F0gN6An9JTybyT6Nmx8seM052z9vTm87vAgxz4d6PvQV82ieKvOeojoSBrh4d 7XXfT1JYmcb/RB1OgC76fgeuT4y8PpcwLrNiCSKqDVYf9wAdm0wIhSkgACRM6PvieNUB oq33cNPvysAfMyvOXyJltU8OVtALvGrTaG1EIbHyIoCWTt6bGiuXAz91AVuKKFjY/doP zWCw== X-Gm-Message-State: AOJu0YyExeHdPeLVdj+oTVOVqSOHTMzx6jFkFwrgaRoJHGGZ/T0G5oKK snIMESttlcroWJod6XO6+SQnXRohx449UsY6HUS4YUkU4mKyx5Pl X-Google-Smtp-Source: AGHT+IElxdt8BWUYO74TVIKiQT1y4TUwDwcmwAFeV9BC1NOJUglImQZP97pRlM2EUKwVuBEIxytQ7A== X-Received: by 2002:a05:600c:1c0a:b0:40e:490f:3f31 with SMTP id j10-20020a05600c1c0a00b0040e490f3f31mr388822wms.35.1707155225847; Mon, 05 Feb 2024 09:47:05 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXI+fwCv3S3VxdLzofDnA5Fcv/xWsJbfr7vC7isckqFM0tZSK6lePVIqr9TSZ2br2IyTZx1iPA0t4VyHxenkKhulRlYdmdEtt9CbtsrRY9SIfe0WQyE9bL27uVMDo4= Original-Received: from [192.168.88.31] ([102.135.241.76]) by smtp.gmail.com with ESMTPSA id g7-20020a05600c4ec700b0040fb0193565sm9157883wmq.29.2024.02.05.09.47.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Feb 2024 09:47:05 -0800 (PST) Content-Language: en-US In-Reply-To: <2af6bb1e-8b14-4023-85a6-45dfba8be724@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279461 Archived-At: On 2024/02/05 19:42, Dmitry Gutov wrote: > On 05/02/2024 19:34, Wilhelm Kirschbaum wrote: >> >> Adding this as the first item to :feature 'elixir-definition fixes >> the function-call/name issue: >> >> @@ -360,13 +360,19 @@ elixir-ts--indent-rules >>   (defvar elixir-ts--font-lock-settings >>     (treesit-font-lock-rules >>      :language 'elixir >> -   :feature 'elixir-function-name >> +   :feature 'elixir-definition >>      `((call target: (identifier) @target-identifier >> +           (arguments >> +            (call target: (identifier) @font-lock-function-name-face >> +                  (arguments))) >> +           (:match ,elixir-ts--definition-keywords-re >> @target-identifier)) >> +     (call target: (identifier) @target-identifier >>              (arguments (identifier) @font-lock-function-name-face) >> >> I will be working in Elixir this week and will set different fonts >> for to test it during the week, but don't think it should hold up >> installing the suggested patch so long. > > Thanks! > > Could you give an example of problematic highlighting, though? So I > can keep it mind when installing both changes. Of course, sorry: def boo(:one), do: :boo highlighted boo as function-call-face, not function-name-face. Same with def foo("boo") do end and variants.