From: Dmitry Gutov <dgutov@yandex.ru>
To: Eason Huang <aqua0210@foxmail.com>, 55396@debbugs.gnu.org
Subject: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules
Date: Mon, 13 Jun 2022 01:17:28 +0300 [thread overview]
Message-ID: <e761337c-782c-9df3-ea34-a349a519ae0a@yandex.ru> (raw)
In-Reply-To: <tencent_2EEF65A0E403496E830BBC63CD65D353CE05@qq.com>
Hi again, sorry for the delay.
On 13.05.2022 15:56, Eason Huang wrote:
> And I try to start emacs with `emacs -q`, set `(setq debug-on-errort)`.
> Then reproduce the issue, will get the following debug error:
>
> Debugger entered--Lisp error: (excessive-variable-binding)
> call-process("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" "-o" "--exclude-standard")
> process-file("git" nil (t nil) nil "--no-pager" "ls-files" "-z" "-c" "-o" "--exclude-standard")
> vc-git--call((t nil) "ls-files" "-z" "-c" "-o" "--exclude-standard")
> vc-git--out-ok("ls-files" "-z" "-c" "-o" "--exclude-standard")
> vc-git--run-command-string(nil "ls-files" "-z" "-c" "-o" "--exclude-standard")
> project--vc-list-files("/Users/eason/.emacs.d/lib/aggressive-indent" Git nil)
> #f(compiled-function (module) #<bytecode 0xfc6c01609385f70>)("lib/aggressive-indent")
> project--vc-list-files("/Users/eason/.emacs.d/." Git nil)
> #f(compiled-function (module) #<bytecode 0xfc6c01609385f70>)(".")
> project--vc-list-files("/Users/eason/.emacs.d/." Git nil)
> #f(compiled-function (module) #<bytecode 0xfc6c01609385f70>)(".")
> project--vc-list-files("/Users/eason/.emacs.d/." Git nil)
> #f(compiled-function (module) #<bytecode 0xfc6c01609385f70>)(".")
> project--vc-list-files("/Users/eason/.emacs.d/." Git nil)
Looking at the backtrace again, it seems the problem is not related to
the number of submodules. It's a plain infloop.
Could you try to help with debugging? Alternatively, you could provide a
simple repo with this problem that doesn't require Borg to initialize.
Though it probably doesn't (shouldn't) require Borg anyway, given how
the problem looks.
What does project--vc-list-files do in your case? It calls 'git
ls-files' to fetch the list of files in the parent repo, then parses the
list of submodules in it, and repeats the same call inside each
submodule (using (concat default-directory module) as target).
Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over and
over again. So it seems like (project--git-submodules) returns a list
which has "." as one of its elements.
How does that happen? Do you have a submodule entry which points to "."?
next prev parent reply other threads:[~2022-06-12 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 12:56 bug#55396: 29.0.50; project-find-file don't work on a project with many submodules Eason Huang
2022-05-15 1:48 ` Dmitry Gutov
2022-05-15 4:09 ` Eason Huang
2022-06-12 22:17 ` Dmitry Gutov [this message]
2022-06-13 15:00 ` Eason Huang
2022-06-14 1:03 ` Dmitry Gutov
2022-06-14 11:22 ` Eason Huang
2022-06-14 12:47 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e761337c-782c-9df3-ea34-a349a519ae0a@yandex.ru \
--to=dgutov@yandex.ru \
--cc=55396@debbugs.gnu.org \
--cc=aqua0210@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).