From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#19854: 25.0.50; completion-extra-properties in emacs-25 Date: Mon, 27 Jun 2016 04:28:48 +0300 Message-ID: References: <87h9updcci.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1467009291 6858 80.91.229.3 (27 Jun 2016 06:34:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Jun 2016 06:34:51 +0000 (UTC) Cc: Thierry Volpiatto To: Noam Postavsky , 19854@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 27 03:29:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bHLMP-0004vg-LU for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Jun 2016 03:29:13 +0200 Original-Received: from localhost ([::1]:55831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHLMO-0007xL-K5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jun 2016 21:29:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHLMI-0007xC-Eh for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2016 21:29:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHLME-0002AW-8E for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2016 21:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHLME-0002AS-4l for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2016 21:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bHLMD-0003PG-R4 for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2016 21:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2016 01:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19854-submit@debbugs.gnu.org id=B19854.146699093713083 (code B ref 19854); Mon, 27 Jun 2016 01:29:01 +0000 Original-Received: (at 19854) by debbugs.gnu.org; 27 Jun 2016 01:28:57 +0000 Original-Received: from localhost ([127.0.0.1]:57191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHLM9-0003Ox-IZ for submit@debbugs.gnu.org; Sun, 26 Jun 2016 21:28:57 -0400 Original-Received: from mail-wm0-f48.google.com ([74.125.82.48]:38087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHLM8-0003Oj-90 for 19854@debbugs.gnu.org; Sun, 26 Jun 2016 21:28:56 -0400 Original-Received: by mail-wm0-f48.google.com with SMTP id r201so93970943wme.1 for <19854@debbugs.gnu.org>; Sun, 26 Jun 2016 18:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=Ppi9f8LdcM6ztkyb2xHEcTafFH7sEXIArKzaQesUYXI=; b=wnhYC2XLzKYa16mEim9v4FDZMrkQtd9cQCopWcje2bRjSCugFPS6Y1k2wg6w/x5FK/ 0K0dVqqtDRt/H7F9W53J1hYBTWp1/kCmaZxZZaLloJD52zQv65TYyO+tdTyLOMi+0AsI 4vT8aRHbCcTrIsC4LctbhzTrRzf02kcY1qP3loXyZWK/ffa60VGmIdcmOA0yGftbvaaN GPrEqYycGGQRbIVmm8SVVyiAyqJsrKRxZN+zwyMHQAJ+xhyLHxTVgjP7qj3DmdHRboDQ ePB7pw0A3Y/FGm0fxfxmheMWiAszIciSDoX22cap8NFu1POgQXwyNMslnol4VqMaIxQK TH7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Ppi9f8LdcM6ztkyb2xHEcTafFH7sEXIArKzaQesUYXI=; b=mUe9+g+fGIALER7AiCSI24D0WbL74FmhoWoW2KFhrL+/F+hsWfrFqdyJI33UGSwcXY FYnkkevewPvzfrHOQ9E5+zS8/71O1ZewW+M6MqgACcGW+gKdpjBYykfGntcQxVDT/DSX Hjw+y5eeZq86vXS5oh0xYgMSBporhMuaexuKYU9p9sM709nRem/ZR2T427HURd/WGWE1 TIGp2gXGyXarwchVVAtfbxK89sbapCqq9uPz6L7ukWLEqMBh6pPFO1jP/GHwhkUgYm70 JGNjJlofpzHrt6YwdDIXsQtuUwJ3h9s3vaV4lm6Wm9r5ux46emw5JOAlOKD9zRn7dlRX +sUg== X-Gm-Message-State: ALyK8tL4h30fD/buaxRdXqXnIkfI2Q3tgAl25vQIrHWF1cutL3cgj5h2C3kbXfnQ6kVaHg== X-Received: by 10.28.0.130 with SMTP id 124mr8177914wma.23.1466990930628; Sun, 26 Jun 2016 18:28:50 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id bh7sm1297969wjb.22.2016.06.26.18.28.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jun 2016 18:28:49 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120125 On 06/25/2016 11:38 PM, Noam Postavsky wrote: > Does this look okay? Looks fine to me, thanks. > (defun elisp-completion-at-point () > "Function used for `completion-at-point-functions' in `emacs-lisp-mode'. > The returned completions depend on whether point is in a function > or variable position; To be thorough, though, AFAIK "function position" means something specific to a Lisp programmer: the first element of a list. Whereas we also look at whether the whole form is quoted (and if so, offer all kinds of symbols as completions anyway), and we can also offer function-only completions in a non-function position if the function position contains one of the known macros (such as cl-callf or declare-function).