From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Sun, 29 Aug 2021 01:19:21 +0300 Message-ID: References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> <877dgoutmz.fsf@gnus.org> <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> <87y28nbky4.fsf@linkov.net> <87o89ieruy.fsf@mail.linkov.net> <87a6l2d5kd.fsf@gmx.net> <87ilzpk3qi.fsf@gnus.org> <877dg5fuak.fsf@gmx.net> <87a6l1in9c.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12814"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Cc: Juri Linkov , Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Lars Ingebrigtsen , Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 29 00:20:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mK6gP-00037s-SS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Aug 2021 00:20:13 +0200 Original-Received: from localhost ([::1]:39228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mK6gO-000471-Dn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Aug 2021 18:20:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mK6gE-00046s-D0 for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 18:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mK6gE-0007nm-5S for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 18:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mK6gE-0002BT-0U for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 18:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Aug 2021 22:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.16301891768357 (code B ref 39452); Sat, 28 Aug 2021 22:20:01 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 28 Aug 2021 22:19:36 +0000 Original-Received: from localhost ([127.0.0.1]:55141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK6fn-0002Ai-Ma for submit@debbugs.gnu.org; Sat, 28 Aug 2021 18:19:35 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:43930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK6fi-0002AP-0e for 39452@debbugs.gnu.org; Sat, 28 Aug 2021 18:19:34 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id b6so16272731wrh.10 for <39452@debbugs.gnu.org>; Sat, 28 Aug 2021 15:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wWIE6y6KUY6BVXV1a5EpKrqjKuTMf0oZpKC2ta6ShQo=; b=GJZUK2B992M2vrBlwH7Dkd2yV+KjWsaYSVYovczbWOsat1o6E/t7qOptpZhjl8OduK J7TiZixmKeSRv/z7VG1SIwltEOjDQQmTYFsWDyY0YOhFNawAPquo47MbO8y2d8GPNfGP MKCK7eqpmgKnFoOSvBDT4/IBCNM9cey+MipzOYfWj1BPGjgVy57tvVPlLIuJ4mCKYPrP aSjCDULKCxDEtYQen+o5M9wykhYMx+qz21pAcgO5KQTV0Xa0yPD8XUYbYMUHDEqcCs/i 43+LwY0isK9phw2x3Cy8214Y7ImTM4Z/sGoCxLzCef/YBF+6vfk7OTzsx0n5CyArrntM 6y0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wWIE6y6KUY6BVXV1a5EpKrqjKuTMf0oZpKC2ta6ShQo=; b=IpdnCPX6mhhxscDqfGbruvDeaeUu3rlPJRXKxc4ZwyMFHf1GwcWFe00SJbXjPzGb8b 3XckxZi9GuoonsDEuJikTKKJ3l/Ltrr8P8NlqU+tPVW6U/bNVFRIklg6xEcGDUFapAoL E6ggRAHprPVcf9wxKz9OnW0LwMQSk5cnal0JC4WN6BENf752TSdFEg4dPWzgpmFwRwo9 8Bl3HigKhMqDPOp9eYUo23iux4ahCOwqBC+T7Es2oGFdGXl2Q0VF6YBfBWargrJEkpAz Mvs1tc3gK8G2/2jHkcaQ+pY+j+K1sWrfflkJp8CFKKP8qhT9rhHcBZ3XyTocAUez3C6T G8gA== X-Gm-Message-State: AOAM530W6xIO1ADyIooTFDoEcypOVgFkgCfzD0UPaAIBpp10gMdyY9tr RZeEEyRsBTL7CFANe7eAe2U= X-Google-Smtp-Source: ABdhPJwUo6LpmyyxyIT4N/QeB6oyYek4Yi2FlnUBB/N33QADmjiKuphVjMXAuIEVkljRqcCoZaK6qg== X-Received: by 2002:a5d:47a4:: with SMTP id 4mr17552211wrb.329.1630189164058; Sat, 28 Aug 2021 15:19:24 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h11sm17801585wmc.23.2021.08.28.15.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Aug 2021 15:19:23 -0700 (PDT) In-Reply-To: <87a6l1in9c.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212902 Archived-At: On 28.08.2021 18:48, Lars Ingebrigtsen wrote: > Stephen Berman writes: > >> But I don't see at first glance why the unexpanded file name >> in the latter worked prior to the literal-pathspecs change but not >> afterwards. > > Isn't that what that change does -- make git interpret paths literally? > (So that you can have file names like "~" and "*" in your repo.) Yes and no: Git never received file names starting with "~" anyway - because vc-do-command converted all file names to relative ones. But a file name starting with ":(literal)..." is not something recognized by Emacs, so file-relative-name doesn't work anymore. If instead of altering file names we switch to the --literal-pathnames argument, this problem should go away. But we will return to the original concern that "the way git implements it, which is by setting an environment variable: it affects all subprocesses git calls, including git-hook scripts which tends to trip people up" (quoting Noam).