From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#64391: buffer narrowing slowdown regression in emacs 29 Date: Fri, 07 Jul 2023 10:31:01 +0000 Message-ID: References: <87r0psb51z.fsf@ust.hk> <0AD15A09-F669-48C0-AF5C-971D52F5BF8E@gmail.com> <83v8f3q1ff.fsf@gnu.org> <50A46AAC-2089-45CB-A355-CCB2B4EA8D76@gmail.com> <5995c9ed6a0b39c3070c@heytings.org> <83a5wak1tr.fsf@gnu.org> <26cee506f708f3c6cfe1@heytings.org> <26cee506f70bbc9de58b@heytings.org> <83h6qghpdc.fsf@gnu.org> <26cee506f77e9c87e325@heytings.org> <83v8ewf2b4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36730"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 12:32:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHil5-0009Il-A9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 12:32:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHikt-00077R-Pq; Fri, 07 Jul 2023 06:32:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHiks-00077A-0t for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 06:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHikr-0002Uu-Or for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 06:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHikr-0005gN-K4; Fri, 07 Jul 2023 06:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 07 Jul 2023 10:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64391 X-GNU-PR-Package: emacs,gnus X-Debbugs-Original-Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca, bugs@gnus.org Original-Received: via spool by 64391-submit@debbugs.gnu.org id=B64391.168872586821763 (code B ref 64391); Fri, 07 Jul 2023 10:32:01 +0000 Original-Received: (at 64391) by debbugs.gnu.org; 7 Jul 2023 10:31:08 +0000 Original-Received: from localhost ([127.0.0.1]:42614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHijz-0005ew-VV for submit@debbugs.gnu.org; Fri, 07 Jul 2023 06:31:08 -0400 Original-Received: from heytings.org ([95.142.160.155]:44364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHiju-0005ei-PM for 64391@debbugs.gnu.org; Fri, 07 Jul 2023 06:31:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1688725862; bh=w+UqkGudODyBIx/jcoEf5zRvbvi4oHgmGu2gpXCV2ec=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=ifePBLA0/8cdQIusCvL4wsRLBKT8Fo2H7YU/6jzsATHNUUD+y+u/gCV8g6yvImvT+ m90hA0vZ/x7r7yjZ8rB+r1Xr8k+27Rk1S2mq0ArcoCnTwSKxd4uOvyK58GwYuacths ELBl2iJbsy1TyhVIBJYYkhFsZL2QhFdiOrJ+9THeIFPvWyoZ6aBzOjQcVHZK5tce6v tpF8kddru8UfrtJ9UnMrzd+gDXEg59XtfAXmVX776LXtyxXKLbwW86KIkH1s7cyeLP XtXcJ9vNPtx/3XkS9+pJUMpGK930Bl0l04D0HnlFFd3Zu+uGzV41idtqw8eK3LFn9H n62D9Lm0zyHRA== In-Reply-To: <83v8ewf2b4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264714 Archived-At: >>> I have one question about the new `with-restriction` macro: if it is >>> intended as a convenience macro for unlabelled narrowing as well, >>> shouldn't it then expand to the obvious >>> >>> (save-restriction >>> (narrow-to-region BEG END) >>> BODY) >>> >>> instead the much more expensive call to a helper function? >> >> Yes. In fact now that we have a separate function for the labeled >> case, we can remove the funcall in both cases. Patch attached. > > You are killing me. > ??? That wasn't meant for the release branch.