From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Date: Tue, 8 Nov 2022 08:52:10 -0800 Message-ID: References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> <83edudxywx.fsf@gnu.org> <874jv9h3ci.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25909"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58909@debbugs.gnu.org To: Robert Pluim , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 08 17:53:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osRqh-0006dP-3L for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Nov 2022 17:53:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osRqU-0005cA-PN; Tue, 08 Nov 2022 11:53:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osRqR-0005Zo-D9 for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 11:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osRqQ-0003P9-4n for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 11:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osRqP-0005jj-OZ for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 11:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166792633821998 (code B ref 58909); Tue, 08 Nov 2022 16:53:01 +0000 Original-Received: (at 58909) by debbugs.gnu.org; 8 Nov 2022 16:52:18 +0000 Original-Received: from localhost ([127.0.0.1]:38070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osRph-0005ik-Tb for submit@debbugs.gnu.org; Tue, 08 Nov 2022 11:52:18 -0500 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:46761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osRpg-0005iX-6o for 58909@debbugs.gnu.org; Tue, 08 Nov 2022 11:52:16 -0500 Original-Received: by mail-pg1-f182.google.com with SMTP id 78so13863077pgb.13 for <58909@debbugs.gnu.org>; Tue, 08 Nov 2022 08:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=n93+/JZjMbQNgXIXXepNrY2DYiWqTKe5C7dkC5x5uD0=; b=NZqlffBVMTwQuAGOhfvFNWY0g+315JBYLrHfQ6eKLgGdABltrCzRdaH+ez8qryyEEe 2bT6QahTMtgMdnNLaZGhvHwySqlmW/12iO23yp30LbZwn0Hpn4KvdY42ns0esXYkW6bx MdMNAngZQ6JojOwhaU481NuVhr+9USq4FRxQDHD9jbKHxXnM3h+8cCVz0GZjHe+3LG58 rpVnk1ET2dxZrFDFaD/HooDYZ3qQN1jHbv9SIZywxy6L755enD/AS7rn8sJ5BgloK8EY tJMuaBYvjMxax8kel8WZaI1x3p8ZKwdVgmXFlPR6i33wMSydYlTI1T7WHU5dMsufhbON FsJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n93+/JZjMbQNgXIXXepNrY2DYiWqTKe5C7dkC5x5uD0=; b=RR0pPpSWdoA+SmRxYNrTm+0/hgFEB7GEpouyfj8p8J1KLuCTUdYs/f1v7dJB5Op4/G Fpqu6p9J69hdDYkumxxSpGN6PFgbYlIDtzdhqKHb5jMkJ9qXZj7ljTeL5rO56YPdJ/vM 6lGnVtTqhrCU4EwQ5OjPpLVxzNg5iUXaiC6dxuVkA1gOM3YYHKcrASmWO5gUIPQL1Ano dnV2nrgSjD4tB4/NXfkJq1T2a46ts4w7blgCPS+Hr4vFLL5fk9JlO4fpFBIXbeklctfh voH9dfLuDfHitsYMUG8w47y66Y4eTSJhdSlaClQS/clND8sOI9ZG6hkcpAKsaZx6scAO eGwQ== X-Gm-Message-State: ACrzQf2fOv0inY2bYKuIIPmtdgCnBhJ/PmnYvHmTMzg8299f4acquLUo vOJE3GYbuwUvVV2ou7zogGc= X-Google-Smtp-Source: AMsMyM5AxtCzorykhR/7g1QgUzZy/RCn1OvRe+zG9MYGb09TkzUENDb4Hd2eYIUCb1Fhqblq9iGDiQ== X-Received: by 2002:a63:5b1b:0:b0:46f:4b56:ecba with SMTP id p27-20020a635b1b000000b0046f4b56ecbamr1007967pgb.422.1667926330402; Tue, 08 Nov 2022 08:52:10 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o3-20020a170902d4c300b00186b55e3cd6sm7238967plg.133.2022.11.08.08.52.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 08:52:09 -0800 (PST) Content-Language: en-US In-Reply-To: <874jv9h3ci.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247346 Archived-At: On 11/8/2022 7:29 AM, Robert Pluim wrote: > OK. I donʼt see what benefit the *use* of the minor mode in this way > brings :-) The actual change that I'd like to merge is just to make the minor mode activate/deactivate consistently, whereas previously it would activate in some situations where you start the Emacs server, but not others. I'd classify that as "not working". Having the minor mode makes it easier for third-party code (user configs or packages) to define key bindings that are only active when the server is running. That's useful to me, since I don't *always* use the Emacs server. As for the change to how 'C-x C-c' is bound, I don't have any strong opinion on merging it. It's probably more risk than it's worth, and if we were to merge it, I'd prefer to do so after cutting the 29 branch, since then there'd be more time to find any bugs.[1] However, since the only real benefit is to clean up some dependencies in the code, I'm not sure it's worth the effort. [1] I'd also want to have regression tests for all of that.