From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#50256: thing-at-mouse Date: Sat, 4 Sep 2021 09:34:17 +0200 Message-ID: References: <87sfys6ubm.fsf@mail.linkov.net> <871r6a8ooe.fsf@gnus.org> <87y28i85xi.fsf@mail.linkov.net> <87k0k1o5ks.fsf@mail.linkov.net> <87ilzk6bsr.fsf@mail.linkov.net> <6dcf3191-dbb3-0c6c-2483-0fc05e9ff6e5@gmx.at> <83lf4gqyn9.fsf@gnu.org> <1a65f234-c1ee-ae95-aa05-2e3d9d1e1002@gmx.at> <8335qoqobm.fsf@gnu.org> <7c9cb0a1-b222-cb06-7e7c-7f17231faca3@gmx.at> <83pmtsp4g1.fsf@gnu.org> <831r67ph8d.fsf@gnu.org> <87tuj3bffb.fsf@gnus.org> <83y28fo1xf.fsf@gnu.org> <191e9cc6-7370-5b7d-7777-716b61e0155d@gmx.at> <83pmtrnydh.fsf@gnu.org> <158a8854-f56a-9aaa-3a14-d108e086a24c@gmx.at> <83k0jznms2.fsf@gnu.org> <87v93j9dfz.fsf@mail.linkov.net> <87y28e4ysv.fsf@mail.linkov.net> <83czpqzupp.fsf@gnu.org> <83v93hyl3l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27088"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50256@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 04 09:35:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMQDC-0006pT-CB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Sep 2021 09:35:38 +0200 Original-Received: from localhost ([::1]:50664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMQDB-00060z-6R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Sep 2021 03:35:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMQCe-0005NQ-1j for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2021 03:35:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMQCc-0000re-7B for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2021 03:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMQCc-00053r-3s for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2021 03:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Sep 2021 07:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50256 X-GNU-PR-Package: emacs Original-Received: via spool by 50256-submit@debbugs.gnu.org id=B50256.163074086819385 (code B ref 50256); Sat, 04 Sep 2021 07:35:02 +0000 Original-Received: (at 50256) by debbugs.gnu.org; 4 Sep 2021 07:34:28 +0000 Original-Received: from localhost ([127.0.0.1]:46413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMQC4-00052a-1y for submit@debbugs.gnu.org; Sat, 04 Sep 2021 03:34:28 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:35725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMQC1-00052J-Uc for 50256@debbugs.gnu.org; Sat, 04 Sep 2021 03:34:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1630740859; bh=L6foTvRNUIupZawHyvC4OeG2X6FSrU0+pVPtHsf9mFQ=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=NLiMqm6o7IMmyMrBVXKKe0sfIHZvs2CoTj7lYOofvhfPcL/w4FFABQ98cEZN/cN63 uMPmUWC6s5DTyuaerSA4dUTsZUOedGbxaeAt81N0fQy7Xn7lf25rYpob2WACpq2L6s rNQbfEdgyiVr18RAiaP9Hp+hTeVNlat8MOTwHnUk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.5.122]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MS3mt-1mWdhg00IF-00TW1N; Sat, 04 Sep 2021 09:34:19 +0200 In-Reply-To: <83v93hyl3l.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:83HESnNOdTymWz/aEEjelEezb9Ax6UBDZDzvtr3RgtNPBiozL8p WKdrVnRV6wsw327OBagM4zp7oqZJARY1dZLJHcPXXZPdG3Ajg7foigjaOV3o7lt4EN5YsEt vW+2NbmXWbl/fjlBtADjzva0IaJ/Ad4iDQ7WSnxqRyLHWWPwoVlJchr2AKT92qIztOFcLRg Pn3ALcta9s9BWfIzJELlQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:p83s9kRPfUU=:5WI8nVsXbPXWqs3W9SZhvT ApDv5K+zWYISQ7l4khF1X0LR4PwCOte6k7oei6ercGr6yzVX4JQO4ed5+L3gs/1rZvWT/t9OL G57hRQ2QQBxru2+fR15bBPFleZ8XZRudMyCFMxbpGdRflkpCkjRgV2oRyYamhkRD/GZlgM4I0 Gu5nR6cR0pAU+M8XZAnUMliQSsY8gp9ozWF//izr0ApBPuknJRsbgo+DstIFJKgWC7H0cn8k4 LKntUoDnbZ5eRvauwC1GFTAhUeMB0BA4yVN2H0ygxs3Jn8NkQE5iA6IiAz1HQGqBpwfD7UZM2 Q9q5UQsBWnRYBWOhkpcive83iUevIoeDa0ab1/AgdzV39AXaw9t3mTg5zwq8i1e2zezNSU7ii yj4srbS+86y8EBxszCOTDqm6CvdE83tDQzd1jwLw+h3ElokO1yx5dgZYwHfuys+UvpjaL530D TCAl2W9NTFx0XMGjdTRMvsEMXgGsdTicGq4/JUriDINT5j6uKW5Ph/IdXQh6VKPB/N8Upxu6w Y+GEPsyrSyj8Ox5rax2U/HdG+4tkJjJN7g04RbGr/SdPGCbMNHZZf/xnbkb8x0lNHSvD+p2Fl hVbip35W8vIuEpvr2/jTuzw2U5dltMqaR+sj3VSdUK6ou54v4eDsCf539/piph+ZiHYfmyZd6 XNR+uelra5mAUTGP5tSOsV5pUhyr0isklAuOhiGRObIrCCVzsLw0N6LFRbPnNbCkvSaqb0b78 63XowppKhHLY0MXO57brUZm4WK1BnZunqwoirz1yLhrS5/j8HLUoUt3/muCGmC4d32YrD0R6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213394 Archived-At: > Thanks. There's one more use case I can think of: when WINDOW is not > a selected one, but its buffer is also displayed in the selected > window, which could mean its point is different from WINDOW's point. You mean this would constitute a reasonable and legitimate scenario where we should use the current buffer's point via a nil argument as we do with the present code. It can be easily accommodated via diff --git a/src/window.c b/src/window.c index cb8fe5fcdb..9296b12499 100644 --- a/src/window.c +++ b/src/window.c @@ -2199,7 +2199,7 @@ DEFUN ("pos-visible-in-window-p", Fpos_visible_in_window_p, posint = -1; else if (!NILP (pos)) posint = fix_position (pos); - else if (w == XWINDOW (selected_window)) + else if (XBUFFER (w->contents) == current_buffer) posint = PT; else posint = marker_position (w->pointm); > Anyway, after thinking for some time about this, I concluded that the > only sane way forward, especially since we are going to cut the > emacs-28 branch soon, is to leave the default behavior of > pos-visible-in-window-p and posn-at-point as it is today, and add one > more optional argument to force the possible alternative behavior(s). > The proposed change to event-start and event-end are new code, so they > should have no trouble passing this new optional argument to > posn-at-point. There's no need doing that - these function could just pass an explicit POS argument instead of using nil. > That means to add an argument to pos-visible-in-window-p that would > cause it to select one of the following 3 alternatives: WINDOW's > point, WINDOW's buffer's point, and (in case WINDOW is the selected > window) the current buffer's point. The default should stay as it is > today: when WINDOW is the selected window, use the current buffer's > point. > > Anything else IMNSHO risks introducing many bugs into existing > well-tested code that we will never be able to discover and fix in > time for Emacs 28.1 release. Agreed. But the solution you propose appears pure overkill to me. Instead of adding another argument (and trying to explain its meaning) we should rather tell that using nil for POS is ambiguous and should be avoided because at the time this function is called, the current buffer and WINDOW's buffer might not be the same. Also, your proposed solution will not catch bugs in existing but no-so-well-tested code. To catch those it might reasonable to do: diff --git a/src/window.c b/src/window.c index cb8fe5fcdb..18ada851fe 100644 --- a/src/window.c +++ b/src/window.c @@ -2199,10 +2199,16 @@ DEFUN ("pos-visible-in-window-p", Fpos_visible_in_window_p, posint = -1; else if (!NILP (pos)) posint = fix_position (pos); - else if (w == XWINDOW (selected_window)) - posint = PT; else - posint = marker_position (w->pointm); + { + if (XBUFFER (w->contents) != current_buffer) + message ("`pos-visible-in-window' called with POS nil but WINDOW's buffer is not current"); + + if (w == XWINDOW (selected_window)) + posint = PT; + else + posint = marker_position (w->pointm); + } /* If position is above window start or outside buffer boundaries, or if window start is out of range, position is not visible. */ martin