From: Dmitry Gutov <dgutov@yandex.ru>
To: Ramesh Nedunchezian <rameshnedunchezian@outlook.com>,
61449@debbugs.gnu.org
Subject: bug#61449: 30.0.50; diff-hl-dired: Consider adding a cookie to diff-hl-dired overlay
Date: Sun, 19 Feb 2023 01:25:50 +0200 [thread overview]
Message-ID: <e5c4eb01-9b95-3571-b7ea-88ad3374b671@yandex.ru> (raw)
In-Reply-To: <TY2PR0101MB36938782BE73ADD6422B250CDADD9@TY2PR0101MB3693.apcprd01.prod.exchangelabs.com>
Hi again!
On 13/02/2023 13:19, Ramesh Nedunchezian wrote:
> - `diff-hl-dired-cookie` :: This is added by me, and contains the vc
> state.
> - `diff-hl` :: This is added by `diff-hl-dired`, and `t` isn't much
> useful for the task I have hand.
> - `before-string` :: This is added by `diff-hl-dired`, and the vc
> state is avaiable as a face property.
>
> If I have to get to that property, this is the kind of manoeuvre I
> need to do
>
> (->> x
> (memq 'before-string)
> cadr
> (get-text-property 0 'display)
> car
> (-filter 'facep)
> car)
>
> If you add a cookie, I can do whatever with it.
>
> Mind you ... I am not saying the relevant information is /not/ there;
> I am only saying that it is buried too deep, and not readily accessible.
Thank you for the extra clarification.
I've added a new overlay property 'diff-hl-dired-type' in
https://github.com/dgutov/diff-hl/commit/d20f16bf5eadd66e775f215e800f25caddae8cb5.
It the same as you asked, I think, except with a different name.
Due to the version bump, it should be out soon in diff-hl 1.9.2.
prev parent reply other threads:[~2023-02-18 23:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 5:32 bug#61449: 30.0.50; diff-hl-dired: Consider adding a cookie to diff-hl-dired overlay Ramesh Nedunchezian
[not found] ` <handler.61449.B.167618026110384.ack@debbugs.gnu.org>
2023-02-12 5:41 ` bug#61449: Acknowledgement (30.0.50; diff-hl-dired: Consider adding a cookie to diff-hl-dired overlay) Ramesh Nedunchezian
2023-02-12 6:34 ` bug#61449: 30.0.50; diff-hl-dired: Consider adding a cookie to diff-hl-dired overlay Ramesh Nedunchezian
2023-02-12 13:12 ` Dmitry Gutov
2023-02-13 11:32 ` Ramesh Nedunchezian
2023-02-12 13:12 ` Dmitry Gutov
2023-02-13 11:19 ` Ramesh Nedunchezian
2023-02-18 23:25 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5c4eb01-9b95-3571-b7ea-88ad3374b671@yandex.ru \
--to=dgutov@yandex.ru \
--cc=61449@debbugs.gnu.org \
--cc=rameshnedunchezian@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).