From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#32304: 27.0.50; tramp-tests issue with double slash Date: Sun, 29 Jul 2018 11:54:10 -0400 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------63616F0600BFB97CED3A1441" X-Trace: blaine.gmane.org 1532879590 18106 195.159.176.226 (29 Jul 2018 15:53:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jul 2018 15:53:10 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 To: 32304@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 29 17:53:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjo0G-0004az-Rc for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jul 2018 17:53:05 +0200 Original-Received: from localhost ([::1]:48827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjo2N-0007pa-F2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jul 2018 11:55:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjo2D-0007pG-LM for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 11:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjo2A-0001ck-Gv for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 11:55:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57222) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjo2A-0001ce-Cd for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 11:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fjo2A-00009P-5Z for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 11:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jul 2018 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32304 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1532879670529 (code B ref -1); Sun, 29 Jul 2018 15:55:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Jul 2018 15:54:30 +0000 Original-Received: from localhost ([127.0.0.1]:34007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjo1d-00008S-3E for submit@debbugs.gnu.org; Sun, 29 Jul 2018 11:54:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjo1b-00008A-0M for submit@debbugs.gnu.org; Sun, 29 Jul 2018 11:54:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjo1U-0001PS-QQ for submit@debbugs.gnu.org; Sun, 29 Jul 2018 11:54:21 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjo1U-0001PK-Lp for submit@debbugs.gnu.org; Sun, 29 Jul 2018 11:54:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjo1T-0007lY-Cj for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 11:54:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjo1Q-0001Od-AU for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 11:54:19 -0400 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:33442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjo1Q-0001OE-42 for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 11:54:16 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6TFsDEI028242 for ; Sun, 29 Jul 2018 11:54:13 -0400 Original-Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6TFsCoq007320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sun, 29 Jul 2018 11:54:13 -0400 Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149051 Archived-At: This is a multi-part message in MIME format. --------------63616F0600BFB97CED3A1441 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit The following parts of tramp-test04-substitute-in-file-name are failing on Cygwin (and probably also on MS-Windows, but I can't easily test that): (should (string-equal (substitute-in-file-name "/method:host://foo") "/method:host:/foo")) (should (string-equal (substitute-in-file-name "/method:host:/path///foo") "/foo")) (should (string-equal (substitute-in-file-name "/method:host://~foo") "/~foo")) Here are the corresponding evaluations: (substitute-in-file-name "/method:host://foo") "/method:host://foo" (substitute-in-file-name "/method:host:/path///foo") "//foo" (substitute-in-file-name "/method:host://~foo") "//~foo" This is a consequence of the fact that Tramp calls substitute-in-file-name on the local part of the file name: (substitute-in-file-name "//foo") "//foo" (substitute-in-file-name "/path///foo") "//foo" (substitute-in-file-name "//~foo") "//~foo" "//" has a special meaning at the beginning of a file name on Cygwin and MS-Windows; see the comment near the beginning of search_embedded_absfilename. So I don't think there's a real bug here. Maybe the expected result of the test should simply be adjusted, as in the attached patch. Someone who builds on MS-Windows would have to check this. Ken --------------63616F0600BFB97CED3A1441 Content-Type: text/plain; charset=UTF-8; name="0001-Adjust-expected-results-on-a-tramp-test.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Adjust-expected-results-on-a-tramp-test.patch" RnJvbSAzMjg3NjZlMDIxNDVmY2ZjZGQ1NGMxMjRmZjg2NmNlOGYyZTE1ZDU5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGticm93bkBjb3JuZWxsLmVkdT4K RGF0ZTogU3VuLCAyOSBKdWwgMjAxOCAxMTo0NToyNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hd IEFkanVzdCBleHBlY3RlZCByZXN1bHRzIG9uIGEgdHJhbXAgdGVzdAoKKiB0ZXN0L2xpc3Av bmV0L3RyYW1wLXRlc3RzLmVsCih0cmFtcC10ZXN0MDQtc3Vic3RpdHV0ZS1pbi1maWxlLW5h bWUpOiBBZGp1c3QgdGhlIGV4cGVjdGVkCnJlc3VsdHMgb24gQ3lnd2luIGFuZCBNUy1XaW5k b3dzLCB3aGVyZSAiLy8iIGF0IHRoZSBiZWdpbm5pbmcKb2YgYSBmaWxlIG5hbWUgaGFzIGEg c3BlY2lhbCBtZWFuaW5nLiAgKEJ1ZyM5OTk5OSkKLS0tCiB0ZXN0L2xpc3AvbmV0L3RyYW1w LXRlc3RzLmVsIHwgMTUgKysrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTIgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvbmV0 L3RyYW1wLXRlc3RzLmVsIGIvdGVzdC9saXNwL25ldC90cmFtcC10ZXN0cy5lbAppbmRleCA1 YzVlZmY4Nzk4Li5hMjlkZjE2ODJjIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvbmV0L3RyYW1w LXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9uZXQvdHJhbXAtdGVzdHMuZWwKQEAgLTE3ODEs OSArMTc4MSwxNSBAQCB0cmFtcC0tdGVzdC1wcmludC1kdXJhdGlvbgogICAoc2hvdWxkIChz dHJpbmctZXF1YWwgKHN1YnN0aXR1dGUtaW4tZmlsZS1uYW1lICIvbWV0aG9kOmhvc3Q6Ly8v Zm9vIikgIi9mb28iKSkKICAgKHNob3VsZAogICAgKHN0cmluZy1lcXVhbAotICAgIChzdWJz dGl0dXRlLWluLWZpbGUtbmFtZSAiL21ldGhvZDpob3N0Oi8vZm9vIikgIi9tZXRob2Q6aG9z dDovZm9vIikpCisgICAgKHN1YnN0aXR1dGUtaW4tZmlsZS1uYW1lICIvbWV0aG9kOmhvc3Q6 Ly9mb28iKQorICAgIChpZiAobWVtcSBzeXN0ZW0tdHlwZSAnKGN5Z3dpbiB3aW5kb3dzLW50 KSkKKyAgICAgICAgIi9tZXRob2Q6aG9zdDovL2ZvbyIKKyAgICAgICIvbWV0aG9kOmhvc3Q6 L2ZvbyIpKSkKICAgKHNob3VsZAotICAgKHN0cmluZy1lcXVhbCAoc3Vic3RpdHV0ZS1pbi1m aWxlLW5hbWUgIi9tZXRob2Q6aG9zdDovcGF0aC8vL2ZvbyIpICIvZm9vIikpCisgICAoc3Ry aW5nLWVxdWFsIChzdWJzdGl0dXRlLWluLWZpbGUtbmFtZSAiL21ldGhvZDpob3N0Oi9wYXRo Ly8vZm9vIikKKyAgICAgICAgICAgICAgICAgKGlmIChtZW1xIHN5c3RlbS10eXBlICcoY3ln d2luIHdpbmRvd3MtbnQpKQorICAgICAgICAgICAgICAgICAgICAgIi8vZm9vIgorICAgICAg ICAgICAgICAgICAgICIvZm9vIikpKQogICAoc2hvdWxkCiAgICAoc3RyaW5nLWVxdWFsCiAg ICAgKHN1YnN0aXR1dGUtaW4tZmlsZS1uYW1lICIvbWV0aG9kOmhvc3Q6L3BhdGgvL2ZvbyIp ICIvbWV0aG9kOmhvc3Q6L2ZvbyIpKQpAQCAtMTgwNCw3ICsxODEwLDEwIEBAIHRyYW1wLS10 ZXN0LXByaW50LWR1cmF0aW9uCiAgICAgIi9tZXRob2Q6aG9zdDovOi9wYXRoLy9mb28iKSkK IAogICAoc2hvdWxkCi0gICAoc3RyaW5nLWVxdWFsIChzdWJzdGl0dXRlLWluLWZpbGUtbmFt ZSAiL21ldGhvZDpob3N0Oi8vfmZvbyIpICIvfmZvbyIpKQorICAgKHN0cmluZy1lcXVhbCAo c3Vic3RpdHV0ZS1pbi1maWxlLW5hbWUgIi9tZXRob2Q6aG9zdDovL35mb28iKQorICAgICAg ICAgICAgICAgICAoaWYgKG1lbXEgc3lzdGVtLXR5cGUgJyhjeWd3aW4gd2luZG93cy1udCkp CisgICAgICAgICAgICAgICAgICAgICAiLy9+Zm9vIgorICAgICAgICAgICAgICAgICAgICIv fmZvbyIpKSkKICAgKHNob3VsZAogICAgKHN0cmluZy1lcXVhbAogICAgIChzdWJzdGl0dXRl LWluLWZpbGUtbmFtZSAiL21ldGhvZDpob3N0Oi9+Zm9vIikgIi9tZXRob2Q6aG9zdDovfmZv byIpKQotLSAKMi4xNy4wCgo= --------------63616F0600BFB97CED3A1441--