From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#61954: 30.0.50; [PATCH] Simplify structured commands in Eshell Date: Thu, 16 Mar 2023 22:33:09 -0700 Message-ID: References: <0a0527e8-b005-6f1a-016a-1cb0694ce639@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24808"; mail-complaints-to="usenet@ciao.gmane.io" To: 61954-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 17 14:17:59 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd9y3-0006GJ-1Z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Mar 2023 14:17:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd9xt-0006zn-JK; Fri, 17 Mar 2023 09:17:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd2j5-0000LG-Kx for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 01:34:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pd2j4-00026N-Lh for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 01:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pd2j4-000353-CN for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 01:34:02 -0400 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2023 05:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 61954@debbugs.gnu.org, jporterbugs@gmail.com, jporterbugs@gmail.com Original-Received: via spool by 61954-done@debbugs.gnu.org id=D61954.167903119811765 (code D ref 61954); Fri, 17 Mar 2023 05:34:02 +0000 Original-Received: (at 61954-done) by debbugs.gnu.org; 17 Mar 2023 05:33:18 +0000 Original-Received: from localhost ([127.0.0.1]:43462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd2iM-00033h-76 for submit@debbugs.gnu.org; Fri, 17 Mar 2023 01:33:18 -0400 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:54244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd2iK-00033P-MU for 61954-done@debbugs.gnu.org; Fri, 17 Mar 2023 01:33:17 -0400 Original-Received: by mail-pj1-f47.google.com with SMTP id y2so3971291pjg.3 for <61954-done@debbugs.gnu.org>; Thu, 16 Mar 2023 22:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679031191; h=content-transfer-encoding:in-reply-to:references:newsgroups:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=PLlpC3LboYgTXPhEhtV2Td3KZn3fFvL06GoibgWoCR4=; b=p/az8IO26tkJFOV8HGTLzsuO/H+kNQkUT+fPhiE4X5msdTSjI1B7sGDlNCqKv+T0mv nqXf59mo88rDz7ogg80k11clVtt6f8R/5NmT9WxsqUe2fi0JvgG7jMMXhg4xr4HB0LAF FIYrYGu7btw+5oj2i1LDGJjpBZSYwZ0VIfOhIACADQ2FO6IID7+cBWoWqtSTCP0st4iS 2NwH2sG+WekPN5GnCq2KtcsCTX/aAqisa+ZRCvQyNK2WL5qcxeKe/gO3Qm8Ku27YbAsH AJRlV5r3gizYZ0L819jNmsUejqgC18pQ8o6atuippn8xuSEVuXBika97qq0Rwz4R8Bh9 2enw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679031191; h=content-transfer-encoding:in-reply-to:references:newsgroups:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PLlpC3LboYgTXPhEhtV2Td3KZn3fFvL06GoibgWoCR4=; b=aCjwV/VpBfZcEb5JIFGmn/xbRQ8Q+txzujch6pa72j/q4LoAaZFeyKK7jV8WnOzXNC 2EpEDCm4o57/jgv6f1K/9pHPmpweI7JCpf4KSN5OysBkRKZcZawSQcO6uiwqWMTvDSvJ 91X4sFn7KSAcg/PPFHjGTH4+YeIwMMeWo12hCuzHdGfgVO5rjdu0kMwP4/6gJi6XH84w 10BgkEwMnUoICSAy3b+/XTr3HmcYDWdJO08W4QW3emm5/cHoKWtH1vDEcRdaHYou2RFU uGwAjTkpdinXDECNMbBeAGb+rp+sURDz/tv+LPBA9I294HHHB4eDcatThi1EHqb4DRIJ 1UXg== X-Gm-Message-State: AO0yUKWerUo4oyg2X8NmvWa4qTwbOSh0KR8mA2ExLMayjeaDGGYmnrPR PZzEGfrwmjNH78cDmtxB8dXon8flb2M= X-Google-Smtp-Source: AK7set8Nbspfw+22Idp3Eg6UIkcdl7lwGJnvff3qlcnLIVmZUii9mjTxJFy+P43TSe/kl+TX7crBJQ== X-Received: by 2002:a17:90b:4f4b:b0:238:e9:8994 with SMTP id pj11-20020a17090b4f4b00b0023800e98994mr7098761pjb.0.1679031190752; Thu, 16 Mar 2023 22:33:10 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g2-20020a17090adac200b00233cde36909sm4089667pjx.21.2023.03.16.22.33.10 for <61954-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 22:33:10 -0700 (PDT) Content-Language: en-US Original-Newsgroups: gmane.emacs.bugs In-Reply-To: <0a0527e8-b005-6f1a-016a-1cb0694ce639@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Fri, 17 Mar 2023 09:17:49 -0400 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258078 Archived-At: On 3/3/2023 11:28 PM, Jim Porter wrote: > Structured commands are just Eshell flow control commands, like 'if' and > 'while'. These expected you to set 'eshell-test-body' and > 'eshell-command-body' when implementing them, and were very hard to get > right (see bug#12571 for example). > > Instead, let's improve Eshell's iterative command evaluation some more > so that you can write the implementations for these commands like > normal. Since there haven't been any concerns about the patches themselves in the last two weeks-ish, merging this now as 1565dbcae3 and closing the bug.