From: Jim Porter <jporterbugs@gmail.com>
To: 61954-done@debbugs.gnu.org
Subject: bug#61954: 30.0.50; [PATCH] Simplify structured commands in Eshell
Date: Thu, 16 Mar 2023 22:33:09 -0700 [thread overview]
Message-ID: <e5000fd2-350a-eaea-c787-0551aa30ac23@gmail.com> (raw)
In-Reply-To: <0a0527e8-b005-6f1a-016a-1cb0694ce639@gmail.com>
On 3/3/2023 11:28 PM, Jim Porter wrote:
> Structured commands are just Eshell flow control commands, like 'if' and
> 'while'. These expected you to set 'eshell-test-body' and
> 'eshell-command-body' when implementing them, and were very hard to get
> right (see bug#12571 for example).
>
> Instead, let's improve Eshell's iterative command evaluation some more
> so that you can write the implementations for these commands like
> normal.
Since there haven't been any concerns about the patches themselves in
the last two weeks-ish, merging this now as 1565dbcae3 and closing the bug.
prev parent reply other threads:[~2023-03-17 5:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 7:28 bug#61954: 30.0.50; [PATCH] Simplify structured commands in Eshell Jim Porter
2023-03-06 1:15 ` Sean Whitton
2023-03-06 2:11 ` Jim Porter
2023-03-17 5:33 ` Jim Porter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5000fd2-350a-eaea-c787-0551aa30ac23@gmail.com \
--to=jporterbugs@gmail.com \
--cc=61954-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).