* bug#69463: 29.2; Isearch help icon has inconsistent size
2024-02-29 17:42 ` Juri Linkov
@ 2024-03-03 12:08 ` Sergio Callegari
2024-03-03 17:09 ` Juri Linkov
2024-03-03 12:35 ` Sergio Callegari
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Sergio Callegari @ 2024-03-03 12:08 UTC (permalink / raw)
To: Juri Linkov; +Cc: 69463
Can you please help me understand the way in which it is "system dependent"?
Where are the I-search toolbar icons sought on the system? Is it emacs
installing them or are they supposed to be system or theme provided icons?
Thanks,
Sergio Callegari
On 29/02/2024 18:42, Juri Linkov wrote:
>> When you press CTRL+s, I-search is activated, that provides a custom
>> toolbar with dedicated icons and lets one enter what to search in the
>> mode line.
>>
>> Unfortunately, in the toolbar there is a help icon, shaped as a life
>> buoy, that is too big or at least inconsistently big wrt the other icons.
>> As a consequence, when I-search is activated the emacs windows
>> becomes bigger to accomodate space for the taller toolbar.
>>
>> Not only having the window changing its size causes some inconvenience
>> because the text you are trying to focus on moves up and down. There is
>> a major problem if the emacs window is already vertically maximized
>> before you start searching. In fact, in this case there is no space for
>> the window to grow. As a consequence, the mode line goes out of the
>> screen and you cannot use it to search!
> This behavior is system-dependent. For example,
> I can't reproduce it on these configurations:
>
> GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
> cairo version 1.16.0)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo version 1.16.0, Xaw3d scroll bars)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0)
>
> Strange, the last is similar to your configuration:
>
>> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
>> cairo version 1.18.0)
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#69463: 29.2; Isearch help icon has inconsistent size
2024-03-03 12:08 ` Sergio Callegari
@ 2024-03-03 17:09 ` Juri Linkov
2024-03-03 17:57 ` Sergio Callegari
0 siblings, 1 reply; 8+ messages in thread
From: Juri Linkov @ 2024-03-03 17:09 UTC (permalink / raw)
To: Sergio Callegari; +Cc: 69463
> Can you please help me understand the way in which it is "system dependent"?
>
> Where are the I-search toolbar icons sought on the system? Is it emacs
> installing them or are they supposed to be system or theme provided icons?
This is what I see while resizing the frame: when decreasing the width
of the frame then I-search toolbar icons get removed one by one
from the right side of the toolbar, so the toolbar never overgrows.
> That is definitely a life buoy, but not the life buoy that is shown as
> the help icon when I press CTRL+s. In fact, it is the life buoy that I
> see in most emacs screenshots on the internet. Most important this one
> seems to have the right size.
I don't see this life buoy on GTK.
> I need help on the following points:
>
> - Why is that breeze icon being picked? Is there a way to force emacs to
> use its own icons? Theming would be nice, but done in this way, with a
> wild mixture of breeze icons and native emacs icons it is simply messy.
>
> - Why is that breeze icon not scaled? All other applications on my
> system appear to scale their icons consistently.
I don't know how that breeze icon looks like. What I see is
an icon with a blue question mark.
> My issue seems to be the same as
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23847#31.
> The whole thread is interesting.
Thanks for the reference. It could help anyone
who knows how to fix this bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#69463: 29.2; Isearch help icon has inconsistent size
2024-03-03 17:09 ` Juri Linkov
@ 2024-03-03 17:57 ` Sergio Callegari
0 siblings, 0 replies; 8+ messages in thread
From: Sergio Callegari @ 2024-03-03 17:57 UTC (permalink / raw)
To: Juri Linkov; +Cc: 69463
With the hope to help others, I have managed working around the issue.
This involves going through Options->Customize Emacs->Options Matching
and then entering `x-gtk` in the modeline. In the customization buffer
that opens, search for X Gtk Stock Map and then for 'help-browser'.
Substitute 'help-contents' for it in "Named". Then save state so that it
is used in the following sessions too.
Apparently, there is a lack of coordination on how icons should work
between the breeze developers and the gnome/gtk community regarding who
should be in charge of sizing the "scalable" icons to the correct size
and how to pass hints about this.
My understanding is that breeze developers do not think that this is a
bug on their side and that emacs should care of displaying the icons at
an appropriate size.
On 03/03/2024 18:09, Juri Linkov wrote:
>> Can you please help me understand the way in which it is "system dependent"?
>>
>> Where are the I-search toolbar icons sought on the system? Is it emacs
>> installing them or are they supposed to be system or theme provided icons?
>
> This is what I see while resizing the frame: when decreasing the width
> of the frame then I-search toolbar icons get removed one by one
> from the right side of the toolbar, so the toolbar never overgrows.
>
>> That is definitely a life buoy, but not the life buoy that is shown as
>> the help icon when I press CTRL+s. In fact, it is the life buoy that I
>> see in most emacs screenshots on the internet. Most important this one
>> seems to have the right size.
>
> I don't see this life buoy on GTK.
>
>> I need help on the following points:
>>
>> - Why is that breeze icon being picked? Is there a way to force emacs to
>> use its own icons? Theming would be nice, but done in this way, with a
>> wild mixture of breeze icons and native emacs icons it is simply messy.
>>
>> - Why is that breeze icon not scaled? All other applications on my
>> system appear to scale their icons consistently.
>
> I don't know how that breeze icon looks like. What I see is
> an icon with a blue question mark.
>
>> My issue seems to be the same as
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23847#31.
>> The whole thread is interesting.
>
> Thanks for the reference. It could help anyone
> who knows how to fix this bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#69463: 29.2; Isearch help icon has inconsistent size
2024-02-29 17:42 ` Juri Linkov
2024-03-03 12:08 ` Sergio Callegari
@ 2024-03-03 12:35 ` Sergio Callegari
2024-03-03 12:55 ` Sergio Callegari
2024-03-03 13:03 ` Sergio Callegari
3 siblings, 0 replies; 8+ messages in thread
From: Sergio Callegari @ 2024-03-03 12:35 UTC (permalink / raw)
To: Juri Linkov; +Cc: 69463
Trying to look into the matter, I have found the file
`/usr/share/emacs/29.2/lisp/isearch.el.gz`, which I understand is the
source of the code implementing the isearch functionality.
In this file, there is a portion of code that appears to be in charge of
configuring the toolbar, starting in
`(defvar isearch-tool-bar-map ... )`
The portion setting the icon for help should be:
```
(define-key map [isearch-describe-mode]
(list 'menu-item "Help" 'isearch-describe-mode
:help "Get help for Isearch"
:image '(isearch-tool-bar-image "help")))
```
However, if I try to evaluate `(isearch-tool-bar-image "help")` I get
`/usr/share/emacs/29.2/etc/images/help.xpm`
That is definitely a life buoy, but not the life buoy that is shown as
the help icon when I press CTRL+s. In fact, it is the life buoy that I
see in most emacs screenshots on the internet. Most important this one
seems to have the right size.
So my system seems to disregard the default icons shipped with emacs and
to look for something different. My wild guess is that this depends on
gtk theming. My second wild guess is that because I am on KDE this
theming is not configured at all and is wrong.
To provide more context, I am on an arch derived distro (Manjaro), with
KDE. I use the breeze theme, that seems to have exactly that too big
life buoy.
I need help on the following points:
- Why is that breeze icon being picked? Is there a way to force emacs to
use its own icons? Theming would be nice, but done in this way, with a
wild mixture of breeze icons and native emacs icons it is simply messy.
- Why is that breeze icon not scaled? All other applications on my
system appear to scale their icons consistently.
Thanks!
Sergio
On 29/02/2024 18:42, Juri Linkov wrote:
>> When you press CTRL+s, I-search is activated, that provides a custom
>> toolbar with dedicated icons and lets one enter what to search in the
>> mode line.
>>
>> Unfortunately, in the toolbar there is a help icon, shaped as a life
>> buoy, that is too big or at least inconsistently big wrt the other icons.
>> As a consequence, when I-search is activated the emacs windows
>> becomes bigger to accomodate space for the taller toolbar.
>>
>> Not only having the window changing its size causes some inconvenience
>> because the text you are trying to focus on moves up and down. There is
>> a major problem if the emacs window is already vertically maximized
>> before you start searching. In fact, in this case there is no space for
>> the window to grow. As a consequence, the mode line goes out of the
>> screen and you cannot use it to search!
>
> This behavior is system-dependent. For example,
> I can't reproduce it on these configurations:
>
> GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
> cairo version 1.16.0)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo version 1.16.0, Xaw3d scroll bars)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0)
>
> Strange, the last is similar to your configuration:
>
>> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
>> cairo version 1.18.0)
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#69463: 29.2; Isearch help icon has inconsistent size
2024-02-29 17:42 ` Juri Linkov
2024-03-03 12:08 ` Sergio Callegari
2024-03-03 12:35 ` Sergio Callegari
@ 2024-03-03 12:55 ` Sergio Callegari
2024-03-03 13:03 ` Sergio Callegari
3 siblings, 0 replies; 8+ messages in thread
From: Sergio Callegari @ 2024-03-03 12:55 UTC (permalink / raw)
To: Juri Linkov; +Cc: 69463
I have made more tests.
The behavior that I am experiencing is due to using the breeze icon theme.
Unclear to me if the issue is in the theme itself, though. All other
applications using this icon theme appear to be able to scale the icons
in the theme (which I guess are svg) according to their needs.
Sergio
On 29/02/2024 18:42, Juri Linkov wrote:
>> When you press CTRL+s, I-search is activated, that provides a custom
>> toolbar with dedicated icons and lets one enter what to search in the
>> mode line.
>>
>> Unfortunately, in the toolbar there is a help icon, shaped as a life
>> buoy, that is too big or at least inconsistently big wrt the other icons.
>> As a consequence, when I-search is activated the emacs windows
>> becomes bigger to accomodate space for the taller toolbar.
>>
>> Not only having the window changing its size causes some inconvenience
>> because the text you are trying to focus on moves up and down. There is
>> a major problem if the emacs window is already vertically maximized
>> before you start searching. In fact, in this case there is no space for
>> the window to grow. As a consequence, the mode line goes out of the
>> screen and you cannot use it to search!
>
> This behavior is system-dependent. For example,
> I can't reproduce it on these configurations:
>
> GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
> cairo version 1.16.0)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo version 1.16.0, Xaw3d scroll bars)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0)
>
> Strange, the last is similar to your configuration:
>
>> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
>> cairo version 1.18.0)
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#69463: 29.2; Isearch help icon has inconsistent size
2024-02-29 17:42 ` Juri Linkov
` (2 preceding siblings ...)
2024-03-03 12:55 ` Sergio Callegari
@ 2024-03-03 13:03 ` Sergio Callegari
3 siblings, 0 replies; 8+ messages in thread
From: Sergio Callegari @ 2024-03-03 13:03 UTC (permalink / raw)
To: Juri Linkov; +Cc: 69463
My issue seems to be the same as
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23847#31.
The whole thread is interesting.
Sergio
On 29/02/2024 18:42, Juri Linkov wrote:
>> When you press CTRL+s, I-search is activated, that provides a custom
>> toolbar with dedicated icons and lets one enter what to search in the
>> mode line.
>>
>> Unfortunately, in the toolbar there is a help icon, shaped as a life
>> buoy, that is too big or at least inconsistently big wrt the other icons.
>> As a consequence, when I-search is activated the emacs windows
>> becomes bigger to accomodate space for the taller toolbar.
>>
>> Not only having the window changing its size causes some inconvenience
>> because the text you are trying to focus on moves up and down. There is
>> a major problem if the emacs window is already vertically maximized
>> before you start searching. In fact, in this case there is no space for
>> the window to grow. As a consequence, the mode line goes out of the
>> screen and you cannot use it to search!
>
> This behavior is system-dependent. For example,
> I can't reproduce it on these configurations:
>
> GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
> cairo version 1.16.0)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo version 1.16.0, Xaw3d scroll bars)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0)
>
> Strange, the last is similar to your configuration:
>
>> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
>> cairo version 1.18.0)
^ permalink raw reply [flat|nested] 8+ messages in thread