From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#31350: 27.0; `pcase' message: "Redundant pcase pattern" Date: Sun, 4 Oct 2020 10:45:54 -0700 (PDT) Message-ID: References: <86d352f4-5fa7-4bee-b72c-17e58aace43f@default> <87364hs46h.fsf@gnus.org> <87sgaudiss.fsf@web.de> <8bcc3be5-c9db-4015-8f0f-4efe77ff27ee@default> <87sgau93fh.fsf@web.de> <87v9fqrsvf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28195"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 31350@debbugs.gnu.org To: Lars Ingebrigtsen , Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 04 19:48:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP87u-0007Eq-FP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 19:48:50 +0200 Original-Received: from localhost ([::1]:34464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP87t-00056b-Eh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 13:48:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP869-0002se-VY for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 13:47:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35144) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kP869-0006MI-L0 for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 13:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kP869-0005pe-JS for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 13:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Oct 2020 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31350 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31350-submit@debbugs.gnu.org id=B31350.160183356622347 (code B ref 31350); Sun, 04 Oct 2020 17:47:01 +0000 Original-Received: (at 31350) by debbugs.gnu.org; 4 Oct 2020 17:46:06 +0000 Original-Received: from localhost ([127.0.0.1]:46690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP85G-0005oN-8f for submit@debbugs.gnu.org; Sun, 04 Oct 2020 13:46:06 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:45872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP85E-0005nc-IS for 31350@debbugs.gnu.org; Sun, 04 Oct 2020 13:46:05 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 094HhvxV054973; Sun, 4 Oct 2020 17:45:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=ieK5Q48Td2yrgLpKbEhiqYZj1MIA9uP8+hzQ1gSTaso=; b=fg0AYkN+5f5X+8znlew4wHO85vC0OZFoX22dhMbkft0rlHKVrSXudd2h4McL4wJf2LJD Gbx6cTu6gfd78U4gjhhDHVD5btBqb8gkmJjuDnD22W/1i+xXcLVpqdev1cW2bZ3CwOnv m2sItzp8bKRdD+TRqVg0zabkgSZHL535iuI+Rz0Ld7EWRRLBoW3GgJTvBYcCP5Cnydij BRBkIN9iPbhk0FurA57zF1EgWAGRue15ek1sY7YEACHYYC+CuldJr4NMTgdUX/lPdpbv NyrNnSCXRguaHUVee3O+1B8/Nj0KDyWu6HWn37tegVXGLmiXgXtjHIjkzryeE3IEyip1 YQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 33xh8kjtew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 04 Oct 2020 17:45:57 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 094HitOM123737; Sun, 4 Oct 2020 17:45:57 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 33y36vpxa6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 Oct 2020 17:45:57 +0000 Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 094Hjt0b020776; Sun, 4 Oct 2020 17:45:56 GMT In-Reply-To: <87v9fqrsvf.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9764 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010040137 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9764 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010040137 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189760 Archived-At: > Perhaps the warning should be more explicit? "Redundant pcase pattern" > is obvious if you already know what it means, but if you don't, it's > not. :-) So something like "pcase pattern shadowed by previous pcase > pattern" or something along those lines? That's a start. But as I said: And even if a user (somehow) understands that later cases are made redundant by earlier ones, how to tell which earlier ones are implicated? Just saying that some previous pcase pattern makes this one redundant doesn't tell you which previous pattern that does that. It should.