From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70038: 29.3.50; Shift up/down in buffer with images on M-x other-window with some fonts Date: Sun, 14 Apr 2024 10:31:15 +0200 Message-ID: References: <87ttkrl8w1.fsf@gmail.com> <86zfuihp7t.fsf@gnu.org> <87bk6yl4hu.fsf@gmail.com> <8734sal2bc.fsf@gmail.com> <87wmpm2rd7.fsf@zohomail.eu> <86bk6m3c20.fsf@gnu.org> <867cha37of.fsf@gnu.org> <3ee13fbd-2ba0-4fca-b5ed-b61f1d8dc527@gmx.at> <864jcd1qok.fsf@gnu.org> <8634rx1kfb.fsf@gnu.org> <028e677b-6d6b-42b2-95ac-0e0c5d1f3dd1@gmx.at> <86jzl1po87.fsf@gnu.org> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20197"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: luangruo@yahoo.com, 70038@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 14 10:32:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvvHc-000557-1V for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Apr 2024 10:32:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvvHH-00049F-9J; Sun, 14 Apr 2024 04:31:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvvHF-000493-6p for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 04:31:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvvHE-0000nF-Uk for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 04:31:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvvHP-0006LP-L6 for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 04:32:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Apr 2024 08:32:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70038 X-GNU-PR-Package: emacs Original-Received: via spool by 70038-submit@debbugs.gnu.org id=B70038.171308350024208 (code B ref 70038); Sun, 14 Apr 2024 08:32:03 +0000 Original-Received: (at 70038) by debbugs.gnu.org; 14 Apr 2024 08:31:40 +0000 Original-Received: from localhost ([127.0.0.1]:34263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvvH2-0006IO-24 for submit@debbugs.gnu.org; Sun, 14 Apr 2024 04:31:40 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:52811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvvGx-0006GY-HZ for 70038@debbugs.gnu.org; Sun, 14 Apr 2024 04:31:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1713083476; x=1713688276; i=rudalics@gmx.at; bh=+h3SxRy9bePtHwXuiuHuXSHSLD+aCcOhG1wTbagW++g=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=eYktv3KNh+KHFZsa1vDkPXXNoRXQUvVXHCUYOrx8uFeZ626jDASTfgTJz0tAK100 0PpVDM0cbhQswijOfo1u0YEtJjDvF2TEflD8p8nHmEUu95YySJSQgNX7UqpJZQ5U+ lUZslYmMKqbRAiWnFBXkDGOVI6FJQlJx6zVyN1FZCKEcvrDWHkxvFmvo3um6Avc80 INzoqpTDQrpueoVM+Bwtco9oR9BePvC3gGheVZQ2Js1dQ8nRFrmgUx41OitwHLZxX nz5XS6J0Bbao8o4hYuvYok1q67M9W+aq+A3hvnkjbezRKhaTmah/x9dws5dNqJ9WZ OXV8Ks7zOAEkli2tyg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([213.142.96.51]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MFKGP-1rxsHV23Pl-00Ffvh; Sun, 14 Apr 2024 10:31:16 +0200 Content-Language: en-US In-Reply-To: <86jzl1po87.fsf@gnu.org> X-Provags-ID: V03:K1:F610VAdoPl9aQEfhLEvqL9Zk4mahOjik2oVNqjmIXH/8aIW8fg0 VTBDvRAZylnit6lVPMzUks1P5p4RrtfMlahvsfob3f0Phfi2EgCl9EpANPxBPn3VBilDtor zDcuSlbBK0HpIi8pmlWLyFRL44s9sLzV7ieMNq42ROhOOcutlc/KSXDadAvJdj77Hu4vSxy 6KjtZ3bXmbU4kTms6ZYtA== UI-OutboundReport: notjunk:1;M01:P0:3JndTUeU7cI=;JeCvJQfJWWZEeuIfvS0n0X6yeNe mqgywNEU4R+Op3mGtGw9V+wK3t3x0Ie71KHFPsOXJgGtP6L2zvS6tlThbdnhiNn+ymPabkiIc kEzaGjL60slreBlSZmwIHSzcLvqReFZSFSrmLd6LH/LRvrndHBBeMCa8HzhC3HXAP4uJL4aPx CNssOk/d0vYZ1lHTRCvuwoydIvFtQwXaVmrIFM1f7Qv9OzZTI0Z3X/CgIWV/0OIyTL+TW9WLu i+yP3oOhLcaS8oXBQ/juw6ywc/oSqoQrl5DrKNNIfK/j2Olw8eZzIPh5tOf4VXk1oxp7lodjX 3r+AqE5g+W4tKkf/fIvCnBvxsrZRI8jYpVLzotMY8QEcmuOqkE8ZLSUsT40zdWB6HAV3Asv2C vFZqe69FAGegVBBgj+eZiXymZcwUGzcdOFTqigMHXMB+9DBmUONInCnEzOJ2B6gC2KRndlWX3 zzV5jBZsu6wWU35sTRJAvKpnfnWjks/nuCjXsGHJM07WqfeWROPva3yko+jmYW3uL5WH1Xsgw crnz2mK7y3yHnlW5AceDUkGXm7rqvhJyZvA2d2x9kIh/bzzYFpo0gRcGxcCaXL6/7fx2sCssH hRVYpYbk+rity/jCeaJZq/IEWW6Ee8VAOuP7RlGCKJU44jTHAUevtEXEnMTUOWEBhEv4sfJEw z6Q25GpuhJKtCeTpExKI8AHDVyqFHY8kKpjAoSRoXw5OvpnrtlzlGSimQzR7Uv59YodHIR8Ts /dOp3PaxSO7N4YKuhHFPLPhdbZ9DtfX0SPovkCe24uYOmkiOCQoDC3p5kiJkpS2kBBmtBASq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283258 Archived-At: > The (slight) harm this does is that it might make redisplay of the > window slightly more expensive, because it disables some > optimizations, like if nothing changed except the position of point. > Another kind of harm is what triggered this bug report: it could cause > us to reset the window's vscroll for now good reason, because when > start positions are frozen, we set the window's force_start flag, and > that sometimes forces us to reset vscroll. From looking at the code it's hard to understand what you say here. It might be a good idea to add this as a comment. > So the patch below is the only change we need to make sure the frame's > frozen_window_starts is reset when the mini-window is resized back? Probably not. If 'resize-mini-windows' is t, we never unfreeze window starts because we don't call shrink_mini_window in that case. > Should it matter whether, if the minibuffer is active, we do that only > at the outer level of minibuffer? It shouldn't. Window starts would be frozen immediately as soon as the mini window grows again. I think that to cover most cases we should unfreeze window starts every time the mini window gets smaller as in the patch below. diff --git a/src/window.c b/src/window.c index fe26311fbb2..9c8fc12ee3e 100644 --- a/src/window.c +++ b/src/window.c @@ -5376,7 +5376,8 @@ grow_mini_window (struct window *w, int delta) struct window *r = XWINDOW (root); Lisp_Object grow; - FRAME_WINDOWS_FROZEN (f) = true; + FRAME_WINDOWS_FROZEN (f) = (delta > 0) ? true : false; + grow = call3 (Qwindow__resize_root_window_vertically, root, make_fixnum (- delta), Qt); martin