From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 20 Sep 2020 09:41:59 -0700 (PDT) Message-ID: References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> <8739ww1tjp.fsf@mail.jurta.org> <87d3vyaodq.fsf@mail.jurta.org> <87hbla4nl4.fsf@mail.jurta.org> <87mu1llak3.fsf@gnus.org> <83lfh50zxa.fsf@gnu.org> <87eemwss3t.fsf@gnus.org> <834kns22q2.fsf@gnu.org> <87sgbcrcgd.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27371"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org To: Lars Ingebrigtsen , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 18:43:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kK2R2-00070F-5B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 18:43:32 +0200 Original-Received: from localhost ([::1]:55602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kK2R1-0003XD-8M for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 12:43:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kK2QY-0003Wo-TQ for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 12:43:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kK2QY-0002Bi-IO for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 12:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kK2QY-0005o4-H6 for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 12:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2020 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.160062013122257 (code B ref 6227); Sun, 20 Sep 2020 16:43:02 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 20 Sep 2020 16:42:11 +0000 Original-Received: from localhost ([127.0.0.1]:52487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK2Pj-0005mv-0v for submit@debbugs.gnu.org; Sun, 20 Sep 2020 12:42:11 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:35476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK2Pg-0005mW-1E for 6227@debbugs.gnu.org; Sun, 20 Sep 2020 12:42:09 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08KGevii084601; Sun, 20 Sep 2020 16:42:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=mbjSOOez7IgstwIRBvAmobZydol9MS45HeGOawSB6Ks=; b=zkWWgCBI5o+66HvdFwI46CYfR1gusCAvxhd09X/naHJN2vG7IsWbHXXAe3BWglOHoaDv kkJdqfSC47AEGOv1YxmGMo0PyTp75X7PX8HM8e5fB7AzbO9sdbQdAYYhs6eCpqxtK4Yo CX+BazYx+ZN+7BYxlmf+/VRfWndKAgKGn2HCj/FbQxsi/VB7z1ERZMjagrqMF/I/d8uc jJR89Oohmeh2FirOv5aJWIg6mC2KRSHZ6gvpl441mvnkQMWbLvMbedgOq1opBkTTjfd/ nmzdWbeQTWB/3KBMt0cGPU/sVqaVrrfnfHUIaoFglJ/W+ibR3jfn9nYrew8HBIPiAQbL lw== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 33n9dqtphv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 20 Sep 2020 16:42:02 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08KGeFdq168418; Sun, 20 Sep 2020 16:42:01 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 33nurp5h1t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 20 Sep 2020 16:42:01 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08KGg0Yp011825; Sun, 20 Sep 2020 16:42:00 GMT In-Reply-To: <87sgbcrcgd.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=901 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009200147 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=920 phishscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009200147 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188518 Archived-At: > > (defface isearch > > '((((class color) (min-colors 88) (background light)) > > ;; The background must not be too dark, for that means > > ;; the character is hard to see when the cursor is there. > > (:background "magenta3" :foreground "lightskyblue1")) >=20 > I meant that these deffaces aren't complete -- they look like examples, > and the examples are taken from the isearch face. >=20 > There should be more of them, and they should be complete, and they > should have better names (isearch-group-1 etc perhaps). FWIW, I use simple definitions like this one for the eight regexp-level faces, not bothering with multiple kinds of displays. (Not saying that's what isearch.el should do.) (defface isearchp-regexp-level-8=20 '((((background dark)) (:background "#12EC00003F0E")) ; a very dark blue (t (:background "#F6F5FFFFE1E1"))) ; a light yellow "Face used to highlight subgroup level 8 of your search context. This highlighting is done during regexp searching whenever `isearchp-highlight-regexp-group-levels-flag' is non-nil." :group 'isearch-plus :group 'faces)