unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
@ 2014-03-23 22:35 Drew Adams
  2014-03-24  9:06 ` martin rudalics
  0 siblings, 1 reply; 11+ messages in thread
From: Drew Adams @ 2014-03-23 22:35 UTC (permalink / raw)
  To: 17077

This build does not give the correct result when using `set-frame-size'.

In previous builds and releases, including a build as recent as
2014-03-11, (set-frame-size 75 64) ends up with these frame parameters
(using my setup, for a special-display frame):

((top + -1)
 (left + -2)
 (buried-buffer-list)
 (buffer-list #<buffer *Bookmark List*>)
 (width . 75) ; <==============================
 (height . 62)
 (tool-bar-position . top)
 (parent-id)
 (explicit-name . t)
 (display . "w32")
 (visibility . t)
 (icon-name)
 (window-id . "3476582")
 (unsplittable . t)
 (minibuffer)
 (modeline . t)
 (thumfr-non-thumbnail-frame
  (top . 12)
  (left . 4)
  (buried-buffer-list)
  (buffer-list #<buffer *Bookmark List*>)
  (width . 118)
  (height . 67)
  (tool-bar-position . top)
  (parent-id)
  (explicit-name . t)
  (display . "w32")
  (visibility . t)
  (icon-name)
  (window-id . "3476582")
  (unsplittable . t)
  (minibuffer)
  (modeline . t)
  (name . "*Bookmark List*")
  (zoomed . -2)
  (cursor-color . "Yellow")
  (background-mode . light)
  (display-type . color)
  (fringe . 0)
  (scroll-bar-width . 6)
  (cursor-type . bar)
  (auto-lower)
  (auto-raise)
  (icon-type)
  (fullscreen)
  (title)
  (buffer-predicate)
  (tool-bar-lines . 0)
  (menu-bar-lines . 0)
  (alpha)
  (right-fringe . 0)
  (left-fringe . 0)
  (line-spacing)
  (screen-gamma)
  (border-color . "black")
  (mouse-color . "Yellow")
  (background-color . "LightSteelBlue")
  (foreground-color . "Black")
  (vertical-scroll-bars . right)
  (bottom-divider-width . 2)
  (right-divider-width . 2)
  (internal-border-width . 0)
  (border-width . 2)
  (font . "-outline-Lucida Console-normal-normal-normal-mono-2-*-*-*-c-*-iso8859-1")
  (font-parameter . "-*-Lucida Console-normal-r-*-*-14-*-*-*-c-*-iso8859-1")
  (font-backend uniscribe gdi))
 (thumfr-thumbnail-frame)
 (name . "*Bookmark List*")
 (zoomed . -1)
 (cursor-color . "Yellow")
 (background-mode . light)
 (display-type . color)
 (fringe . 0)
 (scroll-bar-width . 21)
 (cursor-type . bar)
 (auto-lower)
 (auto-raise)
 (icon-type)
 (fullscreen)
 (title)
 (buffer-predicate)
 (tool-bar-lines . 0)
 (menu-bar-lines . 1)
 (alpha)
 (right-fringe . 0)
 (left-fringe . 0)
 (line-spacing)
 (screen-gamma)
 (border-color . "black")
 (mouse-color . "Yellow")
 (background-color . "LightSteelBlue")
 (foreground-color . "Black")
 (vertical-scroll-bars . right)
 (bottom-divider-width . 2)
 (right-divider-width . 2)
 (internal-border-width . 0)
 (border-width . 2)
 (font . "-outline-Lucida Console-normal-normal-normal-mono-13-*-*-*-c-*-iso8859-1")
 (font-parameter . "-*-Lucida Console-normal-r-*-*-14-*-*-*-c-*-iso8859-1")
 (font-backend uniscribe gdi))

The current version ends up with these frame parameters instead:

((tool-bar-position . top)
 (parent-id)
 (explicit-name)
 (display . "w32")
 (visibility . t)
 (icon-name)
 (window-id . "920808")
 (top . 37)
 (left . 255)
 (buried-buffer-list #<buffer *Backtrace*>)
 (buffer-list #<buffer *Bookmark List*>)
 (unsplittable . t)
 (minibuffer)
 (modeline . t)
 (width . 74) ; <==============================
 (height . 64)
 (name . "*Bookmark List*")
 (zoomed . -1)
 (cursor-color . "Yellow")
 (background-mode . light)
 (display-type . color)
 (fringe . 0)
 (scroll-bar-width . 21)
 (cursor-type . bar)
 (auto-lower)
 (auto-raise)
 (icon-type)
 (fullscreen)
 (title)
 (buffer-predicate)
 (tool-bar-lines . 0)
 (menu-bar-lines . 1)
 (alpha)
 (right-fringe . 0)
 (left-fringe . 0)
 (line-spacing)
 (screen-gamma)
 (border-color . "black")
 (mouse-color . "Yellow")
 (background-color . "LightSteelBlue")
 (foreground-color . "Black")
 (vertical-scroll-bars . right)
 (bottom-divider-width . 2)
 (right-divider-width . 2)
 (internal-border-width . 0)
 (border-width . 2)
 (font . "-outline-Lucida Console-normal-normal-normal-mono-13-*-*-*-c-*-iso8859-1")
 (font-parameter . "-*-Lucida Console-normal-r-*-*-14-*-*-*-c-*-iso8859-1")
 (font-backend uniscribe gdi))

I don't care so much about the height.  What is definitely wrong is
diminishing the specified width (75) by one.  The widest line in the
buffer is 75 chars wide, so fitting the frame to a width of 74 does
not cut the mustard.

Depending on the char (font) size, sometimes the frame fitting still
works as it should.  But for other sizes it has this
one-char-less-than-required-width failing.  E.g., this is the case
also for font "-outline-Lucida
Console-normal-normal-normal-mono-10-*-*-*-c-*-iso8859-1" (same font,
with size 10).


In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-03-21 on ODIEONE
Bzr revision: 116829 dancol@dancol.org-20140321121023-5tjxtiws6qa4qyod
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include' LDFLAGS=-Lc:/Devel/emacs/lib'





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-23 22:35 bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size Drew Adams
@ 2014-03-24  9:06 ` martin rudalics
  2014-03-24 14:17   ` Drew Adams
  2014-03-28 14:59   ` Drew Adams
  0 siblings, 2 replies; 11+ messages in thread
From: martin rudalics @ 2014-03-24  9:06 UTC (permalink / raw)
  To: Drew Adams, 17077

 > In previous builds and releases, including a build as recent as
 > 2014-03-11, (set-frame-size 75 64)

(set-frame-size nil 75 64)

 > ends up with these frame parameters
 > (using my setup, for a special-display frame):
 >
 >   (width . 75) ; <==============================
 >   (height . 62)
...
 >   (width . 74) ; <==============================
 >   (height . 64)
...
 >
 > I don't care so much about the height.  What is definitely wrong is
 > diminishing the specified width (75) by one.  The widest line in the
 > buffer is 75 chars wide, so fitting the frame to a width of 74 does
 > not cut the mustard.
 >
 > Depending on the char (font) size, sometimes the frame fitting still
 > works as it should.  But for other sizes it has this
 > one-char-less-than-required-width failing.  E.g., this is the case
 > also for font "-outline-Lucida
 > Console-normal-normal-normal-mono-10-*-*-*-c-*-iso8859-1" (same font,
 > with size 10).

Should be fixed with revision 116849 on the emacs-24 release branch.

Please also check whether bug#16923 is affected.  The "fix" that caused
the present bug was a stab in direction of fixing 16923.

Thanks, martin





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-24  9:06 ` martin rudalics
@ 2014-03-24 14:17   ` Drew Adams
  2014-03-25 20:43     ` Drew Adams
  2014-03-28 14:59   ` Drew Adams
  1 sibling, 1 reply; 11+ messages in thread
From: Drew Adams @ 2014-03-24 14:17 UTC (permalink / raw)
  To: martin rudalics, 17077

>  > (set-frame-size 75 64)
> (set-frame-size nil 75 64)

Yes, that's what I meant.

>  >   (width . 75) ; <==============================
>  >   (width . 74) ; <==============================
>  >
>  > fitting the frame to a width of 74 does not cut the mustard.
>  >
>  > Depending on the char (font) size, sometimes the frame fitting still
>  > works as it should.  But for other sizes it has this
>  > one-char-less-than-required-width failing.  E.g., this is the case
>  > also for font "-outline-Lucida
>  > Console-normal-normal-normal-mono-10-*-*-*-c-*-iso8859-1" (same font,
>  > with size 10).
> 
> Should be fixed with revision 116849 on the emacs-24 release branch.
> 
> Please also check whether bug#16923 is affected.  The "fix" that caused
> the present bug was a stab in direction of fixing 16923.

I'll take a look.  Thx.

(Will also still get back to you about 16923. I haven't had time to
look into it.)





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-24 14:17   ` Drew Adams
@ 2014-03-25 20:43     ` Drew Adams
  2014-03-25 21:24       ` martin rudalics
  2014-03-25 21:40       ` Juanma Barranquero
  0 siblings, 2 replies; 11+ messages in thread
From: Drew Adams @ 2014-03-25 20:43 UTC (permalink / raw)
  To: martin rudalics, 17077

> > Should be fixed with revision 116849 on the emacs-24 release branch.

Dunno whether I have that revision or not.  The problem is the same in
this build, FWIW:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-03-23 on ODIEONE
Bzr revision: 116869 yamaoka@jpl.org-20140324004210-m3ek4k40qwamyabx
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-25 20:43     ` Drew Adams
@ 2014-03-25 21:24       ` martin rudalics
  2014-03-25 21:34         ` Drew Adams
  2014-03-25 21:40       ` Juanma Barranquero
  1 sibling, 1 reply; 11+ messages in thread
From: martin rudalics @ 2014-03-25 21:24 UTC (permalink / raw)
  To: Drew Adams, 17077

>>> Should be fixed with revision 116849 on the emacs-24 release branch.
>
> Dunno whether I have that revision or not.  The problem is the same in
> this build, FWIW:

Does your version of src/w32term.c mention Bug#17077?

martin







^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-25 21:24       ` martin rudalics
@ 2014-03-25 21:34         ` Drew Adams
  2014-03-25 21:37           ` Drew Adams
  0 siblings, 1 reply; 11+ messages in thread
From: Drew Adams @ 2014-03-25 21:34 UTC (permalink / raw)
  To: martin rudalics, 17077

First, let me say that for some reason I have not been receiving replies
I send to the bug list.  My reply quoted below, for instance.  This seems
to have been happening for a few days now.  My replies end up in the bug
thread, but I receive no mail.

> >>> Should be fixed with revision 116849 on the emacs-24 release branch.
> >
> > Dunno whether I have that revision or not.  The problem is the same in
> > this build, FWIW:
> 
> Does your version of src/w32term.c mention Bug#17077?

I do not have C sources in the builds I pick up.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-25 21:34         ` Drew Adams
@ 2014-03-25 21:37           ` Drew Adams
  0 siblings, 0 replies; 11+ messages in thread
From: Drew Adams @ 2014-03-25 21:37 UTC (permalink / raw)
  To: 17077

However, I did receive this reply I sent.  So I guess the problem just
occurs occasionally.   (Sorry for the noise in this bug thread.)

> First, let me say that for some reason I have not been receiving replies
> I send to the bug list.  My reply quoted below, for instance.  This seems
> to have been happening for a few days now.  My replies end up in the bug
> thread, but I receive no mail.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-25 20:43     ` Drew Adams
  2014-03-25 21:24       ` martin rudalics
@ 2014-03-25 21:40       ` Juanma Barranquero
  1 sibling, 0 replies; 11+ messages in thread
From: Juanma Barranquero @ 2014-03-25 21:40 UTC (permalink / raw)
  To: Drew Adams; +Cc: 17077

On Tue, Mar 25, 2014 at 9:43 PM, Drew Adams <drew.adams@oracle.com> wrote:

> Dunno whether I have that revision or not.  The problem is the same in
> this build, FWIW:

AFAICS, revno:116849 from the release branch hasn't yet been merged
into the trunk. And anyway, the most recent branch snapshot I've
uploaded is built from 116847.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-24  9:06 ` martin rudalics
  2014-03-24 14:17   ` Drew Adams
@ 2014-03-28 14:59   ` Drew Adams
  2014-03-29  1:51     ` Juanma Barranquero
  1 sibling, 1 reply; 11+ messages in thread
From: Drew Adams @ 2014-03-28 14:59 UTC (permalink / raw)
  To: martin rudalics, 17077

> Should be fixed with revision 116849 on the emacs-24 release branch.

I have downloaded this build (thanks to Juanma) and tried it:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-03-27 on ODIEONE
Bzr revision: 116884 lekktu@gmail.com-20140327173422-cr942b3hn7xjurks
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

(Dunno how to tell which revisions are in such a build.)

The recipe I used to find and repro the bug does not show the bug
anymore.  The frame width seems no longer to be shortened (sometimes)
by one.  So this bug is apparently fixed.  Thx.

> Please also check whether bug#16923 is affected.  The "fix" that caused
> the present bug was a stab in direction of fixing 16923.

Bug #16923 is still there, unfortunately (but it is a bug I do not care
too much about, personally).

I will need more time to follow your last instructions to get more
information about #16923 for you.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-28 14:59   ` Drew Adams
@ 2014-03-29  1:51     ` Juanma Barranquero
  2014-03-29  1:54       ` Drew Adams
  0 siblings, 1 reply; 11+ messages in thread
From: Juanma Barranquero @ 2014-03-29  1:51 UTC (permalink / raw)
  To: Drew Adams; +Cc: 17077

On Fri, Mar 28, 2014 at 3:59 PM, Drew Adams <drew.adams@oracle.com> wrote:

>> Should be fixed with revision 116849 on the emacs-24 release branch.

> In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
>  of 2014-03-27 on ODIEONE
> Bzr revision: 116884 lekktu@gmail.com-20140327173422-cr942b3hn7xjurks

> (Dunno how to tell which revisions are in such a build.)

You're downloading the trunk snapshot. In this case, it includes all
trunk revisions up to r116884.

You can look at the trunk history:

http://bzr.savannah.gnu.org/lh/emacs/trunk/changes

and, if you search from r116884 down, you'll find changes marked as
"Merged from emacs-24; up to rNNNNNN", which means that revisions in
the emacs-24 branch up to NNNNNN are already merged to the trunk at
these points.

In this case, trunk's r116884 is precisely one of such merges, with
emacs-24 changes up to r116871. So emacs-24's r116849 is included in
your snapshot.

   J





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size
  2014-03-29  1:51     ` Juanma Barranquero
@ 2014-03-29  1:54       ` Drew Adams
  0 siblings, 0 replies; 11+ messages in thread
From: Drew Adams @ 2014-03-29  1:54 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: 17077

> You're downloading the trunk snapshot. In this case, it includes all
> trunk revisions up to r116884...

OK, thanks.





^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2014-03-29  1:54 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-23 22:35 bug#17077: 24.4.50; regression: `set-frame-size' results in wrong frame size Drew Adams
2014-03-24  9:06 ` martin rudalics
2014-03-24 14:17   ` Drew Adams
2014-03-25 20:43     ` Drew Adams
2014-03-25 21:24       ` martin rudalics
2014-03-25 21:34         ` Drew Adams
2014-03-25 21:37           ` Drew Adams
2014-03-25 21:40       ` Juanma Barranquero
2014-03-28 14:59   ` Drew Adams
2014-03-29  1:51     ` Juanma Barranquero
2014-03-29  1:54       ` Drew Adams

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).