From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72335: An attempt to fix UCRT64 build failure Date: Sun, 28 Jul 2024 14:22:25 +0000 Message-ID: References: Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31195"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72335@debbugs.gnu.org To: YI Yue Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 28 16:23:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sY4nq-0007z7-C8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jul 2024 16:23:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sY4nV-0008Rx-6a; Sun, 28 Jul 2024 10:22:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sY4nT-0008RZ-2H for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 10:22:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sY4nS-0001p1-QC for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 10:22:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=JBUR0D0CHagSpzkoblcIfxB4p/YcB9QieosfeSEp4wA=; b=eupwAnRNqHqhiqF+PpRHGYzmz924jAmmmCaDJRqmUNiP6JugVN/irwszVUULhh8CUSqUSABfaRwVTptYwzsUSSHPU89t5l/GIPxgOdsvYtwsemfqpDwxB7Rm69tnoEConbC5oWWoepPHeFKM7fuz/idxravrtkAGt/B9tZ+EsfVDDJQP4dDHzJ8HWZTvnkCXQ5rNM3yM9i4lqXcCPx+1ANtNNIz+Trqq+ekOW5cHXPw8SvF/BDb8NgrwjCJ4C46E+IHFRfy3aGLB+QBGaySDqzfVEUh/0IAdP4UMy85t7pVNupDvSDaHNa5Dd0uW/48yadEmOhgFhijcgOYmkTleIA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sY4ne-0002Am-5V for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 10:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2024 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72335 X-GNU-PR-Package: emacs Original-Received: via spool by 72335-submit@debbugs.gnu.org id=B72335.17221765738338 (code B ref 72335); Sun, 28 Jul 2024 14:23:02 +0000 Original-Received: (at 72335) by debbugs.gnu.org; 28 Jul 2024 14:22:53 +0000 Original-Received: from localhost ([127.0.0.1]:44180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY4nU-0002AP-TH for submit@debbugs.gnu.org; Sun, 28 Jul 2024 10:22:53 -0400 Original-Received: from mail-4316.protonmail.ch ([185.70.43.16]:56761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY4nS-0002AA-TW for 72335@debbugs.gnu.org; Sun, 28 Jul 2024 10:22:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1722176553; x=1722435753; bh=JBUR0D0CHagSpzkoblcIfxB4p/YcB9QieosfeSEp4wA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=mJffgHngz8qRlGAruKKrwNdGMvG3Zf8ZaAHNBRwoY0gmHOi4++edQkH4QUOsmX5Z2 gvF3/8OvfECJNoPbil0Xu6YTqrU5Uc2SqEtjziacC1yXCPcv2e21GAd5KBWf+eeKa4 v4C2R023uWQDmK56dXoEvK/AjaIxQj8o/qvG/1ezI1TfMz233n4X+AZR9MKdYCapCM jr9c9ne4ylMUpBLnumyWogyiJ0o5ms0t6VO3KlbmnYIQAm3n9NgY/EDQ76tcvU2zU6 QVq8INwFEDf3e+Jan9/+hoS2j3n1K0wnp9wloWO0bwHbSH1Ffq+O5+caFqZt2ulo/7 C3K2ZAn+hY0Wg== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 1b6937a394a0b18dd904692d7f384a069fc1c4fa X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289475 Archived-At: On Sunday, July 28th, 2024 at 13:55, YI Yue" via "Bug reports for GNU Emacs= , the Swiss army knife of text editors wrote: > I occasionally try to compile Emacs to get the latest commits. But on Win= dows, I > only use Mingw64 because it's the only one officially supported by Emacs.= [1] > When I try to build Emacs in MSYS2/UCRT64, I'll get these outputs: Just to confirm, that's on native Windows, right? Because I don't know how = UCRT behaves on that system, such information is greatly appreciated > I think maybe we can use > `_fcloseall' instead of` fclose'? By using this, I get no error above whe= n building > in MSYS2/UCRT64. I don't think _fcloseall should have any effect on the standard three strea= ms, so making the entire section "Initial preparation for subprocess suppor= t" should have the same effect, I think. That's what I'm doing in my ucrt64= /msys2/wine experiments :-) > I have little knowledge of MSVCRT and UCRT, it just works :) Thanks, that's great to know. > Here is my patch, regards. >=20 > [1]: https://lists.gnu.org/archive/html/help-gnu-emacs/2022-01/msg00441.h= tml > [2]: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-emacs/= 001-ucrt.patch > [3]: https://lists.gnu.org/archive/html/emacs-devel/2024-02/msg00744.html > [4]: https://lists.gnu.org/archive/html/emacs-devel/2024-07/msg01055.html > [5]: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fc= lose-fcloseall Thanks again, particularly for going to the trouble of collecting those lin= ks. Pip