From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#50207: 28.0.50; ansi-color-compilation-filter and rgrep Date: Thu, 26 Aug 2021 23:36:36 -0700 Message-ID: References: <9c24f4b0-e7aa-62d3-5737-0edffb8b2501@gmail.com> <87lf4nbj1l.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23619"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Manuel Uberti , 50207@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 27 08:37:54 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJVUw-00062p-2b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 08:37:54 +0200 Original-Received: from localhost ([::1]:40078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJVUu-0003Xm-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 02:37:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJVU7-0002k6-0j for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 02:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39562) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJVU6-0004QL-Oh for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 02:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJVU6-0004Nl-Ij for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 02:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Aug 2021 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50207 X-GNU-PR-Package: emacs Original-Received: via spool by 50207-submit@debbugs.gnu.org id=B50207.163004620416817 (code B ref 50207); Fri, 27 Aug 2021 06:37:02 +0000 Original-Received: (at 50207) by debbugs.gnu.org; 27 Aug 2021 06:36:44 +0000 Original-Received: from localhost ([127.0.0.1]:51108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJVTo-0004NA-1h for submit@debbugs.gnu.org; Fri, 27 Aug 2021 02:36:44 -0400 Original-Received: from mail-pf1-f178.google.com ([209.85.210.178]:41797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJVTm-0004Mw-Ea for 50207@debbugs.gnu.org; Fri, 27 Aug 2021 02:36:42 -0400 Original-Received: by mail-pf1-f178.google.com with SMTP id 2so4849592pfo.8 for <50207@debbugs.gnu.org>; Thu, 26 Aug 2021 23:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=o5loY46pwt4t4huh/EKhnVfWW6SK3JdFisvhVXp+LpY=; b=BovP2+SgpcvYf05AghMfbWh60+BxUxrMZjTYu6HXXABYkZLFvjPfn6TOGFIIdSBBff 3J5O5c3fbqJWnkT6rF7VH+HaFjD/5D+oRH/4HPmAmBXUV6UD8xrayOq8tujmIoN8jfSd k9Lwi3UFdGICUkZ8lRjfonAHnfHPpuGBrj1akpdsqR7adliPqibYIilmLw0EuRTOEoMT Ll68+FciIztabXDEWddrcPuN6QtwzDwErn78nneQ405sMly7iA9iqWZOOs9K1yb8gmj+ UZhr6lFY93GlnT4W53fNjhP1vfv5mcRjCB7iSeHpnBqI27uBqdHtIoDaPs1drf8DKjYU neDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o5loY46pwt4t4huh/EKhnVfWW6SK3JdFisvhVXp+LpY=; b=JXpJ1qTo+VogYiBJX0ahuYXJH5aX/bOYfq8eg7em8iEUwHE5f9u/wPhg5nBiDEIZsU SGOfNeu19Gq0HiHXAUNgHLlgkp/HvnobQUAx9+f2Go+Lng9OkVY2yAJIiN7q8nvjqzz0 uBKRY5D2/hlnqea2TF1GckKt/LM+/qKB5JBlBnoXndczA1/GA1I/WRlbrcSyWK0wtl5c Skcs8ucn/7h9jr2PYFlmoVoZB1U1XfCK6P5SUt/U2cKQ4hBfGecgVObUQM2t1wzSnW8v GngqPB8GwYMWoRkbSsmz036Yj0n3K69/86xvvNiP/3CbAy76zUpDssCVTciNH3+xfctK tFFw== X-Gm-Message-State: AOAM531yV/G28kCI2hHc0XlREdqJXFvAMbfb1Tj3vM3XqXeQgO5/AWtS AGNw99DRat8+sATWsbvq4zegp38h954= X-Google-Smtp-Source: ABdhPJyM1fEtGIxahmS+nM73RFXlQv1Ir8jhN82EOk3qREsRcUnhEF3V8DmL4ME/eXRTylNT7Bg62g== X-Received: by 2002:a63:d044:: with SMTP id s4mr6738303pgi.32.1630046196503; Thu, 26 Aug 2021 23:36:36 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id n185sm5327758pfn.171.2021.08.26.23.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Aug 2021 23:36:36 -0700 (PDT) In-Reply-To: <87lf4nbj1l.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212801 Archived-At: On 8/26/2021 11:06 PM, Juri Linkov wrote: > Would it be possible to solve the problem by adding a new buffer-local > variable (disabled by default) that will enable line mode for > `ansi-color-compilation-filter' so that it will handle only complete lines > like grep mode does? I think that would solve this bug. I don't know that it's necessary though: if `grep-filter' does everything correctly (or perhaps, "if it's allowed to do everything correctly"), there should be no ANSI escapes left for `ansi-color-compilation-filter' to process. `grep-mode' could probably just disable `ansi-color-compilation-filter' entirely. Another, more-involved option would be for `grep-filter' to work more like `ansi-color-compilation-filter', i.e. keep track of the active escapes to use for the next hunk of text. I *think* this would make it more robust for searches spanning multiple lines, but admittedly I haven't tested this out to be sure.