From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Ryan C. Thompson" Newsgroups: gmane.emacs.bugs Subject: bug#41340: 26.3; ido-completing-read doesn't respect completion-auto-help Date: Wed, 20 May 2020 10:20:06 -0400 Message-ID: References: <8d5d0854-f60d-2c69-f0bf-4699e44b298b@thompsonclan.org> <14896214-02df-e462-0d4e-91a5f2972f64@thompsonclan.org> <1908eea2-6174-3fbf-da08-1a8d7b06036a@yandex.ru> <3d90d29b-4be8-dc8e-f02a-d49099ce797b@thompsonclan.org> <61bd2d16-a79b-cfd4-389e-5e92222d7cca@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18013"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 To: Dmitry Gutov , 41340@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 16:27:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbPgd-00044w-RU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 16:27:11 +0200 Original-Received: from localhost ([::1]:56714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbPgJ-0005XU-B6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 10:26:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbPag-0002pP-H9 for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 10:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42342) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbPag-0005Pg-7B for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbPag-0002aa-2X for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Ryan C. Thompson" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 May 2020 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41340 X-GNU-PR-Package: emacs Original-Received: via spool by 41340-submit@debbugs.gnu.org id=B41340.15899844189874 (code B ref 41340); Wed, 20 May 2020 14:21:02 +0000 Original-Received: (at 41340) by debbugs.gnu.org; 20 May 2020 14:20:18 +0000 Original-Received: from localhost ([127.0.0.1]:53888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbPZy-0002ZA-Gf for submit@debbugs.gnu.org; Wed, 20 May 2020 10:20:18 -0400 Original-Received: from mail-qk1-f181.google.com ([209.85.222.181]:47089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbPZw-0002Yx-9n for 41340@debbugs.gnu.org; Wed, 20 May 2020 10:20:16 -0400 Original-Received: by mail-qk1-f181.google.com with SMTP id f83so3603351qke.13 for <41340@debbugs.gnu.org>; Wed, 20 May 2020 07:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thompsonclan-org.20150623.gappssmtp.com; s=20150623; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=/AzVmDDpY1JiElm4y63af+3K7aH7FCHfhVUjw2x7t4Q=; b=UyoXLqKXgx8pG11v6xRpICvJfkv9vKToip0lcUN/CX4pYhcc6FlhoE3sTHmnL6PVDv 6sYUjjhnwJGvBb9LdTba2euLZRBck7SfL2iZivv9bJsNAMFkwMIUCq6sWKWTtFnE/0EP a2VdyVnBOnV6x0tKRhbRivHVUIyCEQpz9B/pyxPopY1zcUDuBdSvuScTXDEpLPXOlQSu yju1hEr3ettFu7ObU+B/BLYsYYEMoEhcBUD+fetFRQSyWAZX9RW6C0y9nwS+N2c7kC7q 7FN5uTL5P1rJLlCa9S1smrmrmsCwVkjKia0uFa72F2ZM9hpCr8AlmgVhKEcMr2NMOtQo gGhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/AzVmDDpY1JiElm4y63af+3K7aH7FCHfhVUjw2x7t4Q=; b=enjJ8u6UgV6ATLQ07sXHjlCfw2PLoyLX+KtBefz1KEjFUUPC7QdNUOvrQuGsG6MN5x UrXphmXQQMu5BKmfWUnS2WK/yknspHTG6VX/q5kW/k7m5kUy79/ZLvveWuWWsMTdJf4d 1swICidKQuimQHENlAe6X3L/VjkWbmyk08RF7xhLOKbxdyj64aIBB0ePM02fMzlyw2zS LObNg8DIO7oSEN/wlY4jw9gdvFpUG+fG8LKbKqI9SsG4M01r4wHH6NK7pjZ+xJ2FBDX5 TxcxWqBNxer0ZrvJm9fj2y2e6cJ3rMUP9YnL5xTJbe9PbUfWsfbTvJ5RySvfgJr7KXOd UhCQ== X-Gm-Message-State: AOAM532aIF2Ppv1hXyj5BNTc8MiU7w5iuvZg+kvIm51uFAPV+n93a66o 78tI1M8dow4asjZzPGF1h3awgK9pjPQoCw== X-Google-Smtp-Source: ABdhPJzkjX7PNrV+NNU6rYJy+scsPizYdljUE0yzXWfUsRT+G+jB9BU4/V34+JWQDowvosGnuJRJyQ== X-Received: by 2002:a05:620a:12fa:: with SMTP id f26mr4716235qkl.402.1589984409632; Wed, 20 May 2020 07:20:09 -0700 (PDT) Original-Received: from urania.local (c-73-29-32-68.hsd1.nj.comcast.net. [73.29.32.68]) by smtp.gmail.com with ESMTPSA id j45sm2716802qtk.14.2020.05.20.07.20.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2020 07:20:08 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180656 Archived-At: On 5/20/20 10:12 AM, Ryan C. Thompson wrote: > Ok, I figured out the difference between t and `lazy', and I > determined that the lazy setting is not meaningful for ido, since ido > already eagerly shows completions at all times. Hence, the attached > patch teaches ido how to respect `completion-auto-help' being set to > nil but doesn't make any special allowance for `lazy'. The existing > behavior of ido is already correct when `completion-auto-help' is > non-nil. Actually, on further consideration, I've realized a problem with this approach: this patch uses the value of `completion-auto-help' to determine whether to call `ido-cannot-complete-command'. However, the ido documentation mentions the possibility of setting `ido-cannot-complete-command' to `ido-next-match', which allows the user to cycle through available completions with repeated TAB presses. This patch kind of breaks that, in the sense that `completion-auto-help' ends up affecting something totally unrelated. Perhaps an better approach would be to define an auxiliary wrapper function that only calls `ido-completion-help' if `completion-auto-help' is non-nil, and set that as the default for `ido-cannot-complete-command'.