From: Drew Adams <drew.adams@oracle.com>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 25243@debbugs.gnu.org
Subject: bug#25243: 26.0.50; ffap-guesser very slow w/ region active in large diff files
Date: Fri, 23 Dec 2016 07:41:02 -0800 (PST) [thread overview]
Message-ID: <e264852a-17db-450c-947e-4499a69b8c92@default> (raw)
In-Reply-To: <871swzjeza.fsf@gmail.com>
below
> > 2. Instead of testing whether the max-length var is nil, I'd suggest
> > testing it with `natnump', to take care of the unexpected case where
> > it might get assigned a non-number.
> Yes, `natnump' is a better choice.
> + (if (or (not (natnump ffap-max-region-length))
> + (< region-len ffap-max-region-length)) ; Bug#25243.
> + (setf ffap-string-at-point-region (list beg end)
> + ffap-string-at-point
> + (buffer-substring-no-properties beg end))
> + (setf ffap-string-at-point-region (list 1 1)
> + ffap-string-at-point ""))))
I'd suggest the other way around. What you have lets someone or
some code assign a non-number and get the same slow behavior we
want to avoid. I'd say (and (natnump ...) (< region-len ...)).
IOW, if it's not a natnump and the size is not smaller than that
number then don't use the region.
The rest sounds good to me.
next prev parent reply other threads:[~2016-12-23 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 15:35 bug#25243: 26.0.50; ffap-guesser very slow w/ region active in large diff files Tino Calancha
2016-12-21 16:22 ` Drew Adams
2016-12-22 4:31 ` Tino Calancha
2016-12-22 17:22 ` Drew Adams
2016-12-23 7:12 ` Tino Calancha
2016-12-23 15:41 ` Drew Adams [this message]
2016-12-24 2:53 ` Tino Calancha
2016-12-30 6:41 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e264852a-17db-450c-947e-4499a69b8c92@default \
--to=drew.adams@oracle.com \
--cc=25243@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).