From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63949: 30.0.50; =?UTF-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs Date: Fri, 9 Jun 2023 01:09:11 +0200 Message-ID: References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: 63949@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 09 01:10:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7Olr-000AAI-Pd for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Jun 2023 01:10:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7OlY-00073g-Kh; Thu, 08 Jun 2023 19:10:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7OlW-00073P-LB for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 19:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7OlW-0002sC-A4 for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 19:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7OlV-0000pb-Ne for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 19:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2023 23:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63949 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16862657733154 (code B ref -1); Thu, 08 Jun 2023 23:10:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Jun 2023 23:09:33 +0000 Original-Received: from localhost ([127.0.0.1]:57874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Ol2-0000on-Ko for submit@debbugs.gnu.org; Thu, 08 Jun 2023 19:09:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:39500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Okw-0000oX-C1 for submit@debbugs.gnu.org; Thu, 08 Jun 2023 19:09:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Oku-00070p-91 for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 19:09:25 -0400 Original-Received: from mr3.vodafonemail.de ([145.253.228.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Oks-0002l4-1d for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 19:09:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686265759; bh=2VdP0I/QOi77sP9BdbGGcgLG7c+9gbZSb1iylEphUzQ=; h=Message-ID:Date:User-Agent:Subject:Content-Language:From:To: References:In-Reply-To:Content-Type:From; b=S9D4NoWozGfw9LMHXEikzd4EofuN5xH9M1D3sVEFkkEoGMM6rgdNTIs4D2MNgJ+qF 35Ujl/BDWACMMOlaJwI0FqNZnvjJolt/207yBW58MwbhaHXGtgM23FJkw0Fc1hFt00 5I7Jrk/Z8o0OKmc+nHWJJgeGcbKemMyFPLKTRhYo= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4Qcfzg48TKz23q7 for ; Thu, 8 Jun 2023 23:09:19 +0000 (UTC) Original-Received: from [192.168.178.41] (port-92-194-82-46.dynamic.as20676.net [92.194.82.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Qcfzb1ptmzKm4G for ; Thu, 8 Jun 2023 23:09:12 +0000 (UTC) Content-Language: de-DE-frami, en-US In-Reply-To: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> X-purgate-type: clean X-purgate: clean X-purgate-size: 617 X-purgate-ID: 155817::1686265755-C8FF84F8-B6D04F38/0/0 Received-SPF: pass client-ip=145.253.228.163; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr3.vodafonemail.de X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.091, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263146 Archived-At: Not sure about my previous patches 0004 and 0005. IMHO that commit d494833d47968fcd97ba549654a259d6fb6c2eee which introduced all these issues looks a bit flaky. (It does not even have a NEWS entry!) I think I understand what it's doing and the intention seems noble, even if it covers only a subset of VC operations. But that `with-current-buffer' around `vc-deduce-fileset', where that function explicitly declares that it changes buffer, seems to ask for more trouble. Probably somebody with deeper VC insight should review both commit d494833d47968fcd97ba549654a259d6fb6c2eee and my patches.