* bug#66539: 30.0.50; eldoc-echo-area-prefer-doc-buffer missing choice
@ 2023-10-14 13:32 Mauro Aranda
2023-10-14 13:36 ` Mauro Aranda
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-14 13:32 UTC (permalink / raw)
To: 66539
The docstring for eldoc-echo-area-prefer-doc-buffer says its value can
be the symbol maybe, but its :type is just boolean.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66539: 30.0.50; eldoc-echo-area-prefer-doc-buffer missing choice
2023-10-14 13:32 bug#66539: 30.0.50; eldoc-echo-area-prefer-doc-buffer missing choice Mauro Aranda
@ 2023-10-14 13:36 ` Mauro Aranda
2023-10-14 19:02 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-14 13:36 UTC (permalink / raw)
To: 66539
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
tags 66539 patch
quit
Patch attached. Please also note that this, and other user options are
missing the :version keyword (which I guess should be 28.1, at least for
this one)
[-- Attachment #2: 0001-Fix-a-defcustom-type.patch --]
[-- Type: text/x-patch, Size: 1131 bytes --]
From 9a583a2d4e5dacd4a443c3d37c096fa34f6ec17a Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Sat, 14 Oct 2023 10:34:54 -0300
Subject: [PATCH] Fix a defcustom :type
* lisp/emacs-lisp/eldoc.el (eldoc-echo-area-prefer-doc-buffer): Make
:type a choice, to allow for the value maybe. (Bug##66539)
---
lisp/emacs-lisp/eldoc.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index 3a786bb321b..941f1e4e157 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/emacs-lisp/eldoc.el
@@ -132,7 +132,9 @@ eldoc-echo-area-prefer-doc-buffer
buffer (displayed by `eldoc-doc-buffer') is already displayed in
some window. If the value is the symbol `maybe', then the echo area
is only skipped if the documentation needs to be truncated there."
- :type 'boolean)
+ :type '(choice (const :tag "Prefer ElDoc's documentation buffer" t)
+ (const :tag "Prefer echo area" nil)
+ (const :tag "Skip echo area if truncating" maybe)))
(defface eldoc-highlight-function-argument
'((t (:inherit bold)))
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-14 19:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-14 13:32 bug#66539: 30.0.50; eldoc-echo-area-prefer-doc-buffer missing choice Mauro Aranda
2023-10-14 13:36 ` Mauro Aranda
2023-10-14 19:02 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).