From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47699: [PATCH] Improve completion-list-mode-map Date: Tue, 25 May 2021 07:32:49 +0000 Message-ID: References: <3755fe92dcbf588701ae@heytings.org> <83o8el46rs.fsf@gnu.org> <3755fe92dc6b58671717@heytings.org> <83k0p944s5.fsf@gnu.org> <3755fe92dc4a9ba66a0b@heytings.org> <83im4t43ul.fsf@gnu.org> <3755fe92dc626b55646c@heytings.org> <83eefh3y0r.fsf@gnu.org> <3755fe92dc6a74421fa9@heytings.org> <83czv13q3l.fsf@gnu.org> <3755fe92dc3b94023c91@heytings.org> <877djn77gm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="55ZJ658heq" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3584"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47699@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 09:33:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llRYs-0000jO-Lu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 09:33:10 +0200 Original-Received: from localhost ([::1]:38680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llRYr-0007Dm-LC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 03:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llRYk-0007Da-V4 for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 03:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llRYk-000786-MJ for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 03:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llRYk-0001FP-IR for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 03:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 07:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 47699-submit@debbugs.gnu.org id=B47699.16219279744781 (code B ref 47699); Tue, 25 May 2021 07:33:02 +0000 Original-Received: (at 47699) by debbugs.gnu.org; 25 May 2021 07:32:54 +0000 Original-Received: from localhost ([127.0.0.1]:44563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llRYb-0001F3-Jc for submit@debbugs.gnu.org; Tue, 25 May 2021 03:32:53 -0400 Original-Received: from heytings.org ([95.142.160.155]:36070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llRYZ-0001Es-C0 for 47699@debbugs.gnu.org; Tue, 25 May 2021 03:32:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1621927969; bh=9EtqBrcRnyPJiRAxqxTgBAJdGA2mKzydS6Xw6iO9PcU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=RRScgx4fRSQ6DeYrI2imsG31vCY8T7hIpMCoR9V8EqXao8dIPOjaJn9CWAQQGTmhk qUKri7Qu+G0ApHap5WD7GF2juXLyY1roPhRr50fTcVj//HavRtgBtgieW081MDFNRc +Gq9iiYHmjgcPe4hlD5M1zKLsowEPA6V4ok5G9W7w2RHSCFrKwADOphAL/uStKjrn0 LGD3OAwU30495XeBZZHoJd/FU73xiOkodGs01NsPVP+dhYMyEDr3VxOgabfgXrHuUb bBzJTUhQMzVdvGdhOs4oLIIz5bwMt4LPM78+lktKZZ3eQXEdobJtHA7rAq3YQ8utVJ oyCAN0OibchPA== In-Reply-To: <877djn77gm.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207175 Archived-At: --55ZJ658heq Content-Type: text/plain; format=flowed; charset=us-ascii >> Thanks. Here is the updated patch. I tested it with minibuffer-only >> frames, and it seems to work. >> >> Are you sure that it's okay to rebind M-c in >> minibuffer-local-completion-map? It's a good mnemonic for >> "completion", but it hides the capitalize-word binding, that users >> might possibly want to use there (I don't, it's only when thinking >> about this patch that I realized this). >> >> Another option would be M-g, which would not hide anything that is >> possibly useful in the minibuffer, and is still a mnemonic of "goto". > > Thanks; applied to Emacs 28. > > I went with `M-g' -- it seems pretty natural here. If anybody else > wants a different key binding, go ahead and change it. > Juri said recently that he uses some of the keys in M-g in the minibuffer, so I changed my mind, and I now think that it would be better to use 'M-g M-c' for this, which is unused, and does not hide the complete M-g map. Updated patch attached. WDYT? --55ZJ658heq Content-Type: text/x-diff; name=Switch-between-minibuffer-and-Completions.patch Content-Transfer-Encoding: base64 Content-ID: Content-Description: Content-Disposition: attachment; filename=Switch-between-minibuffer-and-Completions.patch RnJvbSA0ZDZhMzMwMzhlODIwYzYwNDNkNzE2MzVmZWUyNDE5NTEyMjkyNDFl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUdWUsIDI1IE1h eSAyMDIxIDA3OjE5OjQxICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIFN3aXRj aCBiZXR3ZWVuIG1pbmlidWZmZXIgYW5kICpDb21wbGV0aW9ucyoNCg0KKiBs aXNwL3NpbXBsZS5lbCAoY29tcGxldGlvbi1saXN0LW1vZGUtbWFwKTogTWFr ZSBzcGVjaWFsLW1vZGUtbWFwIGl0cw0KcGFyZW50LCB1bmJpbmQgdGhlICdn JyByZXZlcnQga2V5LCBiaW5kIHRoZSAnbicgYW5kICdwJyBrZXlzIHRvDQpu ZXh0LWNvbXBsZXRpb24gYW5kIHByZXZpb3VzLWNvbXBsZXRpb24sIGFuZCB0 aGUgTS1nIE0tYyBrZXkgdG8NCnN3aXRjaC10by1taW5pYnVmZmVyLg0KKHJl YWQtZXhwcmVzc2lvbi1tYXApOiBCaW5kIE0tZyBNLWMgdG8gcmVhZC1leHBy ZXNzaW9uLXN3aXRjaC10by1jb21wbGV0aW9ucy4NCihzd2l0Y2gtdG8tbWlu aWJ1ZmZlciwgcmVhZC1leHByZXNzaW9uLXN3aXRjaC10by1jb21wbGV0aW9u cyk6IE5ldw0KZnVuY3Rpb25zLg0KDQoqIGxpc3AvbWluaWJ1ZmZlci5lbCAo bWluaWJ1ZmZlci1sb2NhbC1jb21wbGV0aW9uLW1hcCk6IEJpbmQgdGhlIE0t ZyBNLWMNCmtleSB0byBzd2l0Y2gtdG8tY29tcGxldGlvbi4NCg0KKiBkb2Mv ZW1hY3Mvd2luZG93cy50ZXhpIChUZW1wb3JhcnkgRGlzcGxheXMpOiBEb2N1 bWVudCB0aGUgY2hhbmdlLg0KLS0tDQogZG9jL2VtYWNzL3dpbmRvd3MudGV4 aSB8ICA4ICsrKysrLS0tDQogbGlzcC9taW5pYnVmZmVyLmVsICAgICB8ICAx ICsNCiBsaXNwL3NpbXBsZS5lbCAgICAgICAgIHwgMTggKysrKysrKysrKysr KysrKysrDQogMyBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAz IGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL3dpbmRv d3MudGV4aSBiL2RvYy9lbWFjcy93aW5kb3dzLnRleGkNCmluZGV4IGM2NmRl Yjc3NDguLjRhYjY0MWU3ODQgMTAwNjQ0DQotLS0gYS9kb2MvZW1hY3Mvd2lu ZG93cy50ZXhpDQorKysgYi9kb2MvZW1hY3Mvd2luZG93cy50ZXhpDQpAQCAt NTQxLDkgKzU0MSwxMSBAQCB0aGUgZm9sbG93aW5nIGZvcm0gaW4geW91ciBp bml0aWFsaXphdGlvbiBmaWxlIChAcHhyZWZ7SW5pdCBGaWxlfSk6DQogQGZp bmRleCB0ZW1wLWJ1ZmZlci1yZXNpemUtbW9kZQ0KICAgVGhlIEBmaWxleypD b21wbGV0aW9ucyp9IGJ1ZmZlciBpcyBhbHNvIHNwZWNpYWwgaW4gdGhlIHNl bnNlIHRoYXQNCiBFbWFjcyB1c3VhbGx5IHRyaWVzIHRvIG1ha2UgaXRzIHdp bmRvdyBqdXN0IGFzIGxhcmdlIGFzIG5lY2Vzc2FyeSB0bw0KLWRpc3BsYXkg YWxsIG9mIGl0cyBjb250ZW50cy4gIFRvIHJlc2l6ZSB3aW5kb3dzIHNob3dp bmcgb3RoZXINCi10ZW1wb3JhcnkgZGlzcGxheXMsIGxpa2UsIGZvciBleGFt cGxlLCB0aGUgQGZpbGV7KkhlbHAqfSBidWZmZXIsIHR1cm4NCi1vbiB0aGUg bWlub3IgbW9kZSAoQHB4cmVme01pbm9yIE1vZGVzfSkgQGNvZGV7dGVtcC1i dWZmZXItcmVzaXplLW1vZGV9DQorZGlzcGxheSBhbGwgb2YgaXRzIGNvbnRl bnRzLCBhbmQgdGhhdCB5b3UgY2FuIHN3aXRjaCBiYWNrIGFuZCBmb3J0aA0K K2JldHdlZW4gdGhlIG1pbmlidWZmZXIgYW5kIHRoZSBAZmlsZXsqQ29tcGxl dGlvbnMqfSBidWZmZXIgYnkgdHlwaW5nDQorQGtleXtNLWcgTS1jfS4gIFRv IHJlc2l6ZSB3aW5kb3dzIHNob3dpbmcgb3RoZXIgdGVtcG9yYXJ5IGRpc3Bs YXlzLA0KK2xpa2UsIGZvciBleGFtcGxlLCB0aGUgQGZpbGV7KkhlbHAqfSBi dWZmZXIsIHR1cm4gb24gdGhlIG1pbm9yIG1vZGUNCisoQHB4cmVme01pbm9y IE1vZGVzfSkgQGNvZGV7dGVtcC1idWZmZXItcmVzaXplLW1vZGV9DQogKEBw eHJlZntUZW1wb3JhcnkgRGlzcGxheXMsLFRlbXBvcmFyeSBEaXNwbGF5cywg ZWxpc3AsIFRoZSBFbWFjcyBMaXNwDQogUmVmZXJlbmNlIE1hbnVhbH0pLg0K IA0KZGlmZiAtLWdpdCBhL2xpc3AvbWluaWJ1ZmZlci5lbCBiL2xpc3AvbWlu aWJ1ZmZlci5lbA0KaW5kZXggZTA0ZjEwNDBiMy4uZWMyMWI3YjkzYiAxMDA2 NDQNCi0tLSBhL2xpc3AvbWluaWJ1ZmZlci5lbA0KKysrIGIvbGlzcC9taW5p YnVmZmVyLmVsDQpAQCAtMjYwMyw2ICsyNjAzLDcgQEAgVGhlIGNvbXBsZXRp b24gbWV0aG9kIGlzIGRldGVybWluZWQgYnkgYGNvbXBsZXRpb24tYXQtcG9p bnQtZnVuY3Rpb25zJy4iDQogICAgIChkZWZpbmUta2V5IG1hcCAiPyIgJ21p bmlidWZmZXItY29tcGxldGlvbi1oZWxwKQ0KICAgICAoZGVmaW5lLWtleSBt YXAgW3ByaW9yXSAnc3dpdGNoLXRvLWNvbXBsZXRpb25zKQ0KICAgICAoZGVm aW5lLWtleSBtYXAgIlxNLXYiICAnc3dpdGNoLXRvLWNvbXBsZXRpb25zKQ0K KyAgICAoZGVmaW5lLWtleSBtYXAgIlxNLWdcTS1jIiAgJ3N3aXRjaC10by1j b21wbGV0aW9ucykNCiAgICAgbWFwKQ0KICAgIkxvY2FsIGtleW1hcCBmb3Ig bWluaWJ1ZmZlciBpbnB1dCB3aXRoIGNvbXBsZXRpb24uIikNCiANCmRpZmYg LS1naXQgYS9saXNwL3NpbXBsZS5lbCBiL2xpc3Avc2ltcGxlLmVsDQppbmRl eCAyYTkwYTA3NjMxLi5jYWMzMDU4ODI1IDEwMDY0NA0KLS0tIGEvbGlzcC9z aW1wbGUuZWwNCisrKyBiL2xpc3Avc2ltcGxlLmVsDQpAQCAtMTY2MSw2ICsx NjYxLDcgQEAgaW4gKkhlbHAqIGJ1ZmZlci4gIFNlZSBhbHNvIHRoZSBjb21t YW5kIGBkZXNjcmliZS1jaGFyJy4iDQogICAgIChkZWZpbmUta2V5IG0gIlx0 IiAnY29tcGxldGlvbi1hdC1wb2ludCkNCiAgICAgKGRlZmluZS1rZXkgbSAi XHIiICdyZWFkLS1leHByZXNzaW9uLXRyeS1yZWFkKQ0KICAgICAoZGVmaW5l LWtleSBtICJcbiIgJ3JlYWQtLWV4cHJlc3Npb24tdHJ5LXJlYWQpDQorICAg IChkZWZpbmUta2V5IG0gIlxNLWdcTS1jIiAncmVhZC1leHByZXNzaW9uLXN3 aXRjaC10by1jb21wbGV0aW9ucykNCiAgICAgKHNldC1rZXltYXAtcGFyZW50 IG0gbWluaWJ1ZmZlci1sb2NhbC1tYXApDQogICAgIG0pKQ0KIA0KQEAgLTg4 MzQsNiArODgzNSw4IEBAIG1ha2VzIGl0IGVhc2llciB0byBlZGl0IGl0LiIN CiANCiAoZGVmdmFyIGNvbXBsZXRpb24tbGlzdC1tb2RlLW1hcA0KICAgKGxl dCAoKG1hcCAobWFrZS1zcGFyc2Uta2V5bWFwKSkpDQorICAgIChzZXQta2V5 bWFwLXBhcmVudCBtYXAgc3BlY2lhbC1tb2RlLW1hcCkNCisgICAgKGRlZmlu ZS1rZXkgbWFwICJnIiBuaWwpIDs7IFRoZXJlJ3Mgbm90aGluZyB0byByZXZl cnQgZnJvbS4NCiAgICAgKGRlZmluZS1rZXkgbWFwIFttb3VzZS0yXSAnY2hv b3NlLWNvbXBsZXRpb24pDQogICAgIChkZWZpbmUta2V5IG1hcCBbZm9sbG93 LWxpbmtdICdtb3VzZS1mYWNlKQ0KICAgICAoZGVmaW5lLWtleSBtYXAgW2Rv d24tbW91c2UtMl0gbmlsKQ0KQEAgLTg4NDUsNiArODg0OCw5IEBAIG1ha2Vz IGl0IGVhc2llciB0byBlZGl0IGl0LiINCiAgICAgKGRlZmluZS1rZXkgbWFw IFtiYWNrdGFiXSAncHJldmlvdXMtY29tcGxldGlvbikNCiAgICAgKGRlZmlu ZS1rZXkgbWFwICJxIiAncXVpdC13aW5kb3cpDQogICAgIChkZWZpbmUta2V5 IG1hcCAieiIgJ2tpbGwtY3VycmVudC1idWZmZXIpDQorICAgIChkZWZpbmUt a2V5IG1hcCAibiIgJ25leHQtY29tcGxldGlvbikNCisgICAgKGRlZmluZS1r ZXkgbWFwICJwIiAncHJldmlvdXMtY29tcGxldGlvbikNCisgICAgKGRlZmlu ZS1rZXkgbWFwICJcTS1nXE0tYyIgJ3N3aXRjaC10by1taW5pYnVmZmVyKQ0K ICAgICBtYXApDQogICAiTG9jYWwgbWFwIGZvciBjb21wbGV0aW9uIGxpc3Qg YnVmZmVycy4iKQ0KIA0KQEAgLTkxMzMsNiArOTEzOSwxOCBAQCBzZWxlY3Qg dGhlIGNvbXBsZXRpb24gbmVhciBwb2ludC5cblxuIikpKSkpKQ0KICAgICAg IDs7IEZJWE1FOiBQZXJoYXBzIHRoaXMgc2hvdWxkIGJlIGRvbmUgaW4gYG1p bmlidWZmZXItY29tcGxldGlvbi1oZWxwJy4NCiAgICAgICAod2hlbiAoYm9i cCkNCiAJKG5leHQtY29tcGxldGlvbiAxKSkpKSkNCisNCisoZGVmdW4gcmVh ZC1leHByZXNzaW9uLXN3aXRjaC10by1jb21wbGV0aW9ucyAoKQ0KKyAgIlNl bGVjdCB0aGUgY29tcGxldGlvbiBsaXN0IHdpbmRvdyB3aGlsZSByZWFkaW5n IGFuIGV4cHJlc3Npb24uIg0KKyAgKGludGVyYWN0aXZlKQ0KKyAgKGNvbXBs ZXRpb24taGVscC1hdC1wb2ludCkNCisgIChzd2l0Y2gtdG8tY29tcGxldGlv bnMpKQ0KKw0KKyhkZWZ1biBzd2l0Y2gtdG8tbWluaWJ1ZmZlciAoKQ0KKyAg IlNlbGVjdCB0aGUgbWluaWJ1ZmZlciB3aW5kb3cuIg0KKyAgKGludGVyYWN0 aXZlKQ0KKyAgKHdoZW4gKGFjdGl2ZS1taW5pYnVmZmVyLXdpbmRvdykNCisg ICAgKHNlbGVjdC13aW5kb3cgKGFjdGl2ZS1taW5pYnVmZmVyLXdpbmRvdykp KSkNCiAMDQogOzs7IFN1cHBvcnQga2V5Ym9hcmQgY29tbWFuZHMgdG8gdHVy biBvbiB2YXJpb3VzIG1vZGlmaWVycy4NCiANCi0tIA0KMi4zMC4yDQoNCg== --55ZJ658heq--