From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Date: Tue, 25 May 2021 12:44:34 +0000 Message-ID: References: <7dee3f4235cf450a3254@heytings.org> <83mttxwgm8.fsf@gnu.org> <1869622e16688e6aedec@heytings.org> <83h7k5w54l.fsf@gnu.org> <83fszpw40t.fsf@gnu.org> <1869622e16c60dc2ce0d@heytings.org> <83eef9w0xd.fsf@gnu.org> <1869622e16270efbc7e8@heytings.org> <87im3778ao.fsf@gnus.org> <83eedvc9jm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27165"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 47832@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 14:45:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llWQz-0006sx-9l for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 14:45:21 +0200 Original-Received: from localhost ([::1]:39586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llWQy-0000Xh-B9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 08:45:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llWQh-0000XV-At for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 08:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llWQg-0001y2-2V for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 08:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llWQf-0005Ix-Ug for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 08:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47832 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 47832-submit@debbugs.gnu.org id=B47832.162194668120342 (code B ref 47832); Tue, 25 May 2021 12:45:01 +0000 Original-Received: (at 47832) by debbugs.gnu.org; 25 May 2021 12:44:41 +0000 Original-Received: from localhost ([127.0.0.1]:44919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWQL-0005I1-0E for submit@debbugs.gnu.org; Tue, 25 May 2021 08:44:41 -0400 Original-Received: from heytings.org ([95.142.160.155]:36434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWQH-0005Hp-M8 for 47832@debbugs.gnu.org; Tue, 25 May 2021 08:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1621946675; bh=3wlvdDmU3sOWRy0NmOuA39CG825azmVVt0UX08U4gHw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=xURp1L0EOrpqNIqysHyC1fKXNXD/CZOIYnUSmHhhbAatdK2l/Gt7S1g73Y6EJ1JMd ROnfT3fqbp4IrwJn3CJ3+svd+knHKu2/z86ep/LWoUZQtO/jhKIXMInmaVYZkb36Vt G9IX7Vf0Kme52RbP80knGASvZI/kGJSq1Qc2RG498hqWNcGwhleSrE4K7GRmmBgLmU N6LVc4IGq0tbO09uuIXLnlZe9QGh1NjZXm1S7IDg18iCMCQ1NLmI1grdFFO3F1abT/ K/rtBmxzHcsrp1kE2fIzYFHTn31b0ol3n0z2C4kHjdEcSGNgwhoxwBxPXuuJCjvtug qdw/LVQB2tjDA== In-Reply-To: <83eedvc9jm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207200 Archived-At: >> diff --git a/src/fringe.c b/src/fringe.c >> index 65c9a84..47615f5 100644 >> --- a/src/fringe.c >> +++ b/src/fringe.c >> @@ -1776,14 +1776,15 @@ gui_init_fringe (struct redisplay_interface *rif) >> for (bt = NO_FRINGE_BITMAP + 1; bt < MAX_STANDARD_FRINGE_BITMAPS; bt++) >> { >> struct fringe_bitmap *fb = &standard_bitmaps[bt]; >> - rif->define_fringe_bitmap (bt, fb->bits, fb->height, fb->width); >> + if (!fringe_bitmaps[bt]) >> + rif->define_fringe_bitmap (bt, fb->bits, fb->height, fb->width); >> } >> >> /* Set up user-defined fringe bitmaps that might have been defined >> before the frame of this kind was initialized. This can happen >> if Emacs is started as a daemon and the init files define fringe >> bitmaps. */ >> - for ( ; bt < max_used_fringe_bitmap; bt++) >> + for (bt = NO_FRINGE_BITMAP + 1; bt < max_used_fringe_bitmap; bt++) >> { >> struct fringe_bitmap *fb = fringe_bitmaps[bt]; >> if (fb) > > Why does the second for-loop go again over the bitmaps that the first > one already processed? Or what am I missing? > Each loop processes its "own" bitmaps. In the first loop define_fringe_bitmap is called only if (!fringe_bitmaps[bt]), in the second loop it is called only if (fringe_bitmaps[bt]). IOW, the first loop processes the standard bitmaps that are not overridden by user-defined bitmaps, and the second loop processes user-defined bitmaps.