From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Date: Thu, 2 Feb 2023 22:01:11 +0100 Message-ID: References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------EynyYrui00wTXy0tCpVleqw6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4470"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 02 22:03:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNgji-0000w6-7l for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Feb 2023 22:03:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNgih-0005aG-DL; Thu, 02 Feb 2023 16:02:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNgic-0005XP-5Q for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 16:02:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNgib-00044d-TD for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 16:02:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNgib-0002zt-OW for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 16:02:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 21:02:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs Original-Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167537168611401 (code B ref 61104); Thu, 02 Feb 2023 21:02:05 +0000 Original-Received: (at 61104) by debbugs.gnu.org; 2 Feb 2023 21:01:26 +0000 Original-Received: from localhost ([127.0.0.1]:35958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNghy-0002xp-4m for submit@debbugs.gnu.org; Thu, 02 Feb 2023 16:01:26 -0500 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:39515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNghw-0002wT-Hp for 61104@debbugs.gnu.org; Thu, 02 Feb 2023 16:01:25 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id CDEC63200920; Thu, 2 Feb 2023 16:01:17 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 02 Feb 2023 16:01:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm2; t= 1675371677; x=1675458077; bh=vShrelAKnsqs4slRmPra1bkvvrbz8nfWj7r fy/7qnMc=; b=YpbYcGtzdDnVkwvHpz4cZO/CcskzmFAUh1w9A4JErrcUDrsmtnG j08E8t4M46E3gxPB/Z+USzfKv0HbMHLUGQVV+emFP1s3LsXnziTeFG1JPqFkT7NV 1gc4liyYlj/ShPNgKHIZ4eiUCwyByzfQLG/3M3O9aTSYK0lo7rnjJydhqZvkPsG+ ki3PL58yrNJluMyGgDd0YnNQVkNKOBegOCSw7urwqbeuVEn6R5YhQPJBir364Em0 jlQ72MyM9yolVHBQQ/RguyXe6T3e2TC0SacPFKT0arkti7hNvO8J3/nPpsGmN3Pp XgHTyB1uDzm/XEbCBCk/ghPB0jXS/TuXFEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1675371677; x=1675458077; bh=vShrelAKnsqs4 slRmPra1bkvvrbz8nfWj7rfy/7qnMc=; b=mgpI4aH1WFyLo63BF5+aA/OgIBtQN hFUHLWdkiGeWZg5mZ7ogOpbEVaYeLmsTS/NPEZYh7sYo9asO9ks91/76nrWFeI6I zxomcavoVBzMAJDwbfBuPXGvz78VHup6nIYVkhaOTxTCYZQwipqZJCAnnh82cxGb Mer79JkYLa+eApMNnOWjNSQX0XBvpjaBQ6ZqpRMlNKhFVk3ezo+1lxv2lYXy2JfJ OeFbuGurYPbwKEYgxUYlON4hCthPfnELgQ0gn5xGOhKziW3rhsVqwBIL1UzpjQy7 Dy/cG0lI+QZTu26r13Je+geGiNgTaegMpyOZTsEsaNGv5dFC9B82xlaEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfrhfuhffvvehfjgesrgdtreertdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdegkedvhfelveekgedtffdt lefhheffuddutddtgeehieejffekvdejhfeiteelnecuffhomhgrihhnpehkjhhnihhgsh gvnhdrnhhopdgvlhdrihhsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvg ht X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 16:01:15 -0500 (EST) Content-Language: en-GB, nb-NO In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254696 Archived-At: This is a multi-part message in MIME format. --------------EynyYrui00wTXy0tCpVleqw6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Any news on this one? Will this be merged? :) Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 1/28/23 15:28, Jostein Kjønigsen wrote: > > On 1/28/23 08:23, Eli Zaretskii wrote: >> >> I don't think doing this in the major-mode file will improve locality, >> because we have compilation-minor-mode, which should be able to do its >> thing even if the relevant major mode is not yet loaded. > Fair enough! >> >>> - adding it in compile.el, to improve ability to oversee all >>> expressions, and be able to optimize those? >>> >>> I see csharp-mode.el has the expressions added directly there. Should I >>> go about preparing patches doing >>> the same for typescript-ts-mode too? >> I don't see why not. > > Ok. Attached is a patch which adds Typescript tsc-support to > compile.el. Is this OK to install in emacs-29? > > I also see in retrospect that my comment about csharp-mode above may > been somewhat ambiguous and easy to misunderstand (and seemingly you > did). > > To be clear: csharp-mode includes the compilation-mode regexps in the > major-mode, not in compile.el. Is this also something we should aim to > fix for emacs-29, or should we leave that for master? > > -- > Jostein --------------EynyYrui00wTXy0tCpVleqw6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Any news on this one? Will this be merged? :)

Vennlig hilsen
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 1/28/23 15:28, Jostein Kjønigsen wrote:

On 1/28/23 08:23, Eli Zaretskii wrote:

I don't think doing this in the major-mode file will improve locality,
because we have compilation-minor-mode, which should be able to do its
thing even if the relevant major mode is not yet loaded.
Fair enough!

- adding it in compile.el, to improve ability to oversee all
expressions, and be able to optimize those?

I see csharp-mode.el has the expressions added directly there. Should I
go about preparing patches doing
the same for typescript-ts-mode too?
I don't see why not.

Ok. Attached is a patch which adds Typescript tsc-support to compile.el. Is this OK to install in emacs-29?

I also see in retrospect that my comment about csharp-mode above may been somewhat ambiguous and easy to misunderstand (and seemingly you did).

To be clear: csharp-mode includes the compilation-mode regexps in the major-mode, not in compile.el. Is this also something we should aim to fix for emacs-29, or should we leave that for master?

--
Jostein
--------------EynyYrui00wTXy0tCpVleqw6--