From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#21112: 25; Patch: show minibuffer messages with a face Date: Wed, 26 Jun 2019 15:13:00 -0700 (PDT) Message-ID: References: <55AF90B9.5040401@gmail.com> <87si0jvkgv.fsf@gnus.org> <87pnn11nm5.fsf@mail.linkov.net> <85ec41db-186f-4ab7-8660-5561f4599a27@default> <877e98t592.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="52994"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , Raffaele Ricciardi , 21112@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 00:14:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgGB9-000Dec-5a for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 00:14:11 +0200 Original-Received: from localhost ([::1]:45168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgGB7-0001si-FC for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 18:14:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38199) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgGB1-0001sb-C9 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 18:14:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgGB0-0004Gc-AA for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 18:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgGB0-0004GH-50 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 18:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgGAz-0006UD-Ry for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 18:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 22:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix patch Original-Received: via spool by 21112-submit@debbugs.gnu.org id=B21112.156158719024846 (code B ref 21112); Wed, 26 Jun 2019 22:14:01 +0000 Original-Received: (at 21112) by debbugs.gnu.org; 26 Jun 2019 22:13:10 +0000 Original-Received: from localhost ([127.0.0.1]:37151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgGAA-0006Sg-A8 for submit@debbugs.gnu.org; Wed, 26 Jun 2019 18:13:10 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:52868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgGA8-0006SP-Sl for 21112@debbugs.gnu.org; Wed, 26 Jun 2019 18:13:09 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5QM9usA187634; Wed, 26 Jun 2019 22:13:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Fp+wxAYs33WhFZv8cKIQfRW3sfabIDPTNupjDLiJefg=; b=VpABZ/KRdjFhCM8P20uBb9nXFovdnZ3LHbWyIuo3ZxJ9nVyyKTX7lP9Q9U8I7cTkbd7h DuyuPc2wpEfoXYBtYPayZrSGU0Fmd7ZKQ1Q6Vhlm2WdA9ft6pue3U2hMZKYgulRXibrc MQRQRQt+Ck87V0RDb1WEcQ33nliyORBHjzVXsUqVJA5MA62hN9iN+fTBy3RdNEmAJmpt A2jhh4GZpZLMtWQRHKGXQkwjY9+tjTn5oSFO15w7gn5nlvNBuFCUxr012xwWXIQg4Awe jhq5PlwZMZsSit/rDUhX0lINo4+4dIF3PiGXWJ5YrRE3cPu3bkKhMjoYzhpfcjhqsXLv nQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2t9c9pvvfc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 22:13:02 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5QMD2Gx002005; Wed, 26 Jun 2019 22:13:02 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2t9p6v107k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 22:13:02 +0000 Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5QMD1kO031086; Wed, 26 Jun 2019 22:13:01 GMT In-Reply-To: <877e98t592.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9300 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906260253 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9300 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906260253 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161546 Archived-At: > >> But since a message is displayed at different part of the minibuffer, > >> it should be highlighted using a new separate customizable variable > >> similar to minibuffer-prompt-properties: > > > > 1. If you go that route, which lets libraries and > > users easily change the properties (good), please > > separate Isearch and `minibuffer-message'. Use two > > different variables. They are not the same species. > > > > The default value could be, but it need not be, > > the same for both. >=20 > OK, implemented in the following patch. >=20 > > On the other hand, it could be helpful to separate > > out property `face', defining an actual face (for > > each of Isearch and `minibuffer-message') that > > users can customize for this. That also has the > > benefit that one can inherit from one to the other. > > > > The other properties would be applied first, so that > > if `face' is among them for some reason it will be > > overridden by the face provided specifically for this. >=20 > There are already too many faces in M-x list-faces-display > for users to comprehend that adding three more faces with > the same color would make matters worse. That's not a good argument for not adding faces. Users and libraries can already create any number of faces. The solution for that problem, which is not relevant here, is to give `list-faces-display' a way to filter (e.g. on an input pattern). Users deserve an easy way to have whatever faces they want for such prompts/msgs, including being able to inherit etc. Let them, not you/us, decide individually whether/when faces should appear the same. Easy to do. No penalty. But yes, `list-faces-display', like `list-colors-display' and some others, could benefit from incremental filtering. > > 2. The doc string of `minibuffer-message-properties' > > should not say that the properties are added to > > "minibuffer messages" - that's too broad. It should > > say that they are added to the text shown by function > > `minibuffer-message' - or else describe that text, > > and only that text, in another way. >=20 > OK, fixed in the attached patch. >=20 > > The doc string of the similar variable for Isearch > > should say that the properties are added to "the > > search prompt" or some such. Not sure whether the > > right description is "prompt", but whatever is the > > best way to describe it should be used in the doc > > string. >=20 > OK, added to this patch: Haven't looked at the patch (no time now), but I'm sure it's an improvement. Thx.