From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals Date: Mon, 08 Jan 2024 13:39:25 -0800 Message-ID: Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_0accceb5b644028fea89c9a75c65089f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7803"; mail-complaints-to="usenet@ciao.gmane.io" To: 68334@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 08 22:40:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMxLw-0001q2-9z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jan 2024 22:40:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMxLg-0001Sw-OI; Mon, 08 Jan 2024 16:39:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMxLf-0001So-JC for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 16:39:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMxLf-0006Wx-AP for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 16:39:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rMxLl-0001vk-ML for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 16:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jan 2024 21:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68334 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Bug-gnu Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.17047499907398 (code B ref -1); Mon, 08 Jan 2024 21:40:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Jan 2024 21:39:50 +0000 Original-Received: from localhost ([127.0.0.1]:37781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMxLY-0001vE-Kl for submit@debbugs.gnu.org; Mon, 08 Jan 2024 16:39:50 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:49514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMxLT-0001ux-DV for submit@debbugs.gnu.org; Mon, 08 Jan 2024 16:39:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMxLH-0001Io-NN for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 16:39:31 -0500 Original-Received: from greenhill.hpalace.com ([192.155.80.58]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMxLF-0006IP-CX for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 16:39:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1704749965; bh=f3WCYIXJK5e7tB6dmB+bZf8b5Jbk6a9+9CmKB/8+pN8=; h=Date:From:To:Subject:From; b=pkow+firPiZibmxmN2F1EvhOZ4oKqawsmJKabZVAu3eoNaN5pKPAsbH70k3x29aJq lPYpHo5G83yEF7aXvXFz/OTgEeKvsXVhBFiC+T+xRrlB/FqRmxm/53EvsU6jdkxMT3 NxBrM7UNwAfq1Eh6MdCsYaWmB0WhTW/6xqEobK6hyJxjZBElmxdNk/YEno11/NhBDu 7qOFqw57Oko9If3sNLDO0iFfszJyqCOBuKQgvN3CZQ85lI8mdsnfA70amo4pwQe7L7 Dgko3+L2uXbb9lm/HEAonxHTPpRSpauy9ckEUX8T/qRCvmN9Qx4NCOIiqRkqMrmRRr V4yd/XgWAvgAw== Original-Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 87FBA9A2 for ; Mon, 8 Jan 2024 21:39:25 +0000 (UTC) X-Sender: jared@finder.org Received-SPF: pass client-ip=192.155.80.58; envelope-from=jared@finder.org; helo=greenhill.hpalace.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277581 Archived-At: --=_0accceb5b644028fea89c9a75c65089f Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed I'd like tool-bar-make-keymap-1 to return a sensible keymap on terminals. This is only a small change from current code, patch attached. Context: I am writing a package that displays toolbars attached to an Emacs window instead of attached to the frame. You can see the package at . There's no intrinsic reason toolbars can't be useful in terminals and adding additional (usually ignored) keymap entries seems very safe. -- MJF In GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-09-11, modified by Debian built on melete System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/libexec --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-native-compilation --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/libexec --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-native-compilation --with-pgtk 'CFLAGS=-g -O2 -ffile-prefix-map=/build/emacs-N816CI/emacs-29.1+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: global-window-tool-bar-mode: t window-tool-bar-mode: t pixel-scroll-precision-mode: t recentf-mode: t global-subword-mode: t subword-mode: t global-form-feed-st-mode: t form-feed-st-mode: t icomplete-mode: t fido-mode: t electric-pair-mode: t delete-selection-mode: t cua-mode: t bar-cursor-mode: t url-handler-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t window-divider-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr smerge-mode diff pulse jka-compr help-fns radix-tree find-func xref project misearch multi-isearch mm-archive gnutls network-stream url-cache url-http url-auth url-gw nsm emacsbug ediff-vers ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util vc-hg vc-svn vc-dir ewoc vc checkdoc lisp-mnt vc-git diff-mode vc-dispatcher cursor-sensor finder-inf comp comp-cstr cl-extra help-mode markdown-mode rx color thingatpt noutline outline cus-edit pp cus-start cus-load window-tool-bar easy-mmode tab-line pixel-scroll recentf tree-widget wid-edit cap-words superword subword form-feed-st icomplete elec-pair delsel cua-base bar-cursor ls-lisp advice log-edit message sendmail yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log warnings icons compile text-property-search comint ansi-osc ansi-color ring init-dir bar-cursor-autoloads benchmark-init-autoloads dired-icon-autoloads form-feed-st-autoloads init-dir-autoloads markdown-mode-autoloads modus-themes-autoloads package-lint-autoloads compat-autoloads info slime-autoloads window-tool-bar-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core password-cache json map byte-opt bytecomp byte-compile url-vars modus-vivendi-theme modus-themes cl-macs pcase subr-x cl-loaddefs cl-lib gv rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 604030 131636) (symbols 48 25469 2) (strings 32 156826 21765) (string-bytes 1 7239778) (vectors 16 41746) (vector-slots 8 769733 48672) (floats 8 276 1190) (intervals 56 4786 466) (buffers 984 33)) --=_0accceb5b644028fea89c9a75c65089f Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-lisp-tool-bar.el-tool-bar-make-keymap-1-Populate-on-.patch Content-Disposition: attachment; filename=0001-lisp-tool-bar.el-tool-bar-make-keymap-1-Populate-on-.patch; size=1333 RnJvbSBiMDFjZGY1M2E0NWE2MDMzMmRlNDgyODVkNTEwNzkwOTA3MTUyZWE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXJlZCBGaW5kZXIgPGphcmVkQGZpbmRlci5vcmc+CkRhdGU6 IE1vbiwgOCBKYW4gMjAyNCAxMzoyMDoyNSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdICogbGlzcC90 b29sLWJhci5lbCAodG9vbC1iYXItbWFrZS1rZXltYXAtMSk6IFBvcHVsYXRlIG9uCiB0ZXJtaW5h bHMKCi0tLQogbGlzcC90b29sLWJhci5lbCB8IDE3ICsrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvdG9vbC1iYXIuZWwgYi9saXNwL3Rvb2wtYmFyLmVsCmluZGV4IDRjYTgxZmIwMWUwLi4zNmE4 MDUyMmM4MyAxMDA2NDQKLS0tIGEvbGlzcC90b29sLWJhci5lbAorKysgYi9saXNwL3Rvb2wtYmFy LmVsCkBAIC0xODAsMTUgKzE4MCwxNCBAQCB0b29sLWJhci1tYWtlLWtleW1hcC0xCiAJCQkgKGNv bnNwIGltYWdlLWV4cCkKIAkJCSAobm90IChlcSAoY2FyIGltYWdlLWV4cCkgJ2ltYWdlKSkKIAkJ CSAoZmJvdW5kcCAoY2FyIGltYWdlLWV4cCkpKQotCQkoaWYgKG5vdCAoZGlzcGxheS1pbWFnZXMt cCkpCi0JCSAgICAoc2V0cSBiaW5kIG5pbCkKLQkJICAobGV0ICgoaW1hZ2UgKGV2YWwgaW1hZ2Ut ZXhwKSkpCi0JCSAgICAodW5sZXNzIChhbmQgaW1hZ2UgKGltYWdlLW1hc2stcCBpbWFnZSkpCi0J CSAgICAgIChzZXRxIGltYWdlIChhcHBlbmQgaW1hZ2UgJyg6bWFzayBoZXVyaXN0aWMpKSkpCi0J CSAgICAoc2V0cSBiaW5kIChjb3B5LXNlcXVlbmNlIGJpbmQpCi0JCQkgIHBsaXN0IChudGhjZHIg KGlmIChjb25zcCAobnRoIDQgYmluZCkpIDUgNCkKLQkJCQkJYmluZCkpCi0JCSAgICAocGxpc3Qt cHV0IHBsaXN0IDppbWFnZSBpbWFnZSkpKSkKKwkJKGxldCAoKGltYWdlIChhbmQgKGRpc3BsYXkt aW1hZ2VzLXApCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGV2YWwgaW1hZ2Ut ZXhwKSkpKQorCQkgICh1bmxlc3MgKGFuZCBpbWFnZSAoaW1hZ2UtbWFzay1wIGltYWdlKSkKKwkJ ICAgIChzZXRxIGltYWdlIChhcHBlbmQgaW1hZ2UgJyg6bWFzayBoZXVyaXN0aWMpKSkpCisJCSAg KHNldHEgYmluZCAoY29weS1zZXF1ZW5jZSBiaW5kKQorCQkJcGxpc3QgKG50aGNkciAoaWYgKGNv bnNwIChudGggNCBiaW5kKSkgNSA0KQorCQkJCSAgICAgIGJpbmQpKQorCQkgIChwbGlzdC1wdXQg cGxpc3QgOmltYWdlIGltYWdlKSkpCiAJICAgICAgYmluZCkpCiAJICAob3IgbWFwIHRvb2wtYmFy LW1hcCkpKQogCi0tIAoyLjM5LjIKCg== --=_0accceb5b644028fea89c9a75c65089f--